From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 39BEB2B91 for ; Fri, 1 Jul 2016 10:02:50 +0200 (CEST) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 1451726F94; Fri, 1 Jul 2016 10:02:50 +0200 (CEST) From: Olivier Matz To: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com, bruce.richardson@intel.com Cc: amint@icsi.berkeley.edu Date: Fri, 1 Jul 2016 10:02:27 +0200 Message-Id: <1467360147-19571-1-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com> References: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix compilation when offload flags disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 08:02:50 -0000 The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n because the macro has not the proper number of parameters. To reproduce the issue: make config T=x86_64-native-linuxapp-gcc sed -i 's,CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y,CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n,' build/.config make -j4 [...] ixgbe_rxtx_vec_sse.c: In function ‘_recv_raw_pkts_vec’: ixgbe_rxtx_vec_sse.c:345:53: error: macro "desc_to_olflags_v" passed 3 arguments, but takes just 2 desc_to_olflags_v(descs, vlan_flags, &rx_pkts[pos]); ^ ixgbe_rxtx_vec_sse.c:345:3: error: ‘desc_to_olflags_v’ undeclared (first use in this function) desc_to_olflags_v(descs, vlan_flags, &rx_pkts[pos]); ^ ixgbe_rxtx_vec_sse.c:345:3: note: each undeclared identifier is reported only once for each function it appears in ixgbe_rxtx_vec_sse.c:231:10: error: variable ‘vlan_flags’ set but not used [-Werror=unused-but-set-variable] uint8_t vlan_flags; ^ cc1: all warnings being treated as errors This patch fixes the number of arguments in th macro, and ensure that vlan_flags is marked as used to avoid the third error. Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") Reported-by: Amin Tootoonchian Signed-off-by: Olivier Matz --- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c index 4f95deb..1c4fd7c 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c @@ -197,7 +197,9 @@ desc_to_olflags_v(__m128i descs[4], uint8_t vlan_flags, rx_pkts[3]->ol_flags = vol.e[3]; } #else -#define desc_to_olflags_v(desc, rx_pkts) do {} while (0) +#define desc_to_olflags_v(desc, vlan_flags, rx_pkts) do { \ + RTE_SET_USED(vlan_flags); \ + } while (0) #endif /* -- 2.8.1