From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C7F342BA8 for ; Fri, 1 Jul 2016 16:38:52 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 01 Jul 2016 07:38:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,557,1459839600"; d="scan'208";a="838711252" Received: from sie-lab-212-209.ir.intel.com (HELO silpixa00377983.ir.intel.com) ([10.237.212.209]) by orsmga003.jf.intel.com with ESMTP; 01 Jul 2016 07:38:51 -0700 From: Sergio Gonzalez Monroy To: dev@dpdk.org Cc: thomas.monjalon@6wind.com, konstantin.ananyev@intel.com Date: Fri, 1 Jul 2016 15:38:49 +0100 Message-Id: <1467383929-125734-2-git-send-email-sergio.gonzalez.monroy@intel.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1467383929-125734-1-git-send-email-sergio.gonzalez.monroy@intel.com> References: <1467303070-106383-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1467383929-125734-1-git-send-email-sergio.gonzalez.monroy@intel.com> Subject: [dpdk-dev] [PATCH v4 2/2] mk: fix acl library static linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 14:38:53 -0000 Since below commit, ACL library is outside the scope of --whole-archive and ACL autotest fails. RTE>>acl_autotest ACL: allocation of 25166728 bytes on socket 9 for ACL_acl_ctx failed ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid Line 1584: SSE classify with zero categories failed! Test Failed This is the result of the linker picking weak over non-weak functions. Fixes: 95dc3c3cf31c ("mk: reduce scope of whole-archive static linking") Signed-off-by: Sergio Gonzalez Monroy --- v4: - keep order of acl in _LDLIBS and wrap it with --whole-archive v3: - patch version history - carry Acked-by v2: - add comment in makefile mk/rte.app.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index bf8bcf9..ea22961 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -76,7 +76,10 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += -lrte_ip_frag _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched _LDLIBS-$(CONFIG_RTE_LIBRTE_LPM) += -lrte_lpm +# librte_acl needs --whole-archive because of weak functions +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += --whole-archive _LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += --no-whole-archive _LDLIBS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += -lrte_jobstats _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER) += -lrte_power -- 2.4.11