From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 629F76CA4 for ; Wed, 6 Jul 2016 12:38:59 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id 187so31673781wmz.1 for ; Wed, 06 Jul 2016 03:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=uZA3zp2gueKSypEnYux3xf02Cm7OpMO0+lmfOSC5R9U=; b=nSOlw/HurQszQdfmMlYNzKJHZDNu1nNA1QPgPXqSiRYyH5eQUyi2HrmjkIRz9pG5n7 Fd85SMLlqgMG4w6yKXio2hdK7tFgjh9lBk49e7VQgDbxsxFizY2IHAlEdAW7L4DsS26h lz07RByHFIxzvOd3z9B7jRs/8IhhYJbo+T1NKGzb4HgPxervFIOJNnKi1k4NBgfx8CXz J2zMj6P22I348qFpg+cH1dU2B2byb2NVJwOoNrSQEURdU4OHeWbindfW7id5HzBcHhnX xBZPq+VIN71ER7vxOO4q0uGqw2rAN+KHA+w2rOhSsTcTq3PSbM1UaQQ4yTv9tUgqcEvL QZOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=uZA3zp2gueKSypEnYux3xf02Cm7OpMO0+lmfOSC5R9U=; b=ap1XXLXIZU37wO50qVLZcIUPdDjqiS7ICs0z23f5+xcXgLZc2ZK31s3sr80ibyrwTn Ccqt2R3ES+OYqRcsWjBPObuIaxZGXsL1qTcXEFIMzQw3TG4BwDTUFniK2z4hSqs9iO81 XNOcIbe6UNdU2eqTskuXmW9SoJKElkUT2cJ+lryBMRvaAkLnNTNWKaqXI/oAtDY8Fsij aekZzK5GoDiZVfGU9P2nv08bpptgudYOoWhxnbINlR3pORKKBF2Yhvga2MG1tbcrs9h+ pazdxdCq7XY0sS4K7voBy8dmrIdJgUd0uteyythwbfVWZL14NGJfsaqMeihQbrH6HwI5 235A== X-Gm-Message-State: ALyK8tK/hlfecK/5mKpiLx2j0+TGv9eHT9aRF7xpYn1l6O+f4HZru58apDeHDdoFjh8wrCC2 X-Received: by 10.28.236.73 with SMTP id k70mr19561431wmh.65.1467801538977; Wed, 06 Jul 2016 03:38:58 -0700 (PDT) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id x194sm3381094wmf.13.2016.07.06.03.38.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Jul 2016 03:38:58 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Date: Wed, 6 Jul 2016 12:38:48 +0200 Message-Id: <1467801530-20800-2-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com> References: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com> Subject: [dpdk-dev] [PATCH 1/3] scripts: check spacing after commit references X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2016 10:38:59 -0000 A blank line between "Fixes" and "Signed-off-by" helps to separate information in blocks. Signed-off-by: Thomas Monjalon --- scripts/check-git-log.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh index c7fc0e4..a24f101 100755 --- a/scripts/check-git-log.sh +++ b/scripts/check-git-log.sh @@ -129,6 +129,12 @@ bad=$(echo "$tags" | sed 's,^.,\t&,') [ -z "$bad" ] || printf "Wrong tag:\n$bad\n" +# check blank line after last Fixes: tag +bad=$(echo "$bodylines" | + sed -n 'N;/\nFixes:/D;/\n$/D;/^Fixes:/P' | + sed 's,^.,\t&,') +[ -z "$bad" ] || printf "Missing blank line after 'Fixes' tag:\n$bad\n" + # check missing Fixes: tag bad=$(for fix in $fixes ; do git log --format='%b' -1 $fix | grep -q '^Fixes: ' || -- 2.7.0