From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 80451532D for ; Fri, 8 Jul 2016 03:11:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=885; q=dns/txt; s=iport; t=1467940272; x=1469149872; h=from:to:cc:subject:date:message-id; bh=PU5Ei+AjUJgTUBZjqnjZ4PUIASaxpKIaXSKAsleH8cU=; b=aLh68biMWpGVn9pa8ti4M/7X4FXA+r9MwzvHq49CkFCEBtHlkS8mb0+o yL5LFRdjzhvw4ZBR5rUOoQePmfvDb5VOaGbgEYZEvGPbeJZAF/AJG/a7c NRja5SPUK2m3ckAVsyiYDd9OVyHBKhyPXlNo/3c8ZkPphgvzoQN3PGVWq A=; X-IronPort-AV: E=Sophos;i="5.28,326,1464652800"; d="scan'208";a="294246591" Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jul 2016 01:11:11 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id u681BBXl012813; Fri, 8 Jul 2016 01:11:11 GMT Received: by cisco.com (Postfix, from userid 412739) id 6E53D3FAAE09; Thu, 7 Jul 2016 18:11:11 -0700 (PDT) From: Nelson Escobar To: dev@dpdk.org Cc: bruce.richardson@intel.com, Nelson Escobar Date: Thu, 7 Jul 2016 18:11:08 -0700 Message-Id: <1467940268-12229-1-git-send-email-neescoba@cisco.com> X-Mailer: git-send-email 2.7.0 Subject: [dpdk-dev] [PATCH 2/2] net/enic: fix removing old MAC address when setting new one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 01:11:12 -0000 enic_set_mac_address() meant to remove the old MAC address before setting the new one, but accidentally tried removing the new MAC address before setting the new MAC address. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: Nelson Escobar Reviewed-by: John Daley --- drivers/net/enic/enic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 1f3d14e..c3b1e87 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -203,7 +203,7 @@ void enic_set_mac_address(struct enic *enic, uint8_t *mac_addr) return; } - err = vnic_dev_del_addr(enic->vdev, mac_addr); + err = vnic_dev_del_addr(enic->vdev, enic->mac_addr); if (err) { dev_err(enic, "del mac addr failed\n"); return; -- 2.7.0