DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts
@ 2016-07-14 17:03 Rasesh Mody
  2016-07-14 17:03 ` [dpdk-dev] [PATCH 2/2] bnx2x: fix fw mempool name length Rasesh Mody
  2016-07-15 10:34 ` [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts Chas Williams
  0 siblings, 2 replies; 4+ messages in thread
From: Rasesh Mody @ 2016-07-14 17:03 UTC (permalink / raw)
  To: dev; +Cc: thomas.monjalon, Dept-EngDPDKDev, Rasesh Mody

Disable fastpath interrupts and remove unneeded delay in
bnx2x_interrupt_action(). This patch fixes and prevents performance
degradation for BNX2X PMD.

Fixes: 540a2110 ("bnx2x: driver core")

Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
---
 drivers/net/bnx2x/bnx2x.c        |    2 +-
 drivers/net/bnx2x/bnx2x_ethdev.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 95fbad8..a059858 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -4507,7 +4507,7 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp, int scan_fp)
 	}
 
 	bnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID,
-		   le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1);
+		   le16toh(fp->fp_hc_idx), IGU_INT_DISABLE, 1);
 }
 
 /*
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index c8d2bf2..f97dd5b 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -107,8 +107,8 @@ bnx2x_interrupt_action(struct rte_eth_dev *dev)
 
 	PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled");
 
-	if (bnx2x_intr_legacy(sc, 0))
-		DELAY_MS(250);
+	bnx2x_intr_legacy(sc, 0)
+
 	if (sc->periodic_flags & PERIODIC_GO)
 		bnx2x_periodic_callout(sc);
 	link_status = REG_RD(sc, sc->link_params.shmem_base +
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH 2/2] bnx2x: fix fw mempool name length
  2016-07-14 17:03 [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts Rasesh Mody
@ 2016-07-14 17:03 ` Rasesh Mody
  2016-07-15 10:34 ` [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts Chas Williams
  1 sibling, 0 replies; 4+ messages in thread
From: Rasesh Mody @ 2016-07-14 17:03 UTC (permalink / raw)
  To: dev; +Cc: thomas.monjalon, Dept-EngDPDKDev, Rasesh Mody

This patch fixes following error:
   EAL: Detected 36 lcore(s)
   EAL: Probing VFIO support...
   PMD: bnxt_rte_pmd_init() called for (null)
   EAL: PCI device 0000:08:00.0 on NUMA socket 0
   EAL:   probe driver: 14e4:16a1 rte_bnx2x_pmd
   EAL: PCI device 0000:08:00.1 on NUMA socket 0
   EAL:   probe driver: 14e4:16a1 rte_bnx2x_pmd
   Lcore 0: RX port 0
   Lcore 1: RX port 1
   Initializing port 0... EAL: Error - exiting with code: 1
     Cause: Cannot configure device: err=-6, port=0

Fixes: 540a2110 ("bnx2x: driver core")
Fixes: 85cf0079 ("mem: avoid memzone/mempool/ring name truncation")

Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
---
 drivers/net/bnx2x/bnx2x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index a059858..a49a07f 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -8886,7 +8886,7 @@ int bnx2x_alloc_hsi_mem(struct bnx2x_softc *sc)
 /***************************/
 
 		if (bnx2x_dma_alloc(sc, FW_BUF_SIZE, &sc->gz_buf_dma,
-				  "fw_dec_buf", RTE_CACHE_LINE_SIZE) != 0) {
+				  "fw_buf", RTE_CACHE_LINE_SIZE) != 0) {
 			sc->spq = NULL;
 			sc->sp = NULL;
 			sc->eq = NULL;
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts
  2016-07-14 17:03 [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts Rasesh Mody
  2016-07-14 17:03 ` [dpdk-dev] [PATCH 2/2] bnx2x: fix fw mempool name length Rasesh Mody
@ 2016-07-15 10:34 ` Chas Williams
  2016-07-15 16:40   ` Rasesh Mody
  1 sibling, 1 reply; 4+ messages in thread
From: Chas Williams @ 2016-07-15 10:34 UTC (permalink / raw)
  To: Rasesh Mody, dev; +Cc: thomas.monjalon, Dept-EngDPDKDev

On Thu, 2016-07-14 at 10:03 -0700, Rasesh Mody wrote:
> Disable fastpath interrupts and remove unneeded delay in
> bnx2x_interrupt_action(). This patch fixes and prevents performance
> degradation for BNX2X PMD.
> 
> Fixes: 540a2110 ("bnx2x: driver core")
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> 
> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
> index c8d2bf2..f97dd5b 100644
> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> @@ -107,8 +107,8 @@ bnx2x_interrupt_action(struct rte_eth_dev *dev)
>  
>  	PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled");
>  
> -	if (bnx2x_intr_legacy(sc, 0))
> -		DELAY_MS(250);
> +	bnx2x_intr_legacy(sc, 0)
> +

Trailing semicolon?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts
  2016-07-15 10:34 ` [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts Chas Williams
@ 2016-07-15 16:40   ` Rasesh Mody
  0 siblings, 0 replies; 4+ messages in thread
From: Rasesh Mody @ 2016-07-15 16:40 UTC (permalink / raw)
  To: Chas Williams, dev; +Cc: thomas.monjalon, Dept-Eng DPDK Dev

> From: Chas Williams [mailto:3chas3@gmail.com]
> Sent: Friday, July 15, 2016 3:35 AM
> 
> On Thu, 2016-07-14 at 10:03 -0700, Rasesh Mody wrote:
> > Disable fastpath interrupts and remove unneeded delay in
> > bnx2x_interrupt_action(). This patch fixes and prevents performance
> > degradation for BNX2X PMD.
> >
> > Fixes: 540a2110 ("bnx2x: driver core")
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> >
> > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
> > b/drivers/net/bnx2x/bnx2x_ethdev.c
> > index c8d2bf2..f97dd5b 100644
> > --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> > @@ -107,8 +107,8 @@ bnx2x_interrupt_action(struct rte_eth_dev *dev)
> >
> >  	PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled");
> >
> > -	if (bnx2x_intr_legacy(sc, 0))
> > -		DELAY_MS(250);
> > +	bnx2x_intr_legacy(sc, 0)
> > +
> 
> Trailing semicolon?

My bad, sorry, I didn’t send the latest patch, will send v2.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-07-15 16:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-14 17:03 [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts Rasesh Mody
2016-07-14 17:03 ` [dpdk-dev] [PATCH 2/2] bnx2x: fix fw mempool name length Rasesh Mody
2016-07-15 10:34 ` [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts Chas Williams
2016-07-15 16:40   ` Rasesh Mody

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).