From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id 2CDDA39EA for ; Fri, 15 Jul 2016 12:34:52 +0200 (CEST) Received: by mail-qt0-f195.google.com with SMTP id j37so3708992qta.0 for ; Fri, 15 Jul 2016 03:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=+hFXQDfB2Y/SdsxZ+X/SbpV597rn0wo9PO/Ku2JJqck=; b=pXvu8ePWtAsdPh8jFuPJ2RbB7BgfRVn1lq5q22BK+acr6VMsMFYuLwCTe3Vnr2G4hd KY3hpdIlUWgVNS7N0qVNrvVoXnbBpUMsZvzOiSOhdKfrt7uH69Wjw42riCNFC5ikrsa2 0HtZjrmunRToErSrQG8/90GYUV7opiqzNlYHXYEViJHuTYVoi+ZAQinfV6k/9wt8fPji 7YNWVmnJ+TLWZc/igxrZYmvij0eoipoV3L2Ofy8JzQxnAAESRzIanekJV4v3AH9MsgOg xmIeVah2BSnQvCFE1pYwsdsgmF396clmR21BIC6Pgf6K3bSYM+Qlsm124YfHVtarJ31P r6Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=+hFXQDfB2Y/SdsxZ+X/SbpV597rn0wo9PO/Ku2JJqck=; b=hI0IwQNKPGsakBxB5UA+eDiVHnw4DcuJoPk8U9BSCWxAAT/y8fdFZnQv4f1YB/lJZx 28KXayDc5Ztoja1sxIHlpElLIdBS5Q5NpgQAWFRL3nsB3B0eZLccVR3AdEnlVz613yW8 O7UHZAls98+47Ov+hjGzSUQBlozpUQ6Zb5N283zharwFNypKbIY4ZHdjGl09P38DiXWs gwHE4cafnGwV+I0hByMCD5b3/gJHiWVtauvFS1Za+ySN5eRFD8g8xm7QO1Vh7c4fB5vF ZkUJw2zhj0qORswKYdDNyiYCph/VCyrmMwDiJvqskD6sRWxi/oWoMKWMZBMccDjUMDE+ d0jg== X-Gm-Message-State: ALyK8tLVbDBeOffmBdvvprKTP6S2x1XQ8dem7ChvoMlf3iuA1neN44IE6MDXhHcM7d8BpA== X-Received: by 10.200.51.34 with SMTP id t31mr27811422qta.61.1468578891617; Fri, 15 Jul 2016 03:34:51 -0700 (PDT) Received: from monolith.home (pool-173-79-169-182.washdc.fios.verizon.net. [173.79.169.182]) by smtp.googlemail.com with ESMTPSA id q13sm3362132qkq.6.2016.07.15.03.34.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jul 2016 03:34:51 -0700 (PDT) Message-ID: <1468578890.1732.0.camel@gmail.com> From: Chas Williams <3chas3@gmail.com> To: Rasesh Mody , dev@dpdk.org Cc: thomas.monjalon@6wind.com, Dept-EngDPDKDev@qlogic.com Date: Fri, 15 Jul 2016 06:34:50 -0400 In-Reply-To: <1468515827-24865-1-git-send-email-rasesh.mody@qlogic.com> References: <1468515827-24865-1-git-send-email-rasesh.mody@qlogic.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: disable fast path interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 10:34:52 -0000 On Thu, 2016-07-14 at 10:03 -0700, Rasesh Mody wrote: > Disable fastpath interrupts and remove unneeded delay in > bnx2x_interrupt_action(). This patch fixes and prevents performance > degradation for BNX2X PMD. > > Fixes: 540a2110 ("bnx2x: driver core") > > Signed-off-by: Rasesh Mody >  > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > index c8d2bf2..f97dd5b 100644 > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > @@ -107,8 +107,8 @@ bnx2x_interrupt_action(struct rte_eth_dev *dev) >   >   PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled"); >   > - if (bnx2x_intr_legacy(sc, 0)) > - DELAY_MS(250); > + bnx2x_intr_legacy(sc, 0) > + Trailing semicolon?