From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
by dpdk.org (Postfix) with ESMTP id 6EC0C5580
for <dev@dpdk.org>; Fri, 29 Jul 2016 15:01:52 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id q128so289225237wma.1
for <dev@dpdk.org>; Fri, 29 Jul 2016 06:01:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id;
bh=DH7Jx16kvWpMcrz8HYlJ5HmYP9l41M9Sp8NWqnI7564=;
b=cXHJPqhVq9xxDNZiUnObpVb6IPOSIYxbxFlY1k5ausGAoNgoYc7NZOkm1z2STeRP6k
QBEUEAokteSQ2jNTd7z/VX3TlGywaHTpJpC3Q3NQABD8RHP6BO5N0wlgS0YS+chaGB0c
mMn8I+vlMNTIXx3oPFUzhHhwdTBbiMdDggT7sO329Aq+9NZNjOi3U6sifAQklYDsBnOs
FaHwsH1cPfM7PA0cZrxhSZxyhY97N8XbSZTQCghLL+l8mX/VD7vkshzjP5Ew8gZ8Fvs6
SKcghSirHk8JDtsMRtolH+M1Pp9reOWLaJJMuPQfNY6z+o1sSWQsBh5PhQKDyN5ZfmXN
QYEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id;
bh=DH7Jx16kvWpMcrz8HYlJ5HmYP9l41M9Sp8NWqnI7564=;
b=PIhflKyeMfqfSSVn5Gkni25rQL4b8Pa+xi1Lr7/JYsaMqe4CmkUk060O7nQFEJyTYE
4Q84QKojYSTivWWkcUb/ltne1mh9hQmWqDC9u7I8oH78RyqNpIzHcHB4o+RVuVfTPscR
EI021SZxzQy+pPeWJ1wTP7qxR22/N+YVgj8bOFaoOc8ewKofyIagQPivZYEOjRRInPFy
hQq1EKMQbxj4lw8W9P8nnsB/UDVqxke938f/Ev2jluEDDKdGvDjTGyQKnOppAtfglbNy
COzOpfMKgwLG8EFvHJqv+RoyVRoSBmvNhJsAJO5yiPBYg8SU+Wjm9GaCUUm70270xhzN
qWlQ==
X-Gm-Message-State: AEkoout1fYbfPErVGIJUftw6mKgq/RrmsfYwqYpfJVa6VGdF9WgWL6AT7b8YPA6vkNWT9f1B
X-Received: by 10.28.227.11 with SMTP id a11mr44892020wmh.29.1469797312069;
Fri, 29 Jul 2016 06:01:52 -0700 (PDT)
Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184])
by smtp.gmail.com with ESMTPSA id ex14sm65900wjc.30.2016.07.29.06.01.50
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Fri, 29 Jul 2016 06:01:51 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: david.marchand@6wind.com
Cc: dev@dpdk.org
Date: Fri, 29 Jul 2016 15:01:46 +0200
Message-Id: <1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com>
X-Mailer: git-send-email 2.7.0
Subject: [dpdk-dev] [PATCH] log: remove history dump
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2016 13:01:52 -0000
The log history feature was deprecated in 16.07.
The remaining empty functions are removed in 16.11.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
doc/guides/rel_notes/deprecation.rst | 3 ---
doc/guides/rel_notes/release_16_11.rst | 4 +++-
lib/librte_eal/common/eal_common_log.c | 19 ---------------
lib/librte_eal/common/include/rte_log.h | 41 ---------------------------------
4 files changed, 3 insertions(+), 64 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d2dc4a9..1b953fe 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -8,9 +8,6 @@ API and ABI deprecation notices are to be posted here.
Deprecation Notices
-------------------
-* The log history is deprecated.
- It is voided in 16.07 and will be removed in release 16.11.
-
* The ethdev library file will be renamed from libethdev.* to librte_ethdev.*
in release 16.11 in order to have a more consistent namespace.
diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index a6e3307..0b9022d 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -94,6 +94,8 @@ API Changes
This section is a comment. Make sure to start the actual text at the margin.
+* The log history is removed.
+
ABI Changes
-----------
@@ -131,7 +133,7 @@ The libraries prepended with a plus sign were incremented in this version.
librte_cmdline.so.2
librte_cryptodev.so.1
librte_distributor.so.1
- librte_eal.so.2
+ + librte_eal.so.3
librte_hash.so.2
librte_ip_frag.so.1
librte_ivshmem.so.1
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index 7916c78..967991a 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -64,19 +64,6 @@ static RTE_DEFINE_PER_LCORE(struct log_cur_msg, log_cur_msg);
/* default logs */
-int
-rte_log_add_in_history(const char *buf __rte_unused, size_t size __rte_unused)
-{
- return 0;
-}
-
-void
-rte_log_set_history(int enable)
-{
- if (enable)
- RTE_LOG(WARNING, EAL, "The log history is deprecated.\n");
-}
-
/* Change the stream that will be used by logging system */
int
rte_openlog_stream(FILE *f)
@@ -131,12 +118,6 @@ int rte_log_cur_msg_logtype(void)
return RTE_PER_LCORE(log_cur_msg).logtype;
}
-/* Dump log history to file */
-void
-rte_log_dump_history(FILE *out __rte_unused)
-{
-}
-
/*
* Generates a log message The message will be sent in the stream
* defined by the previous call to rte_openlog_stream().
diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
index b1add04..919563c 100644
--- a/lib/librte_eal/common/include/rte_log.h
+++ b/lib/librte_eal/common/include/rte_log.h
@@ -42,8 +42,6 @@
* This file provides a log API to RTE applications.
*/
-#include "rte_common.h" /* for __rte_deprecated macro */
-
#ifdef __cplusplus
extern "C" {
#endif
@@ -181,45 +179,6 @@ int rte_log_cur_msg_loglevel(void);
int rte_log_cur_msg_logtype(void);
/**
- * @deprecated
- * Enable or disable the history (enabled by default)
- *
- * @param enable
- * true to enable, or 0 to disable history.
- */
-__rte_deprecated
-void rte_log_set_history(int enable);
-
-/**
- * @deprecated
- * Dump the log history to a file
- *
- * @param f
- * A pointer to a file for output
- */
-__rte_deprecated
-void rte_log_dump_history(FILE *f);
-
-/**
- * @deprecated
- * Add a log message to the history.
- *
- * This function can be called from a user-defined log stream. It adds
- * the given message in the history that can be dumped using
- * rte_log_dump_history().
- *
- * @param buf
- * A data buffer containing the message to be saved in the history.
- * @param size
- * The length of the data buffer.
- * @return
- * - 0: Success.
- * - (-ENOBUFS) if there is no room to store the message.
- */
-__rte_deprecated
-int rte_log_add_in_history(const char *buf, size_t size);
-
-/**
* Generates a log message.
*
* The message will be sent in the stream defined by the previous call
--
2.7.0