From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 49557591E for ; Fri, 2 Dec 2016 16:08:47 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 02 Dec 2016 07:08:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,287,1477983600"; d="scan'208";a="1067118039" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga001.jf.intel.com with ESMTP; 02 Dec 2016 07:08:45 -0800 To: Andrew Rybchenko , dev@dpdk.org References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1480436367-20749-1-git-send-email-arybchenko@solarflare.com> <1480436367-20749-2-git-send-email-arybchenko@solarflare.com> <1e5503bf-8150-a4db-fd16-8c3e4c8e9737@intel.com> <27521ea0-8151-311f-1889-16fcb30d217a@solarflare.com> From: Ferruh Yigit Message-ID: <146ed7f3-0452-7a4b-aab8-893e039964c0@intel.com> Date: Fri, 2 Dec 2016 15:08:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <27521ea0-8151-311f-1889-16fcb30d217a@solarflare.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 01/55] net/sfc: libefx-based PMD stub sufficient to build and init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 15:08:47 -0000 On 12/2/2016 3:03 PM, Andrew Rybchenko wrote: > On 12/02/2016 05:54 PM, Ferruh Yigit wrote: >> On 11/29/2016 4:18 PM, Andrew Rybchenko wrote: >>> The PMD is put into the sfc/efx subdirectory to have a place for >> .. into sfc subdirectory .. >> >>> the second PMD and library shared by both. >> Since all will go into same (sfc) folder, should mention from this? This >> looks like justification of previous sfc/efx. > > I think it should go away now since we have no efx subdirectory. > It was necessary to explain unusual structure, but right now we have usual > structure. Should I send v3 or will you simply remove it before pushing? > No new version required just for this, I can fix while applying. Can you confirm following commit log: " Enable the PMD by default on supported configurations. Reviewed-by: Andy Moreton Signed-off-by: Andrew Rybchenko " Thanks, ferruh