From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 2B34D2A5E for ; Wed, 23 Mar 2016 11:43:08 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id p65so17989078wmp.0 for ; Wed, 23 Mar 2016 03:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=EwbRv0Wo0n6ux1a3y8agdi4x1NCsjtlkLV25yKbIeZE=; b=1A5i1y6CiNza2GLotMN+O8tuVCm44MXkYtpWVGLPPg5UuwXfdlxmz1e5JaS0cKECFU 4jGe1Iv6bBX6bBTFvqI/+mF4xdZlYXsh6SVN+yKjLrYN1LZKyJi3Rw/izt43I8Ifxt69 zQie5VX7IRTkVsR98iG5HhYcOGufXyPxMUrlNS6fnrPawHeqy71IG0OCw4jr9Yi0E86G 72ABX3EM3KpjwMMFZkc/vZsNLMWaA2Oa4t/LmordGBoVT4Ez5NrpTL/eRR4V64SFbTyn 5XPWSxw2n+gh1OKn1cYu3lpCFrDifS177j1YiaxqKBfDP/3Dyuwevpz6WRyUjrCKHBMZ vKVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=EwbRv0Wo0n6ux1a3y8agdi4x1NCsjtlkLV25yKbIeZE=; b=Nq+xOH/xjJ2xaGyKSbvGcuPzHPfeZWvXw+wWtmI5cxT5ZcZ4ne6+bmM+mW9I98UDgD q5j3u3ZeW0jjHqZhrcORoRJRM0tV8LQliwlSe7pz9Q4MavqnoELyTuCwhfbGHjNgmqfR kdXA2pNXkf5RhHbbo62qRu6G0HRJG4+byP8LgD1FzLf+qfyYFFXmy/Ow2wBO/Yar5Utk YNHUxqk0YERXPJf6oY/Qch3MMTkIeI9PJwbqrjd0xtQ2JzzkOPEkRZobZ1Z58JFy4CN1 e/XBHvSIhAON3DnTXbbmu8nfrWPiLPzqRkWdgJzuHg9KCxlRIzf+sFwrZfW5Qf0zOO1P Qlmg== X-Gm-Message-State: AD7BkJJXs6N8AvOvazCGwHOQODb5nz48AyFVlNtGrMum3LUIqk/GuJ+PXQqPXJo6nIlZG+B2 X-Received: by 10.194.242.202 with SMTP id ws10mr2581525wjc.3.1458729788032; Wed, 23 Mar 2016 03:43:08 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id m202sm2301076wma.7.2016.03.23.03.43.06 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Mar 2016 03:43:07 -0700 (PDT) From: Thomas Monjalon To: Wenzhuo Lu Cc: Aaron Conole , dev@dpdk.org, bruce.richardson@intel.com Date: Wed, 23 Mar 2016 11:41:26 +0100 Message-ID: <1470283.VAKgtTzWav@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5248499.WRMHcbhMjp@xps13> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <1458682638-28378-3-git-send-email-aconole@redhat.com> <5248499.WRMHcbhMjp@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 10:43:08 -0000 fixing Wenzhuo email address... 2016-03-23 11:38, Thomas Monjalon: > 2016-03-22 17:37, Aaron Conole: > > The register read/write mphy functions have misleading whitespace around > > the locked check. This cleanup merely preserves the existing functionality > > while improving the ready check. > > > > Fixes commit 38db3f7f50bd ("e1000: update base driver") > > > > Signed-off-by: Aaron Conole > > --- > > v2: > > * Changed from "whitespace-only" fix to a functional change > > moving the phy writes into protection of the `if (locked)` > > code > > * Added "Fixes" line. > > Wenzhuo, do you agree to fix the base driver here?