[dpdk-dev] [PATCH] mk:fix second compile error

[dpdk-dev] [PATCH] mk:fix second compile error

[xu,huilong]

when compile different targets on a same environment.
The second compile will failed, because test_resource obj file
can't auto clearn by makfile.

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 mk/rte.app.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index eb28e11..d23e8b9 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
 #
 .PHONY: clean
 clean: _postclean
-	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
+	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \
+	test_resource.res test_resource_c.o test_resource_c.res.o
 
 .PHONY: doclean
 doclean:
-- 
1.9.3

Re: [dpdk-dev] [PATCH] mk:fix second compile error

[Bruce Richardson]

On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote:
> when compile different targets on a same environment.
> The second compile will failed, because test_resource obj file
> can't auto clearn by makfile.
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  mk/rte.app.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index eb28e11..d23e8b9 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
>  #
>  .PHONY: clean
>  clean: _postclean
> -	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
> +	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \
> +	test_resource.res test_resource_c.o test_resource_c.res.o
>  
This fix looks very specific to the test application, and specific files in
that application. Can it be made more generic so that it will work if we add
other resource files to the test app without us having to modify the top-level
application makefile.

Regards,
/Bruce

Re: [dpdk-dev] [PATCH] mk:fix second compile error

[Xu, HuilongX]

Hi Thomas,
Could you give me some comments about this patch.
Thanks a lot
> -----Original Message-----
> From: Xu, HuilongX
> Sent: Tuesday, August 09, 2016 2:02 PM
> To: dev@dpdk.org
> Cc: Xu, HuilongX
> Subject: [dpdk-dev][PATCH] mk:fix second compile error
> 
> when compile different targets on a same environment.
> The second compile will failed, because test_resource obj file
> can't auto clearn by makfile.
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  mk/rte.app.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index eb28e11..d23e8b9 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
>  #
>  .PHONY: clean
>  clean: _postclean
> -	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
> +	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
> \
> +	test_resource.res test_resource_c.o test_resource_c.res.o
> 
>  .PHONY: doclean
>  doclean:
> --
> 1.9.3

Re: [dpdk-dev] [PATCH] mk:fix second compile error

[Xu, HuilongX]

Hi Brue,
Thanks a lot for your comments. I  will send V2 patch.

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, August 09, 2016 4:27 PM
> To: Xu, HuilongX
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mk:fix second compile error
> 
> On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote:
> > when compile different targets on a same environment.
> > The second compile will failed, because test_resource obj file
> > can't auto clearn by makfile.
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> >  mk/rte.app.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> > index eb28e11..d23e8b9 100644
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
> >  #
> >  .PHONY: clean
> >  clean: _postclean
> > -	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
> > +	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
> \
> > +	test_resource.res test_resource_c.o test_resource_c.res.o
> >
> This fix looks very specific to the test application, and specific files
> in
> that application. Can it be made more generic so that it will work if we
> add
> other resource files to the test app without us having to modify the
> top-level
> application makefile.
> 
> Regards,
> /Bruce

Re: [dpdk-dev] [PATCH] mk:fix second compile error

[Thomas Monjalon]

2016-08-09 14:01, xu, huilong:
> when compile different targets on a same environment.
> The second compile will failed, because test_resource obj file
> can't auto clearn by makfile.

I don't understand the error.
Please provide commands and output.