From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 6B5973772; Fri, 3 May 2019 14:31:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E892F220A5; Fri, 3 May 2019 08:31:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 03 May 2019 08:31:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Ot/X3GFPiQd4mIYvF6So9+jsRhgAxW2sYyJ1j82QvhU=; b=WnaDZkxbHrH4 7hqyiHqNijv38p5u2T3rzx9KsXef6WC1SnwiYaeXwDr45lTNFiTW2TGfPdfGgDTa 6ujVY9LR8PtWE3svksmPDdgrZi2eMMNqzYLXC39qiygGkG6EIMWj7D2BJyHhh7fD wh55LmZEiAOcFnTwbwccHXFxbcUkgdw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Ot/X3GFPiQd4mIYvF6So9+jsRhgAxW2sYyJ1j82Qv hU=; b=R718mtw6GEjNZoCkGOwLIwTwgPmMh8ffOflzf8nLOzy1bxDb/F4YkLQLt xmlC9ik9N0+dJo7NCvVh7Q2R9xyGCsuQg0Eg9iEK9iy09GI8FenaWzj53ZLjI7O0 X8eI4GhRamE+nQliY8MKOjRWAbOMYkq/WbDdSpTpobytXjeVHl0Ba6R6DLwONlNT 7JF/kitvFPNr9DUoaFjK0oqDslmIUkjaQsznZULFHlQ81RNoHkUMEVLhnJehgctg DGG6DvA2CW1nvvIsM+VJXWhiEMz4hTVVWyogpVcWu/KDYtTi3Z/xueobRxARdNv6 Sm9FyiL2BpmcQlo77QHFclM3LIiEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 86E27E4625; Fri, 3 May 2019 08:31:15 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, keith.wiles@intel.com, herakliusz.lipiec@intel.com, ferruh.yigit@intel.com, stable@dpdk.org Date: Fri, 03 May 2019 14:31:13 +0200 Message-ID: <14711978.vJqNMZ2rNe@xps> In-Reply-To: <33816b0f26de3b8328ae49fb6c73ca200acd945b.1556547761.git.anatoly.burakov@intel.com> References: <33816b0f26de3b8328ae49fb6c73ca200acd945b.1556547761.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ipc: harden message receive function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 12:31:17 -0000 29/04/2019 16:22, Anatoly Burakov: > Currently, IPC does not check received messages for invalid data > and passes them to user code unchanged. This may result in buffer > overruns on reading message data. Fix this by checking the message > length and fd number on receive, and discard any messages that > are not valid. > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1570CA0AC5 for ; Fri, 3 May 2019 14:31:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 555F137A2; Fri, 3 May 2019 14:31:19 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 6B5973772; Fri, 3 May 2019 14:31:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E892F220A5; Fri, 3 May 2019 08:31:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 03 May 2019 08:31:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Ot/X3GFPiQd4mIYvF6So9+jsRhgAxW2sYyJ1j82QvhU=; b=WnaDZkxbHrH4 7hqyiHqNijv38p5u2T3rzx9KsXef6WC1SnwiYaeXwDr45lTNFiTW2TGfPdfGgDTa 6ujVY9LR8PtWE3svksmPDdgrZi2eMMNqzYLXC39qiygGkG6EIMWj7D2BJyHhh7fD wh55LmZEiAOcFnTwbwccHXFxbcUkgdw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Ot/X3GFPiQd4mIYvF6So9+jsRhgAxW2sYyJ1j82Qv hU=; b=R718mtw6GEjNZoCkGOwLIwTwgPmMh8ffOflzf8nLOzy1bxDb/F4YkLQLt xmlC9ik9N0+dJo7NCvVh7Q2R9xyGCsuQg0Eg9iEK9iy09GI8FenaWzj53ZLjI7O0 X8eI4GhRamE+nQliY8MKOjRWAbOMYkq/WbDdSpTpobytXjeVHl0Ba6R6DLwONlNT 7JF/kitvFPNr9DUoaFjK0oqDslmIUkjaQsznZULFHlQ81RNoHkUMEVLhnJehgctg DGG6DvA2CW1nvvIsM+VJXWhiEMz4hTVVWyogpVcWu/KDYtTi3Z/xueobRxARdNv6 Sm9FyiL2BpmcQlo77QHFclM3LIiEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 86E27E4625; Fri, 3 May 2019 08:31:15 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, keith.wiles@intel.com, herakliusz.lipiec@intel.com, ferruh.yigit@intel.com, stable@dpdk.org Date: Fri, 03 May 2019 14:31:13 +0200 Message-ID: <14711978.vJqNMZ2rNe@xps> In-Reply-To: <33816b0f26de3b8328ae49fb6c73ca200acd945b.1556547761.git.anatoly.burakov@intel.com> References: <33816b0f26de3b8328ae49fb6c73ca200acd945b.1556547761.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ipc: harden message receive function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503123113.ol7MuV9bKI4YUXKSvMq5mEHdVWAbwNnQCtKMR0Kr2zI@z> 29/04/2019 16:22, Anatoly Burakov: > Currently, IPC does not check received messages for invalid data > and passes them to user code unchanged. This may result in buffer > overruns on reading message data. Fix this by checking the message > length and fd number on receive, and discard any messages that > are not valid. > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks