From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0072.outbound.protection.outlook.com [104.47.38.72]) by dpdk.org (Postfix) with ESMTP id 31D0A6CD4 for ; Fri, 16 Sep 2016 06:32:55 +0200 (CEST) Received: from BLUPR0301CA0003.namprd03.prod.outlook.com (10.162.113.141) by CY1PR0301MB2012.namprd03.prod.outlook.com (10.164.2.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.619.10; Fri, 16 Sep 2016 04:32:54 +0000 Received: from BN1AFFO11FD011.protection.gbl (2a01:111:f400:7c10::130) by BLUPR0301CA0003.outlook.office365.com (2a01:111:e400:5259::13) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.629.8 via Frontend Transport; Fri, 16 Sep 2016 04:32:54 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD011.mail.protection.outlook.com (10.58.52.71) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.619.6 via Frontend Transport; Fri, 16 Sep 2016 04:32:53 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u8G4Trfx029256; Thu, 15 Sep 2016 21:32:50 -0700 From: Shreyansh Jain To: CC: , David Marchand , , Thomas Monjalon , Shreyansh Jain Date: Fri, 16 Sep 2016 09:59:52 +0530 Message-ID: <1474000200-16705-18-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1474000200-16705-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474000200-16705-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131184739739944684; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(8676002)(76176999)(586003)(2351001)(48376002)(104016004)(92566002)(11100500001)(50986999)(5003940100001)(50466002)(81156014)(47776003)(4326007)(105606002)(106466001)(33646002)(19580395003)(50226002)(5660300001)(81166006)(86362001)(626004)(36756003)(229853001)(575784001)(19580405001)(2950100001)(2906002)(8666005)(85426001)(8936002)(68736007)(305945005)(189998001)(97736004)(110136003)(87936001)(7846002)(356003)(77096005)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB2012; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD011; 1:O5cqkKP6TFBwdPbMwPVbh8ZQaMzaBG+CLV6NPlRVdQvVot1p1DjocZTPf/5RJDgk6Rx7JEPRYaKD4IozX2bMc45wwQFneEGkuQL/oUfwC0L4k3fzv0oFa5WClA8Lhlol/YkHiOP3nm5UYNJ0gtffORAamj84Xr6SQADSf1Lpe4pl9T2nrcD0HQRubJDX40LenK55W0Ls36GFQn7IEf44lmWRxYhZPE6nVARZ8HbWrgjJOHALJPGDSsCNpKH7GWF/xSPHswQURErOqIOX1GH4QhMp6sHQ56mpYfxL1ui+0M9vyksrBWEHnUr78SYPqmvS0aAKqPuaECpH7mlMAAGo/wxv9qRfWv1MoSPhjLfFDqxikzERG5O7RXUaz25YiL0V5L4rSe8PYJyz7RynEkqjRfr6OCM6inJ/xi6RmwwIh9tKSjegHga7Sh7uJLBIXMwQLcfCXpmiMqTlpBWbuaqQ7/O+0LK5yeP/+A1pBHWz4eQWVql+8oO0Q18ejfoAfglKnZqIGVpoXzJTWcpqE/Q2aKN/g2DBuq9Go+P8EQizctAI47Z2muj77VC4ARhYzEZREkS2is4NmgJRqCs6xshXPaN7XIytRGR9pLlpEDWS4JSo9tgVWDNgQnw3FHFjkPmpuo1BaDOsNh+aVkFCsERApdER5pfZtDJ3wYayZKyJOEbMHA5aUkQAGukz2no3jhcvgeQodtqsZzo7fIyI60HARc2IJtLRGwkfPhIdSAbcrEs= MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: dd03108e-d334-4cc7-bbf4-08d3ddea868a X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 2:CLtqSsbk86WTkABZIPIZ+79YnBVTEeB9zgFNSi5Uvuhzkn+U9tVIUe7kWeNaMJAJkr5dT78qsj2rcaY5+x9DDy+1YGA7D6BxKR2x7CoWQENgaCgYAqTF8nibO8tdhaBL6CluS3wEAvWGlT8Sf5BSrtY/iBNb1/W1Izd6q+6pkn6OqFh03HbrUddh9Il8ewRG; 3:qaO51s/FkjZ7/AGRJiVaQAhQapUe8hp6q0Hdyly96vNwODc0NJkOWwXEiusRK63d1X2PSDxQyZFIKmQvbILbX8vke2/5RmVSVV7D9X6dqCu5mNCPsPC5DcSrx7BYeo7u2jIX/nzZpS41h6GXOJ9Zd12P8Uk2NmXdgVcpfGYdAJSiM7lw1CR+uh6pVFoxuB/P6ANY7aFa6eQ+g95o8ZQL19POxQHMIUtYj8pLr7U2rvA=; 25:mQMbl0bfnYC0Llu1Jq7ETnHtY/PXzY0Q+YWQlvuIQq9chq06/6G5OAIVG8xozcYla0IVs+1RdoAo/UCtHzNPCe0iFnVzpapJ7UiS+lwDABLfSqdWnRTTS3fjodljbR0W7MDQRbVwPh1KTL34Ty+5buhUjSlEWWoevYaPw0ngLqH/uy9avL8psgpEYpS+AshveX4Wdr9Z3eMIkb2+/t7hwhbTdzm0wCc+QsqHzWE6g5z2eCU2fqI4fwX8Jcztf+3dLxW9aoiUcQmaW4Vfkox0fIOKis0ONTj8y9rVhdF2N6hrlND1N/83+DdtNecjpoqwtzYTxtAlnQ28V1rOYoINhplhW97c46SZnByRhyP3XEjmAJTvnw92txQjyPLnUyZ61Qw/cTUIJXJ4XY5xHOB89i/DDQPkP/zkbGPb6LObfWQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2012; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 31:aepFqkWPcU2hLVLz39Hjul2kBRBGci7X27I1suNH4NjF2GrcSZUcvfLeHpHJUCFZo01ilplqPBDMHTJluS8VpWTcga7Xc3no63b6A7ex0GrZj81FNg8pIoxlO/bNjp5ZVs2G1lOLaenARocJm1fXt7Y/ODCAEttLSfl/HiLv6ks97U5iANxPNpVb3GU/JzwOc4fNySzArPUWFmxGkDO/alr25fP2lWWNt6A9yaOyfvo=; 4:8BPgpAI1jcCtx91uP8TTI+aP3z7IjYUWE27obK5t9G8N/xiEUtgv1TdmzsoUaYe31ueC56IhR5G6+KMtRe9sAgsjE+S14BgaTOLRBhNJs1bzYlHpZIKG6D7G+nG/l2pVt2Uxf9fEeHCWLoE8PbwKmbzw9S0ieVUYn5Ykv2G2dUIsXx2P1EQNf1gB4YdKsgD9A4KRMZxv043RC2SYpCemBqRuS5xmRdFNOs83OExh5Grhhm0Dj5ng0LOYVAWzEVRfQDQ8X7V2YB2y9Psn0p3GvzKifJV7sAAGTxuTGQkqj6XOhllQEilrFVo/s0/dm7pAmMZGnwRPsn8qYaFZwIu5D+iwwD8YL1nArU9BCtR3IYbgDdMgHHVoO4MXvT7ENLCeaoRJQrJoi7LUUhcQLQXgFXE8MM/dyqvYfGMXCDZTlXJ68p0hrtwiyf2krqAURdSolNWiT/hMgEwRzfVcu8EOzUyHf/qXecjdN5KlUG+6iiGLUBJ1dYy8UYVoDRIKAYbd12pVWLawnvR4BfNqB0zZ7X16h8+Nc2r/E+5rBRHyPWs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13017025)(5005006)(8121501046)(13015025)(13024025)(13023025)(13018025)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB2012; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB2012; X-Forefront-PRVS: 0067A8BA2A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB2012; 23:tv9NWHDfTIfS+kbC9vKP+EmDqCIkFhhq0OCLok5?= =?us-ascii?Q?GxZJ3YSUHtbu/qF7+yrFfcL9KD0kIn+h7mgSgdHB9vRGofHlAh4b3S5WrCzZ?= =?us-ascii?Q?pMbWnUlX5WzPXZEizqVqYPBP4BsQFR9j4BYPMoZlr/H9i18NQiD/UhfM+CC5?= =?us-ascii?Q?pqLJmFhmqNsKWTQlvcFnyWPTiRTbiPYSxQx5zV/gHNtAiFWHCwLMhXb71v97?= =?us-ascii?Q?FeYSOz2N8VKgsJpPJHgP1qsqzgWSEUIaxvF3kHt3kbkDAK0kCxfhy2akOd3W?= =?us-ascii?Q?ttnh3YU7VJOyCMQdbXxvjwK5DOW+csZAW3LKbBIBscIN6SBmey9Uzk/1aMOp?= =?us-ascii?Q?pLRiRKx1IMTkhqSLRQgyFqY6ELSxUTEuwO9bL/bvolaLJIbbr5PNbkOzS/N4?= =?us-ascii?Q?LNSMTxCsLpo/9xTZrfloVSGrWWBhCmjCE1lyNWSlevazkHH5SWkLYQAtH2I3?= =?us-ascii?Q?XK5nKODfuZTKKCnWW/e/YoVYxWF397jMCXHAUr8XC38cazS1mu1Gp3B/uKsC?= =?us-ascii?Q?ScHmHUVpz9L+r7/+EiehKMkQeVaZjRLnXYrb2u/bIYlOllM2Z72XVgdRZ4W4?= =?us-ascii?Q?35BiaAkN8yi8oCFpAmccW0N8YzWpZxlLJmcccQxiHHU9EyeO6L6uCeLfMziK?= =?us-ascii?Q?IVLHxc+Rh/gCxeD02cFi9hdbPhDhvqCKHrDLM6psrL3w1B3H8/KQZvuyb5OK?= =?us-ascii?Q?O6xsTQYPSnYcRoEH6o/ItLyfM2NXI/9zARqnTFl8CIlL3gi/eE9FkA3sZPnE?= =?us-ascii?Q?He5TGpXfVLWN2t6WO2x4ATRzfVMS7XJZU50HR6fBVSBfQrU6KVBoFz6a5hNy?= =?us-ascii?Q?AWe//ZQ+ZQlkeu4xE72dc5NjaSoRefBIJc18yYqIJwLvkSfFEttQRJ1uuyYS?= =?us-ascii?Q?icGhXeEKxAQGbfmfD7SHezLEziUk8rz+KZxv+2aFBjjRN7exclgzZjqZNsAE?= =?us-ascii?Q?JRCF+gQtXLK5oS34gsk/nK4d2JPK6rSoEi7M9Yt5KJfoHG7eocGaIeh/ikuC?= =?us-ascii?Q?FhpVffthPMMwJpPfH8Jrdlo4D+shg86mrsBtDHuUmcua0MWKR5mqhZRIuIcR?= =?us-ascii?Q?rL1ovIpFS6WIG7EhZNFVi7b6hEsm2Mkai0E4mN8Asd/oB6x+UnVz53s6Y6uO?= =?us-ascii?Q?pkjnr/KCLgCxzp33Hk/l9fWfXjZgDwT8eWv5m28T9TUcwGGrxaQT1FOagaw1?= =?us-ascii?Q?dcphpPbgTvhthOcnuEhwiG5MRpMsMujjH+4E/?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 6:DYqn8qZCqNAYVHrbuMWyg+sxBSHmvglSwFLXwg1PtDqtfK1R91f7SXjkR7x0icVp32aUEeSv7G36oM67ykLT4CuPuV5aMXM0uXrA/aegj2QFr8dz46mNdvDeFNPRkYvRpc2CDprCckfBgyfAXoxMX5Uqt6eEdLtwK5r0A2dzbky1un8yOWf7t1qLe8nD7Pn/y9mXCH422JDTx021J5PInbyo+RTpoLt0EBTAi/rOOd3RNL/h0qQmQjx6YrjHz8a4Qf5C59D6pfYCivS1GlX+lcpX3rQ+N9X1tRE2xYjz0To=; 5:7odqtf5ilrH9ivhGceHHLFJBqLNLUeKbhiEZKBD304tmm/anK8Csm2CxEKD6ER4AlMl9w4BG+mbNdalbwyiIBARb3Pj5IS7nlF1V4DNHpWLhIr4YOKaUu4KunH1C52BrRtOSYtH6npVHrzzl12GHiBa+SEsfQGFY0fHuDRe8jCs=; 24:P4EL1/G4MfE7LpnO4ZQ3iYQ6rYLtShYKONjGfRVe9J4E9up34tU8ZbBBSQt76mPhOyoxZJkTAgkE6DBvvk/jhSiDKa81VBkKZCgt78/BjXs=; 7:0Jzi5S1eVdyIvOH59KvfJVEr3MfkNzc7vXBbeyWLe4k2Qavbw8tLvTVEOHM8c05ihfC6MOsYD5Ii7cZ+9qJ8/B+b016BCaTu30NYDGeegvDEcsgqDFf/jJCze0zvrWwIRpEs299C/0Z4T4ngeJtWYUASAbU7NTQYDK1nq2Vbax6rGtb7D2OciK7WK4fU3rBZf6APiybW3hPz8zaNtsuaw4cae99Kde+k71aDrbvbr2Q8BWzLBTIOHVk+kpNp3Wvq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2016 04:32:53.6980 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2012 Subject: [dpdk-dev] [PATCH v10 17/25] eal: remove PDEV/VDEV unused code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 04:32:56 -0000 From: Jan Viktorin - Remove checks for VDEV from rte_eal_vdev_(init/uninint) as all devices are inherently virtual here. - PDEVs perform PCI specific inits - rte_eal_dev_init() need not call rte_driver->init(); Signed-off-by: Jan Viktorin [Shreyansh: Reword commit log] Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_dev.c | 8 -------- lib/librte_eal/common/eal_common_vdev.c | 6 ------ 2 files changed, 14 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 555e0d9..afa33fa 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -67,7 +67,6 @@ int rte_eal_dev_init(void) { struct rte_devargs *devargs; - struct rte_driver *driver; /* * Note that the dev_driver_list is populated here @@ -89,13 +88,6 @@ rte_eal_dev_init(void) } } - /* Once the vdevs are initalized, start calling all the pdev drivers */ - TAILQ_FOREACH(driver, &dev_driver_list, next) { - if (driver->type != PMD_PDEV) - continue; - /* PDEV drivers don't get passed any parameters */ - driver->init(NULL, NULL); - } return 0; } diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 462517f..67cb397 100644 --- a/lib/librte_eal/common/eal_common_vdev.c +++ b/lib/librte_eal/common/eal_common_vdev.c @@ -66,9 +66,6 @@ rte_eal_vdev_init(const char *name, const char *args) return -EINVAL; TAILQ_FOREACH(driver, &vdev_driver_list, next) { - if (driver->driver.type != PMD_VDEV) - continue; - /* * search a driver prefix in virtual device name. * For example, if the driver is pcap PMD, driver->name @@ -93,9 +90,6 @@ rte_eal_vdev_uninit(const char *name) return -EINVAL; TAILQ_FOREACH(driver, &vdev_driver_list, next) { - if (driver->driver.type != PMD_VDEV) - continue; - /* * search a driver prefix in virtual device name. * For example, if the driver is pcap PMD, driver->name -- 2.7.4