From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id EDC23590E for ; Tue, 20 Sep 2016 12:39:39 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id l132so201063302wmf.0 for ; Tue, 20 Sep 2016 03:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightcyber-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=2b3a/XJN95fXXF3BeUs4FrsCzf7BaGvRq3bLowsW4Xk=; b=zfWbnwpmF3+7yDyou2RonaKc+3+jNtA1Yumkv1SjwQ3/oxaz6m47vLiIhFenjxwPYS C2a1CEwILx+xPKGP95yHfYD59bIoOWab0iSKkwhW192+0V66qDARRA2QB+os9HkJkr5y W23FdWknEieCFEFsKbMw64IejNkJ5V/1t1j0h3JBSXglJEZkBAdizXGXYHii+ea4yzrH YPZo8h5bn/O08YY0F6228i72R1rgyCyyLIHHPkajZzJt3WlN3tEIUouzLn4KCOxvXYeB iDUpnIZxt04QzJwjF1DhsuiKTXacLljuXTHSOLgbTbatt2/2aRU421oRSw9oS/zBRj89 gYqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2b3a/XJN95fXXF3BeUs4FrsCzf7BaGvRq3bLowsW4Xk=; b=PsVjap5AIjDLWW8L4HVRa1t/3PKxzEIM5QGveLjKT4M5IS8G3GimLAPxAStfpaTG1z zK+LQIpZ2sqZuGxHKDAotEX2QK92mI2XumxWfAnBqb5H2irUqkCht11D8IeeXqp2yb+J JvHbfc+3A74Bv0AfLaWOliW6DcOdoYf5OTB5n/S4y45aMSzI7eIwtFYbYoHEtMQSk3aO opdcDsF1285ieL5bNUmDCibtV97DcSnsTEvWS19JkPnUWGzRhLSznLgC/wCaFKUFH8Su lUNNjbWhlw7yMjQqGckzfaAHaPYLVAPl1N0tTtEvzD48PzTA3UPuvdv8MHDUmjkYUA1O mDZw== X-Gm-Message-State: AE9vXwPsw7Gjd7hGIXZFWPCDr+PCaA3jnMeL4TUqkHKk7BXjZFg9TEyTbeSktLbU6E3/bA== X-Received: by 10.194.175.106 with SMTP id bz10mr28308582wjc.42.1474367979771; Tue, 20 Sep 2016 03:39:39 -0700 (PDT) Received: from localhost.localdomain (bzq-156-168-31-238.red.bezeqint.net. [31.168.156.238]) by smtp.gmail.com with ESMTPSA id v189sm26688570wmv.12.2016.09.20.03.39.37 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 20 Sep 2016 03:39:39 -0700 (PDT) From: Dror Birkman To: nicolas.pernas.maradei@emutex.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, Dror Birkman Date: Tue, 20 Sep 2016 13:39:23 +0300 Message-Id: <1474367963-83879-1-git-send-email-dror.birkman@lightcyber.com> X-Mailer: git-send-email 2.6.3 Subject: [dpdk-dev] [PATCH] pcap: fix memory leak in jumbo frames X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 10:39:40 -0000 If rte_pktmbuf_alloc() fails on any segment that is not the initial segment, previously allocated mbufs are not freed. Signed-off-by: Dror Birkman --- drivers/net/pcap/rte_eth_pcap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index b7a3b03..db19a66 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -229,8 +229,10 @@ eth_pcap_rx(void *queue, if (unlikely(eth_pcap_rx_jumbo(pcap_q->mb_pool, mbuf, packet, - header.caplen) == -1)) + header.caplen) == -1)) { + rte_pktmbuf_free(mbuf); break; + } } mbuf->pkt_len = (uint16_t)header.caplen; -- 2.3.0