From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0086.outbound.protection.outlook.com [104.47.40.86]) by dpdk.org (Postfix) with ESMTP id A0DBE8D8C for ; Tue, 20 Sep 2016 14:42:33 +0200 (CEST) Received: from BN6PR03CA0046.namprd03.prod.outlook.com (10.175.124.32) by DM5PR03MB2442.namprd03.prod.outlook.com (10.168.233.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8; Tue, 20 Sep 2016 12:42:32 +0000 Received: from BL2FFO11FD058.protection.gbl (2a01:111:f400:7c09::124) by BN6PR03CA0046.outlook.office365.com (2603:10b6:404:10c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5 via Frontend Transport; Tue, 20 Sep 2016 12:42:31 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD058.mail.protection.outlook.com (10.173.161.126) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Tue, 20 Sep 2016 12:42:31 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u8KCexsb006559; Tue, 20 Sep 2016 05:42:28 -0700 From: Shreyansh Jain To: CC: , David Marchand , , Thomas Monjalon , Shreyansh Jain Date: Tue, 20 Sep 2016 18:11:21 +0530 Message-ID: <1474375296-26078-10-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131188489518976206; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(48376002)(68736007)(4326007)(2906002)(97736004)(8936002)(76176999)(626004)(81166006)(575784001)(86362001)(5660300001)(50466002)(104016004)(586003)(7846002)(50226002)(2950100001)(5003940100001)(229853001)(77096005)(189998001)(47776003)(356003)(110136003)(19580405001)(305945005)(19580395003)(92566002)(50986999)(8666005)(2351001)(81156014)(85426001)(87936001)(33646002)(105606002)(8676002)(11100500001)(36756003)(106466001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2442; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD058; 1:D/6xSCvtG3IxBdZOg8vYQANEdCREEJqvICfNn1wRvXjs0r2x1tzM0YOpQ/6V+krQxgIweXfU8bLoYDyXRAQv2AVMAazIDh2UnW5+buwcS1fk6t0XRtP7HgfME3DMKtdicVwvsyzDTdyoC2/P/2pJMNEES5+OxTFKCyytBodYEAvDnBOMI61IxhQjzLRltW3LVWtQ0IDF+iIsIIakzcF44vWmAcH3lhIi2L39ynL7HK1pob17eHzi23NmOOVDhVD9RrZVBowcvuvuic4kDrEGPq4Ziang69JYtoyYLfeZt8SkJDbgnyx4Bov2nt977aP8Kt74ksuL6b3YgibcqJ8ErA/m6+oKmzSZUxIqw8ibSHoCwLDvygpxbClppu8rHSDnVgyO5f1hovW8VCU2K84xWLAYrOeLNz1O5Q6s2OkYMYJhFonX0nkRn8CinQHTAWmB7dyuYFHLbV+PuE0WIO1Uxbr6BNlV0VODYfTeDP4+RAOCRh5Kw8apQ8WzKHKf/2afTx0BrIy84B0NlfO8WyZrhZxhOwufl6LneO40jxamDAsoSwuxrrBW8RoNGb27geM+c/D/8LNJUvo2RfJDW94RTxTqP+fC3D5umPftBjydBn9DdQjoYVvGjXoSQcI5tyT0+F9yrzEeAz6hxS3DpqZJ98YrAHJM+5rdRJrK+i+gXL977fHiolf70GgoYN9kf7aFXfSmiHO2wnHJlzsK5sMWAxokqRqIghEL01UNmMFrPTs= MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 78ab1412-95bf-4466-ab6d-08d3e15396da X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2442; 2:VnO3U1yGoGXLhzAh1yz0QlSkdJ1FhfBrLrMb7iE3LKZOOx7j9f3bF7Q1E5XOtcQQU4y1lrYf3eVo7wliNawncl/SgHtj/eRo3nb2UrdypShBb/w2R+xZXKcrOD4wNjPe++I+LV/Wz3c0vicPboKIfBWy/GxOG2NlP2cmWxBhCa1WvCO3OAkCgtsvAFP9QFIw; 3:10mv2v4XGV4ROriIjOWYp1OiwJmC7L0hE6vArrZyr2+vQitxVNbblNEj6iLFSwT1b391Elazm3Cx3k9bl+5JbmIHEldWJTf7CsvcuNyfNNBvio+uA7+7ioXN3WGqPXZSJW9N/rfOgYV6/XPOyYTkmWdamVa0Ts/edp7H/A+EZDyUQl2oBoDD7tcdQmDvevamnd/CZ17Q5bexpbMreDyzcUspkF2uYw9uZtwMI1uYlls=; 25:R0WWqcC/GTcGqkBwBwNXlh/pQvaFeXG8L79RcFT0NZafVepmhvNuIRpCi8UAdMBlYq6Kt8ek38OZQOwlmaLe516Jt/eBiqJMxmh+OG9ph92TK2wZpe4aFHc0L1QwYAYtlIVa/W1UjGFbRskAvGpU63oJM+7vCYsagT20+8DeD0523JNLq0JnKTztkFZhcABKOisDRB/tZun0odcsiSYAAq5z1ISau4+a3MHObQdA4aJithaOtGqSFItjPUxwz5jSZloM4BgvJZ5GKnW5FPzw1217HQdQ73uJ+FlHJc/Edv8CsDrAeY+raeM5ypu0LsC0cWrMh51I//GanIlLmR0fjWifQgvbnA5LRXgjJQOdymvGxyymfbdNhzUUtleF0/hkNiFMRKM7t9ND1etAB/jrNU+vL9qURC42dIstAcz01ys= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR03MB2442; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2442; 31:pTS38tbA1MxcMOE/GQA2z1vmfZc8Bav4RCD2QFjLzJOar7gqf1qzgZ8px/+I0+z6YCw6zW2hYVvD4GRCslV4buPFmgVqHEbLckQZaX/0ROXlUSi4bew93o0tPZ+Hsx0JENkM+VbBYfgynluVrdEtR5N9aWmuoBMbST8pI/a5hSlis0RZQDuEl8EzVwA0PPOOtE8mpy9sydbJjoxNz2GcUmoP8gYxVk3AYKZH8nM0W1g=; 4:SeQkEyq+lQpTsiZwC4RZ8LhfY8Ft+Iku8hg4DwSIPwXcTd8TkO17wnQCRWLjlssbSLetQEwED1qH3HZZXIKvRj3qFhfsl8xNLIfKrHKwfexouvvsKFCiX3ciMP2EsR6hqn5jEt53v2e2OFJBDvEjcwYjpBsH3hXC5pJ3unfkLvKEAbBKeduWymLw4YErZmLahxn0TfMCK2kA2SVIsqd1O6K4vD1LOteFBopC7Slof+Erz3WRMS7F9yo4LeXftRXiNrFnXRfmFErJizi2DFNFbkEXNGJgZXiiyPXyxXje46SXQ2AEbg9V0QgUPJS5eBJZ7gW4V/dOmyicG2HVp4VmQv4KSNG48apz73ktYBNs8stnL+4Adk1ed7y7yzLozO5j7gGQAX53hHWMtZVSScTxSzOFI/tUeGOta097s+WxkR2UkChRd9CmFcb+tXSzUl+hySsb/GkppdP3vf0qGs91PT4LNxbSjvhLnjdATCZnYd8vCu1JmtEMxuuwcjr2J7ho12CoGC5CxsWAr816fuTuFWdaLYO+wga8T3X69SJEWSE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13023025)(13017025)(13024025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:DM5PR03MB2442; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2442; X-Forefront-PRVS: 0071BFA85B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR03MB2442; 23:ZwBigwCILFzs3OGB5TTO05NuqbKImY3QpnO0ZCpBa?= =?us-ascii?Q?1NVJNOJWWUIK3xsJrlhgJvRIiBc1BrcpWUtDpXihQsqhHiVtzk7IRxjB46R5?= =?us-ascii?Q?cFSjHoSf+dh/NZ92EQlwwI6Vie6vJ5xZ2/483jW/qW1C6RH/A6O1RH4z0zot?= =?us-ascii?Q?filD9zu3jj0869nHoaH/bw/TqCFttEe5c0M4RVn9am1yXYzNeqUscNeKySS9?= =?us-ascii?Q?llevJ5doVteJ4ZbUR60l63ppk7ddj+CYkbAnVQbLiiutC5Tnw9McdqII1+L6?= =?us-ascii?Q?drZJ5RCPLYv0auFlUfIJTZjtYf/tjGU81odfbOi4gliScWr8K3qPoXM1/w68?= =?us-ascii?Q?eYzvAqpGVF+a2UJIf0yaT8bqqxJ/kOadmKrqyVGi8yDdsI8sjMNwH0mEx91R?= =?us-ascii?Q?2WKGkAxFD1ZYHaEFJu9mIYW6DQ3V25q/0RI6oE25D3BjsOGYGcuYlj3YbHkK?= =?us-ascii?Q?oqG+Nk2mwbGMSavjtbdQNVSzAw2O6EV59LDRDgS15TQqC9dUwjI0Fhb3wEOF?= =?us-ascii?Q?earFpg3BjNjOtxpzjzfFFPstnuQmvAjPcCUxW2e2+SH5unyt2ZkQG3SPapLw?= =?us-ascii?Q?+1lTEr51xnXB2gGWVQ6G86JtIQ7NqB/2NbN8MlP+L7+zcTihGcdfHdRrIS1I?= =?us-ascii?Q?jAtnXmc6t6qijBdGv+aDZJJ4fsxCJB9HGqkTVajBSX7ZJ/2C4Hsh0zjRCYpu?= =?us-ascii?Q?cHD7n5zujY4zToeaAqMdiKO7Y+krCeMdmpiDtIfb0Mq8QtLEwgKVqXPWjUBr?= =?us-ascii?Q?L11MUrdl+4A8s8ckEtDtEumvNL51p4/BxT0rNAxxorOJ6Euwqu+jyZUOEDPX?= =?us-ascii?Q?somnEukR7j6eEROdTZ1c66VSnFsmIVQIHg+KJxRAiOkebK5N9wSKLHMkTMMZ?= =?us-ascii?Q?jSsz+v+WMRsnIE9YGgFAZRPSeqqILXLwslLeO4UPMTFfSfa/c0hTmFjYJv+V?= =?us-ascii?Q?9ouK57U5zfdgSqL2Ji9a3/U7+vLNTPgMqdViO2Yq+1epvoiGwcUXT3lyxN0t?= =?us-ascii?Q?SoufT9VAie039Sh3LQsSOT4MSjFmZJhRXY7uGgnYA32VCL+Ifg/t//kFhCjC?= =?us-ascii?Q?6e9YNbifZmYsbEplvfzPUBMV9Q6B4SWD0ybzvXV3M8QK+OmdimjP32cWRMAq?= =?us-ascii?Q?5ALFSlU+TBcLZZOgTidQHqKvJ3ovSV09v3zApYPfYg6vJudSOHzMtRMm5FnJ?= =?us-ascii?Q?TE2wkjGj65r6jE3/U+d3MsAnQKyd2MTjrq7?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2442; 6:16A8cIA00s3ucu1nKOodRHYKs4C8PT10korCrYOMKXG/gYYmskv4tTkS1XDSHxCgUEqj6thfjrOZORPvwIMtNdxpaQebB6qp0Z7sNjKYMlRb8ljI4VTbDID4IL55pAh3iY/evWm93nIF1U+nQYarw0O+pJovz5E5Z1lxe5a1jGm4xU+lsk0uOAWvomFXlAt2cc75tNVd2IttYs7LWVLj1EqGLLDbFF5NXTKJbHq7LCIEyDL+QBJu2pj9t/0E7c8StpP7W2j+N3mwtF9d9l+K1mgtYBD4dykJ72wVUgX0FCA=; 5:b0z+Dz/74diG7s9McSSaFbGLtDEg9vYklI7iAylEmY2gY5F+CoXIBinBNl5LIr96PyS+KLC1oXooYX9UFMsd5BE4z9OxaAOfVUBRorPlbT69LFqJ9Vdt16ajnIJ94+VV80PCmNZS4KluxcScRRkhyuQFNlmfDkzndsH+BQHn8IE=; 24:Y+iiHOnOhIi4Cy1lh6xdSeU5SyMX9c0KyPOYu2F9J3vPJ90rNxhBRRvg3nEcklY8DPZzI7QHb++t0ZpZtf4ZQcl5AxjS9WMFTZmbBGvAmsU=; 7:jqNpV2MXlZnP/My7Eg0k2WdME7zvvIifySszjXAjCeUg6W51K8FBzUzbY6G/eVP67dY4AulIxPOCqqSaSg0+r9PLHt3QDRk4b1ZYI9wSg/xPI4O5JFXVqoWlMOndekYHxzgYQp0hanKxRRquRVfGhZqK8U5VImYW4lOrHlccBpfTg0kY+c3PgesuPfq2JrjpLvGYp80U4N/FX9xDJrv8xkVRrGRbeI88BW2ytVF2M8X8g45CecFJ+vtk927KDEha1Z3os+7LEEXo6cmSVexlwe7cpuDI843Dc4kwYqY6kIldj5mLFhkfR9p85MqdxIFu SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2016 12:42:31.7104 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2442 Subject: [dpdk-dev] [PATCH v11 09/24] drivers: remove driver register callbacks for crypto/net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 12:42:34 -0000 From: David Marchand Now that all pdev are pci drivers, we don't need to register crypto and ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 23 -------------------- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 -------------------------- lib/librte_cryptodev/rte_cryptodev_version.map | 1 - lib/librte_ether/rte_ethdev.c | 22 ------------------- lib/librte_ether/rte_ethdev.h | 12 ----------- lib/librte_ether/rte_ether_version.map | 1 - 6 files changed, 89 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index caa9db8..f591711 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -532,29 +532,6 @@ rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *cryptodrv, - enum pmd_type type) -{ - /* Call crypto device initialization directly if device is virtual */ - if (type == PMD_VDEV) - return rte_cryptodev_pci_probe( - (struct rte_pci_driver *)cryptodrv, - NULL); - - /* - * Register PCI driver for physical device intialisation during - * PCI probing - */ - cryptodrv->pci_drv.probe = rte_cryptodev_pci_probe; - cryptodrv->pci_drv.remove = rte_cryptodev_pci_remove; - - rte_eal_pci_register(&cryptodrv->pci_drv); - - return 0; -} - - uint16_t rte_cryptodev_queue_pair_count(uint8_t dev_id) { diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 450a376..abfe2dc 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -493,36 +493,6 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, extern int rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev); - -/** - * Register a Crypto [Poll Mode] driver. - * - * Function invoked by the initialization function of a Crypto driver - * to simultaneously register itself as Crypto Poll Mode Driver and to either: - * - * a - register itself as PCI driver if the crypto device is a physical - * device, by invoking the rte_eal_pci_register() function to - * register the *pci_drv* structure embedded in the *crypto_drv* - * structure, after having stored the address of the - * rte_cryptodev_init() function in the *probe* field of the - * *pci_drv* structure. - * - * During the PCI probing phase, the rte_cryptodev_init() - * function is invoked for each PCI [device] matching the - * embedded PCI identifiers provided by the driver. - * - * b, complete the initialization sequence if the device is a virtual - * device by calling the rte_cryptodev_init() directly passing a - * NULL parameter for the rte_pci_device structure. - * - * @param crypto_drv crypto_driver structure associated with the crypto - * driver. - * @param type pmd type - */ -extern int -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *crypto_drv, - enum pmd_type type); - /** * Executes all the user application registered callbacks for the specific * device. diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map index 1fc0d57..9627ac4 100644 --- a/lib/librte_cryptodev/rte_cryptodev_version.map +++ b/lib/librte_cryptodev/rte_cryptodev_version.map @@ -14,7 +14,6 @@ DPDK_16.04 { rte_cryptodev_info_get; rte_cryptodev_pmd_allocate; rte_cryptodev_pmd_callback_process; - rte_cryptodev_pmd_driver_register; rte_cryptodev_pmd_release_device; rte_cryptodev_pmd_virtual_dev_init; rte_cryptodev_sym_session_create; diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 42d7d5e..0b9f701 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -339,28 +339,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) return 0; } -/** - * Register an Ethernet [Poll Mode] driver. - * - * Function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver. - * Invokes the rte_eal_pci_register() function to register the *pci_drv* - * structure embedded in the *eth_drv* structure, after having stored the - * address of the rte_eth_dev_init() function in the *probe* field of - * the *pci_drv* structure. - * During the PCI probing phase, the rte_eth_dev_init() function is - * invoked for each PCI [Ethernet device] matching the embedded PCI - * identifiers provided by the driver. - */ -void -rte_eth_driver_register(struct eth_driver *eth_drv) -{ - eth_drv->pci_drv.probe = rte_eth_dev_pci_probe; - eth_drv->pci_drv.remove = rte_eth_dev_pci_remove; - rte_eal_pci_register(ð_drv->pci_drv); -} - int rte_eth_dev_is_valid_port(uint8_t port_id) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 83079e9..a7ba1f0 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1875,18 +1875,6 @@ struct eth_driver { }; /** - * @internal - * A function invoked by the initialization function of an Ethernet driver - * to simultaneously register itself as a PCI driver and as an Ethernet - * Poll Mode Driver (PMD). - * - * @param eth_drv - * The pointer to the *eth_driver* structure associated with - * the Ethernet driver. - */ -void rte_eth_driver_register(struct eth_driver *eth_drv); - -/** * Convert a numerical speed in Mbps to a bitmap flag that can be used in * the bitmap link_speeds of the struct rte_eth_conf * diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 17e7448..72be66d 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -78,7 +78,6 @@ DPDK_2.2 { rte_eth_dev_vlan_filter; rte_eth_dev_wd_timeout_store; rte_eth_dma_zone_reserve; - rte_eth_driver_register; rte_eth_led_off; rte_eth_led_on; rte_eth_link; -- 2.7.4