From: Fiona Trahe <fiona.trahe@intel.com>
To: dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,
akhil.goyal@nxp.com
Subject: [dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num qps and cleanup
Date: Thu, 6 Oct 2016 18:34:25 +0100 [thread overview]
Message-ID: <1475775269-21454-1-git-send-email-fiona.trahe@intel.com> (raw)
In-Reply-To: <20160926163300.22990-1-akhil.goyal@nxp.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]
ts_params->conf.nb_queue_pairs should not be hard coded with device
specific number. It should be retrieved from the device info.
Any test which changes it should restore it to orig value.
Also related cleanup of test code setting number and size of
queue-pairs on a device, e.g.
* Removed irrelevant “for” loop – was hardcoded to only loop once.
* Removed obsolete comment re inability to free and re-allocate queu memory
and obsolete workaround for it which used to create maximum size queues.
And added freeing of ring memory on queue-pair release in aesni_mb PMD,
else releasing and setting up queue-pair of a different size fails.
v3:
separate out into 4 patches
v2:
Fix for broken QAT PMD unit tests exposed by v1
i.e. In test_device_configure_invalid_queue_pair_ids() after running tests
for invalid values restore original nb_queue_pairs.
Also cleanup of test code setting number and size of queue-pairs on a device
Also fix for aesni_mb PMD not freeing ring memory on qp release
Fiona Trahe (4):
crypto/aesni_mb: free ring memory on qp release in PMD
app/test: remove pointless for loop
app/test: cleanup unnecessary ring size setup
app/test: remove hard-coding of crypto num qps
Akhil Goyal (1):
app/test: remove hard-coding of crypto num qps
app/test/test_cryptodev.c | 53 ++++++++++----------------
app/test/test_cryptodev_perf.c | 19 +--------
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 10 ++++-
3 files changed, 31 insertions(+), 51 deletions(-)
--
2.5.0
next prev parent reply other threads:[~2016-10-06 17:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 16:32 [dpdk-dev] [PATCH] examples/ipsec-secgw: Update checksum while decrementing ttl akhil.goyal
2016-09-26 13:28 ` Sergio Gonzalez Monroy
2016-10-05 0:34 ` De Lara Guarch, Pablo
2016-10-05 6:32 ` Akhil Goyal
2016-10-07 20:53 ` De Lara Guarch, Pablo
2016-10-10 12:05 ` Sergio Gonzalez Monroy
2016-10-17 17:05 ` De Lara Guarch, Pablo
2016-10-19 8:38 ` Akhil Goyal
2016-10-26 2:29 ` De Lara Guarch, Pablo
2016-09-26 16:32 ` [dpdk-dev] [PATCH] app/test: Remove hard coding for nb_queue_pairs in test_cryptodev akhil.goyal
2016-09-26 19:36 ` De Lara Guarch, Pablo
2016-09-29 14:12 ` Trahe, Fiona
2016-09-29 14:25 ` Thomas Monjalon
2016-09-29 14:29 ` De Lara Guarch, Pablo
2016-09-26 16:33 ` [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address akhil.goyal
2016-10-05 6:40 ` Akhil Goyal
2016-10-05 9:26 ` Kusztal, ArkadiuszX
2016-10-07 11:32 ` Akhil Goyal
2016-10-07 17:06 ` [dpdk-dev] [PATCH v2] " akhil.goyal
2016-10-07 21:36 ` De Lara Guarch, Pablo
2016-10-10 5:22 ` Akhil Goyal
2016-10-10 16:24 ` De Lara Guarch, Pablo
[not found] ` <20161012111629.14126-1-akhil.goyal@nxp.com>
2016-10-12 18:26 ` [dpdk-dev] [PATCH v3] " Trahe, Fiona
2016-10-13 19:35 ` De Lara Guarch, Pablo
2016-09-29 17:18 ` [dpdk-dev] [PATCH v2] app/test: remove hard-coding of crypto num qps Fiona Trahe
2016-10-05 0:49 ` De Lara Guarch, Pablo
2016-10-06 14:55 ` Trahe, Fiona
2016-10-06 17:34 ` Fiona Trahe [this message]
2016-10-07 0:29 ` [dpdk-dev] [PATCH v3 0/4] remove hard-coding of crypto num qps and cleanup De Lara Guarch, Pablo
2016-10-07 0:57 ` De Lara Guarch, Pablo
2016-10-06 17:34 ` [dpdk-dev] [PATCH v3 1/4] crypto/aesni_mb: free ring memory on qp release in PMD Fiona Trahe
2016-10-06 17:34 ` [dpdk-dev] [PATCH v3 2/4] app/test: remove pointless for loop Fiona Trahe
2016-10-06 17:34 ` [dpdk-dev] [PATCH v3 3/4] app/test: cleanup unnecessary ring size setup Fiona Trahe
2016-10-06 17:34 ` [dpdk-dev] [PATCH v3 4/4] app/test: remove hard-coding of crypto num qps Fiona Trahe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475775269-21454-1-git-send-email-fiona.trahe@intel.com \
--to=fiona.trahe@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).