From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id 59A112BA6 for ; Tue, 11 Oct 2016 15:56:13 +0200 (CEST) Received: by mail-qk0-f195.google.com with SMTP id n189so1461392qke.1 for ; Tue, 11 Oct 2016 06:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=LhDJSGWtIBeBis+UHfi0lw4944vywqhxz+izgz7qEpY=; b=ek9jC2RzeisYwR11bss69CNIMc2OEpeoj5QrQCO5mkLkMFUjWYJU7a8seLr1oXoUzc hPuLOfYsn2zzuW7YdWCT8ByB6aggo+krZcrdtR6naEW5JVC9VYMGRnjQ+/h1+xMulP+p c72cM4oudclx2HaounM6UpVk+BiyrAG8odez3MqbH3aXjoJvTuv6PXbcFq+RX46fcAJ/ c4Y9RLHn/oZkWYDYxGdHNPsfKvIXnM9QZjKFyXcn/MCzZFEtFLrxqv+nXsMulPuIJPLt BIAjOO7u/I2duKyOTOqVUMdxXN2hPyjmBtHA+lhQ2voABdoSQVW0kDyUu8Zb/skcNnax ACXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=LhDJSGWtIBeBis+UHfi0lw4944vywqhxz+izgz7qEpY=; b=RzXIPot25YZ+ip9+kxuqBjxh8sv53BIiYTbJVBhyMvl7Emjh7GgqSKlILq1XeIVZAQ xmVx2R2psGg3qLEa3Jh/IL45Bgd1/nhaEunDEptfepOQNT7HOolqnX5qKx+RjhvkNc6+ pe+ThVgkjIiJKoqIsCzs+HGAmg7FFIshAd98RZ4DBnwbjlv19BRQMfuPg7b9P/fzYtrs xUYN22LwJjkWj8MjYoU4ii44ZQOA0d+iqvW4wSxeyTuSfkF4X1o2Bh3oNOnZmU6BlGRr eeO4Wfi0qRA4QZAyzQcq7RT7YJ5SWCfS3i9Ot+R4ajVaNnA+pER56IkqESxPxH+Pq5BO rsWw== X-Gm-Message-State: AA6/9RkTOhATygdv/BQdX+liGhuxS+J5Oz8+DLqm4BIF8QWYNTKqgdpE3yCeTO2pJXJ11A== X-Received: by 10.55.112.195 with SMTP id l186mr3072701qkc.183.1476194172901; Tue, 11 Oct 2016 06:56:12 -0700 (PDT) Received: from monolith.home (pool-96-255-41-157.washdc.fios.verizon.net. [96.255.41.157]) by smtp.googlemail.com with ESMTPSA id k65sm1156892qkf.7.2016.10.11.06.56.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Oct 2016 06:56:12 -0700 (PDT) Message-ID: <1476194171.1627.7.camel@gmail.com> From: Chas Williams <3chas3@gmail.com> To: Rasesh Mody , dev@dpdk.org Cc: Dept-EngDPDKDev@qlogic.com Date: Tue, 11 Oct 2016 09:56:11 -0400 In-Reply-To: <1475732197-668-1-git-send-email-rasesh.mody@qlogic.com> References: <1475732197-668-1-git-send-email-rasesh.mody@qlogic.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix maximum PF queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 13:56:13 -0000 On Wed, 2016-10-05 at 22:36 -0700, Rasesh Mody wrote: > Fix the max number of PF rx/tx queues. Set the value based > on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128. > > Fixes: 540a211 ("bnx2x: driver core") > > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c > index a49a07f..2bb4a84 100644 > --- a/drivers/net/bnx2x/bnx2x.c > +++ b/drivers/net/bnx2x/bnx2x.c > @@ -9556,8 +9556,8 @@ static void bnx2x_init_rte(struct bnx2x_softc *sc) > sc->max_rx_queues = min(BNX2X_VF_MAX_QUEUES_PER_VF, > sc->igu_sb_cnt); > } else { > - sc->max_tx_queues = 128; > - sc->max_rx_queues = 128; > + sc->max_rx_queues = BNX2X_MAX_RSS_COUNT(sc); > + sc->max_tx_queues = sc->max_rx_queues; > } > } Technically, I think max_tx_queues would be max_rx_queues * max_cos. However, I don't think there are any DPDK applications that would take advantage of this. Acked-By: Chas Williams <3chas3@gmail.com>