From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 84DB08DAF for ; Wed, 28 Oct 2015 15:06:55 +0100 (CET) Received: by wmec75 with SMTP id c75so7919976wme.1 for ; Wed, 28 Oct 2015 07:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=mTUcHRKRt4u9HsIPZ+oEFp9LzgIsrcvGsNPZsuhQ3t8=; b=Y2dXNFra/B9glomEkQbRgGIprwmmKNa8EvUWJKiTjsencr5gIxKgzF9jnVVMUfXdWC nmcQUk+Q+yjzNsEj66CCt7scm7zQX8/Vk1mGnY6BG8ZdyhswFEQuADOQG+3sgQ2cSwkr z27tTAt+3oqhD7hwfjVtdli2dBcErs/XQIGhu7ajHqEyrf1Ax8bsBfdWwzSq0uPYvNRE FzBqUIm0ix3r9BWAU7yvBtZtt5NTmcdzZ5AItTpEtCpUaT8DkLLnSWRqcMOWZRpaoskD +Uo+mO0XPCdoPpa+o+9IaAlH59X4lp8ZuuYtqPjn/nMSTAZ/AvZUfxWuJ5lFHLDd9xGp 9IsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=mTUcHRKRt4u9HsIPZ+oEFp9LzgIsrcvGsNPZsuhQ3t8=; b=fEXvYuJDJxcIMRTcGOm8CyvHGMY/mPb/uT0cfVsytPhKHIBLdR2UTCIvvCFnQTKt8S F+5Ayr105QgVTeEG/eqOawF54P9vvKHeinhfYFmaKHuT35y8lTqz1HQNQoydbrmCDn4E B7wcftsnWJsD3d0OPE0GNus55AVY5tFKq9HVvM21ruYE3UC6dgobz/UOaZFTtACNXzHg 8ctDNiJ1HZ+zMgkNGfGtHXybPnsSlAmwJBRPswhQGgDTXU7OW9NC98tpUgDyZdudyxCo E9yAjThJWOFd3bygONg6jck1hIWR4iIOUgXifgHldZrsnv5nHwkapO8fiu5bkqB4qQiD aYzg== X-Gm-Message-State: ALoCoQnbCwx2KngXYo0T+gBSxFoHgMLKzKMVQyQRa2wno0bauKRsyractaCiaJKrxrSOUMA1+ZV0 X-Received: by 10.28.145.132 with SMTP id t126mr1480906wmd.31.1446041215265; Wed, 28 Oct 2015 07:06:55 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id mb12sm4861473wic.15.2015.10.28.07.06.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2015 07:06:54 -0700 (PDT) From: Thomas Monjalon To: "Van Haaren, Harry" Date: Wed, 28 Oct 2015 15:05:44 +0100 Message-ID: <1476412.gWjkHWKLvT@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A09C7@shsmsx102.ccr.corp.intel.com> References: <1443701571-7000-1-git-send-email-harry.van.haaren@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909020A09C7@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix 82599 / 82598 register differences X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 14:06:55 -0000 > > Ixgbe based 82598 and 82599 have different priority recieve link-on register > > addresses. This is solved in base/ by providing in the PXONRXC and > > PXONXCNT as seperate macros. This patch ensures the correct address is > > read, avoiding reading garbage values. > > > > Also PXON2OFFCNT doesn't exist in 82598, so it is not read for that MAC. > > > > This issue has existed since the drivers were imported into DPDK, but was > > not easily discoverable as xstats were not available. > > Tested using testpmd> show port xstats all > > > > Fixes: af75078fece3 ("first public release") > > > > Signed-off-by: Harry van Haaren > Acked-by: Wenzhuo Lu Applied, thanks