From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id B52F65A38 for ; Thu, 30 Jul 2015 18:23:27 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so251887678wib.0 for ; Thu, 30 Jul 2015 09:23:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=f9hhUhRo9/OikPvQbfvH9pXrR8CNkLlXoaWetuppH9g=; b=IOq9aDm5LcmL2ToEKpdxNDUww7B8tnhcMT2YLANIRWR/Gr+UjFqtD4NRWrySgNj3nv ErwXEmt1zaLcKidYJuKTtVxDkY1KI3Q637NAjrJAdv/rX2bzfmB9vqUPjGArFiCfd9LF Ja3nvySosWhMODlvoGOBPFneN32+xxHHN1ktVgA8WM8Up6+RiZAJLTQaregrjeP55SsT NNTc69uuZjTyirhDU5mdE4lkms4yz0m7AJoZJ/KPhlN3uB3D0e3iAD4wb4msg7fu1VeU sHgRw/pT417JJRb4+GCcLoJbE6nur1jhibN+e8h9ODLWWO23FddDj8vYGvsbe4Sb5Zib BJwQ== X-Gm-Message-State: ALoCoQmUdpSBViUHdZSIrox632kefbC1IpCBK3pxHr96PDv3jvLdEAn8cdMVjbTlnVqkIjCKmArK X-Received: by 10.180.76.232 with SMTP id n8mr8165026wiw.72.1438273407461; Thu, 30 Jul 2015 09:23:27 -0700 (PDT) Received: from xps13.localnet (152.20.90.92.rev.sfr.net. [92.90.20.152]) by smtp.gmail.com with ESMTPSA id gc4sm30656162wib.23.2015.07.30.09.23.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 09:23:26 -0700 (PDT) From: Thomas Monjalon To: Nelio Laranjeiro Date: Thu, 30 Jul 2015 18:22:11 +0200 Message-ID: <1477408.eLvkxO1gTB@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1438267704-26414-2-git-send-email-nelio.laranjeiro@6wind.com> References: <1438178178-5062-1-git-send-email-nelio.laranjeiro@6wind.com> <1438267704-26414-1-git-send-email-nelio.laranjeiro@6wind.com> <1438267704-26414-2-git-send-email-nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PACTH v2 2/2] mlx4: fix shared library dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 16:23:28 -0000 2015-07-30 16:48, Nelio Laranjeiro: > librte_pmd_mlx4.so needs to be linked with libiverbs otherwise, the PMD is not > able to open Mellanox devices and the following message is printed by testpmd > at startup "librte_pmd_mlx4: cannot access device, is mlx4_ib loaded?". > > Applications dependency on libverbs are moved to be only valid in static mode, > in shared mode, applications do not depend on it anymore, > librte_pmd_mlx4.so keeps this dependency and thus is linked with libverbs. > > Signed-off-by: Nelio Laranjeiro > Acked-by: Olivier Matz > --- > Changelog: don't compiled MLX4 PMD when the DPDK is build in combined shared > library. MLX4 cannot be supported in combined shared library because there is no clean way of adding -libverbs to the combined library. (This comment should be in the commit message) > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -40,7 +40,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic > DIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k > DIRS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e > DIRS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe > -DIRS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4 > DIRS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += mpipe > DIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += null > DIRS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += pcap > @@ -49,5 +48,10 @@ DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio > DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3 > DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += xenvirt > > +# Drivers not support in combined mode This comment is useless. > +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n) It can be enabled if building a static combined library. > +DIRS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4 There is no good reason to move this line.