From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E724DA0093; Sun, 11 Dec 2022 08:50:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A28840A81; Sun, 11 Dec 2022 08:50:56 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 7F9B34068E for ; Sun, 11 Dec 2022 08:50:55 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 689235C00C8; Sun, 11 Dec 2022 02:50:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 11 Dec 2022 02:50:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1670745052; x= 1670831452; bh=mRTKleSIuCcH5qnLurDvFLZ+Rvnfghvbuwvyn2w2g7s=; b=K qFg/TSkygtIbAbQeF3VdAjq1IKDIz8ooWyoiTSdaQ25V134ztC3F9G1Qx0dbLcot qCkRP4uB6Phu6J9zHcLOoRbdUNGYR96nMttNVEUaPIqMWCQujR6X84x3iYNCjkSI 8N2oZKpwnyz0ec491GBklYJmiFdZTs3ikjWPok0VVfbYo3ylvdE7Cd9NCO7whpO6 5ivBZed4ruf6RaFwH1Bqiwu6V89Kz25xC4o2UawQI2tK6iWIHbtzTXDeE8sfIuld QKboUnq45RlaX8J9A8HG+3OJafI6km6are1kuUBizqE8OGYDIWsKgckuboKmh0Ds ymtntg8/6A5zELFCLyS6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670745052; x= 1670831452; bh=mRTKleSIuCcH5qnLurDvFLZ+Rvnfghvbuwvyn2w2g7s=; b=Y qiGgTKT5eJUzfOXb9kTRSMwuikOSnR2x1ImyacUu33+X1sMUsnS81ZdRU9OGbVnf 4Jgg8yEJO/POAe6dk0LEjQZDryfxG7X5DoArm5KCpKyzGTiTuXwyx5EiWgJucm7p pc6zp5nX/NJQgMf68bP9btHPmBGq3XV54wRHC07recWZQLw7CrDs++zPltz6BKfL x3FX47ezZIj/x/ZUgC5sXV1TQhWHWxE2YbsCmdJk+KpgUQYxNp/i37SW2/pByzvA /FXO08VnRa/6cdqOTvcxMdcqPenGpIkD3uACZulLZiCPwDEcnANEVlVCz1reVNf3 TYH4tSlNKlqnwOo1eI6EQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 11 Dec 2022 02:50:50 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: Stephen Hemminger , dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , david.marchand@redhat.com, Bruce Richardson Subject: Re: help with pthread_t deprecation / api changes Date: Sun, 11 Dec 2022 08:50:48 +0100 Message-ID: <14786965.JCcGWNJJiE@thomas> In-Reply-To: <20221209234947.GA26599@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20221130225427.GA13682@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <6848416.18pcnM708K@thomas> <20221209234947.GA26599@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/12/2022 00:49, Tyler Retzlaff: > On Fri, Dec 09, 2022 at 10:13:44PM +0100, Thomas Monjalon wrote: > > 09/12/2022 21:06, Tyler Retzlaff: > > > On Fri, Dec 09, 2022 at 08:48:14AM -0800, Stephen Hemminger wrote: > > > > On Fri, 09 Dec 2022 08:53:57 +0100 > > > > Thomas Monjalon wrote: > > > > > > > > > > > If some execution environment doesn't support thread names, it could return a string that makes it possible for a human to identify the thread, e.g. the tread id. Again, this is assuming that it is only used for debugging, trace, and similar. > > > > > > > > > > > > i think this raises a good question. is the purpose of setting a thread name > > > > > > meant to be something we can use from the application or is it something that > > > > > > is for debugging diagnostics and may be a best effort? > > > > > > > > > > > > Thomas Monjalon wrote: > > > > > > > I think yes it is only for debugging. > > > > So best effort looks to be a good approach. > > > > I'm not sure you need to replace the functions. > > > > Can you just complete the implementations? > > > > > > the patch series put forward allows a set / get name per-lcore, where > > > you get implicit (but not exposed via the eal api) call to underlying > > > platform thread setname. > > > > I don't understand how lcore ID and thread ID are connected. > > You can run multiple control threads on a single lcore. > > > > correct. > > the new public api allows the set of a name on an lcore only. as a > side-effect if the platform supports it the name is also set on the > thread_id associated with the lcore (from lcore_config[].thread_id). > > for control threads you just get the side-effect if the platform > supports it, otherwise it is a noop. What does it mean? which side effect? what must be supported? > if we want set / get name at all this seemed the most usable balance > between application consumption with debug use where available. if this > isn't acceptable then i would suggest we simply remove both > rte_thread_{get,set}name because as a debugging facility we cannot offer > a consistent abstracted api which means it shouldn't be in the eal at > all. Why it cannot be consistent? Please be more precise.