From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <qi.z.zhang@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 2F7F237B7
for <dev@dpdk.org>; Fri, 16 Dec 2016 05:09:11 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by fmsmga105.fm.intel.com with ESMTP; 15 Dec 2016 20:09:10 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,355,1477983600"; d="scan'208";a="43202071"
Received: from unknown (HELO localhost.localdomain.sh.intel.com)
([10.239.129.189])
by fmsmga006.fm.intel.com with ESMTP; 15 Dec 2016 20:09:09 -0800
From: Qi Zhang <qi.z.zhang@intel.com>
To: jingjing.wu@intel.com,
helin.zhang@intel.com
Cc: dev@dpdk.org,
"Chen Jing D(Mark)" <jing.d.chen@intel.com>
Date: Thu, 15 Dec 2016 16:05:18 -0500
Message-Id: <1481835919-36488-29-git-send-email-qi.z.zhang@intel.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1481835919-36488-1-git-send-email-qi.z.zhang@intel.com>
References: <1481835919-36488-1-git-send-email-qi.z.zhang@intel.com>
Subject: [dpdk-dev] [PATCH v3 28/29] net/i40e: enhance in sanity check of MAC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Dec 2016 04:09:11 -0000
From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
When VF sends request to add a new MAC address, PF host
will check if it's a non-zero or unicast address, or it
will return with error. In fact, VF still can set multicast
address. This change remove to check if it's a unicast
address.
Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
drivers/net/i40e/i40e_pf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
index 71e6a3f..79f4295 100644
--- a/drivers/net/i40e/i40e_pf.c
+++ b/drivers/net/i40e/i40e_pf.c
@@ -890,8 +890,8 @@ i40e_pf_host_process_cmd_add_ether_address(struct i40e_pf_vf *vf,
mac = (struct ether_addr *)(addr_list->list[i].addr);
(void)rte_memcpy(&filter.mac_addr, mac, ETHER_ADDR_LEN);
filter.filter_type = RTE_MACVLAN_PERFECT_MATCH;
- if(!is_valid_assigned_ether_addr(mac) ||
- i40e_vsi_add_mac(vf->vsi, &filter)) {
+ if (is_zero_ether_addr(mac) ||
+ i40e_vsi_add_mac(vf->vsi, &filter)) {
ret = I40E_ERR_INVALID_MAC_ADDR;
goto send_msg;
}
--
2.7.4