From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by dpdk.org (Postfix) with ESMTP id 60CD8FBBB for ; Tue, 20 Dec 2016 21:57:33 +0100 (CET) Received: by mail-qt0-f193.google.com with SMTP id n6so24429237qtd.0 for ; Tue, 20 Dec 2016 12:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=utgUh/T/BQDyuQNWU/jBcWZNBLX7nNjKWmEAzKj1T6s=; b=mU18jyohAhdYuGIj5cRxaMgAs0rgf3k3aYbO4Vr+Na+G3qBl9OTpPnLjmZMsAS9E6E S9CnCS9TES69EPoApZFsg233pcAlpBVd3idAJJ6r9XiLfg/mwCBXjm4tWwZzOlq7KxCb zq7DJ+ob80mz0gMvuG3odrNDN52zT7qJs2U4SD3IDxK7Ms18R1zP1srhXjfYWAHVDiqA 1ZfmVhprxURTsAPuty1Sghh2HRI1124H7hn2FgGI2aFlBO7icZ35fVaL15uR8g6lMAjQ 7tD2JwBU6Z4upU0VARjHvKRKJhZQXFfYzvHbewkOjDiqyl3yg+VonUtCGR88/WJorCnW PwEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=utgUh/T/BQDyuQNWU/jBcWZNBLX7nNjKWmEAzKj1T6s=; b=IBfpAugvc6KX75xAKG0cs0SR8KA4wLc871nNJVWuAEMbBEP8qLz9uxUfPflbB+1Cc3 VGubdJxmaYgIqo3XpJ6WlSGvGWnIhcMBOCRd529DLBlr+WtDXOxoF6pUaS6Sy9R+3l24 BZAJ3ZpSS2dFbNHJ8Qr9cctGCf81mEa1mcZQMLFnIWLyodCBc5KeegJnCuVqmjq4Mj9B hn1S3UAez2970BAvZroDj7cu8GvmfktRJaGy5AdZl9CMYAIGNGtvp7ztUhXsCw+RHdkm OdLPdkDX3YzWlobLC57mlECEwMXEn41C/A2MSsjyxq1OGEPvGJcVRIKuYfRfpv6y6z5x Ehmw== X-Gm-Message-State: AIkVDXJGUahee2lkkaKGkpeu6EI5lCnlZvQmN42IkS0/eujlSeM3jU6N1udB+yVa0dWqgQ== X-Received: by 10.200.46.129 with SMTP id h1mr1334494qta.277.1482267452816; Tue, 20 Dec 2016 12:57:32 -0800 (PST) Received: from monolith.home (pool-173-66-96-194.washdc.fios.verizon.net. [173.66.96.194]) by smtp.googlemail.com with ESMTPSA id w34sm13929495qtw.10.2016.12.20.12.57.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Dec 2016 12:57:32 -0800 (PST) Message-ID: <1482267451.1677.5.camel@gmail.com> From: Chas Williams <3chas3@gmail.com> To: Ferruh Yigit , dev@dpdk.org Cc: "John W. Linville" Date: Tue, 20 Dec 2016 15:57:31 -0500 In-Reply-To: <40da3bb6-9d84-9703-36f7-a0eb21fc48dc@intel.com> References: <1481997835-23288-1-git-send-email-3chas3@gmail.com> <40da3bb6-9d84-9703-36f7-a0eb21fc48dc@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/af_packet: initialize link interrupt callback queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 20:57:33 -0000 On Tue, 2016-12-20 at 14:20 +0000, Ferruh Yigit wrote: > On 12/17/2016 6:03 PM, Chas Williams wrote: > > This patch initializes the eth_dev->link_intr_cbs queue which is > > used when af_packet is passed into rte_eth_ev_callback_register(). > > Why do you want to register callback to af_packet PMD, it won't be > calling them? Because I have a some other code that basically treats all the PMD's the same way.  Do I really need to write an exception for that code that says "if this is driver such and such don't call this API routine?" > > > > Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") > > > > Signed-off-by: Chas Williams <3chas3@gmail.com> > > Please cc the maintainers... OK > > CC: John W. Linville > > > --- > > drivers/net/af_packet/rte_eth_af_packet.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > > index a1e13ff..ea5070a 100644 > > --- a/drivers/net/af_packet/rte_eth_af_packet.c > > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > > @@ -708,6 +708,7 @@ rte_pmd_init_internals(const char *name, > > (*eth_dev)->data->drv_name = pmd_af_packet_drv.driver.name; > > (*eth_dev)->data->kdrv = RTE_KDRV_NONE; > > (*eth_dev)->data->numa_node = numa_node; > > + TAILQ_INIT(&((*eth_dev)->link_intr_cbs)); > > > > return 0; > > > > > >