DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wei Dai <wei.dai@intel.com>
To: dev@dpdk.org
Cc: helin.zhang@intel.com, konstantin.ananyev@intel.com,
	Wei Dai <wei.dai@intel.com>
Subject: [dpdk-dev] [PATCH v2 24/30] net/ixgbe/base: add EEE support for some PHYs
Date: Wed, 21 Dec 2016 17:48:08 +0800	[thread overview]
Message-ID: <1482313694-31602-25-git-send-email-wei.dai@intel.com> (raw)
In-Reply-To: <1482313694-31602-1-git-send-email-wei.dai@intel.com>

This patch adds Energy Efficient Ethernet (EEE) support for
some Marvell PHYs on some future platforms.
Because EEE capability or status was not indicated previously,
this patch simply assumes that it is supported.

As soon as there is a PHY that does not support EEE, there will
be defects in this area because the driver will not report the
EEE status correctly.

This also deletes some now-unused definitions from an earlier
Marvell PHY implementation and combines a device ID check into a
switch statement.

Signed-off-by: Wei Dai <wei.dai@intel.com>
---
 drivers/net/ixgbe/base/ixgbe_x550.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c
index 49b59e7..2aaed6b 100644
--- a/drivers/net/ixgbe/base/ixgbe_x550.c
+++ b/drivers/net/ixgbe/base/ixgbe_x550.c
@@ -896,19 +896,18 @@ s32 ixgbe_init_ops_X550EM_a(struct ixgbe_hw *hw)
 		break;
 	}
 
-	if ((hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T) ||
-		(hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L)) {
+	switch (hw->device_id) {
+	case IXGBE_DEV_ID_X550EM_A_1G_T:
+	case IXGBE_DEV_ID_X550EM_A_1G_T_L:
 		mac->ops.fc_autoneg = ixgbe_fc_autoneg_sgmii_x550em_a;
 		mac->ops.setup_fc = ixgbe_fc_autoneg_fw;
-	}
-
-	switch (hw->device_id) {
-	case IXGBE_DEV_ID_X550EM_A_KR:
-	case IXGBE_DEV_ID_X550EM_A_KR_L:
 		mac->ops.setup_eee = ixgbe_setup_eee_fw;
+		hw->phy.eee_speeds_supported = IXGBE_LINK_SPEED_100_FULL |
+					       IXGBE_LINK_SPEED_1GB_FULL;
+		hw->phy.eee_speeds_advertised = hw->phy.eee_speeds_supported;
 		break;
 	default:
-		mac->ops.setup_eee = NULL;
+		break;
 	}
 
 	return ret_val;
-- 
2.7.4

  parent reply	other threads:[~2016-12-21  9:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21  9:47 [dpdk-dev] [PATCH v2 00/30] update ixgbe shared code to version 16.11.21 Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 01/30] net/ixgbe/base: fix PHY reset check for x550em-ext Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 02/30] net/ixgbe/base: fix clearing SAN MAC address Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 03/30] net/ixgbe/base: use fast MDIO for non-10G devices Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 04/30] net/ixgbe/base: fix PHY identification for x550a Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 05/30] net/ixgbe/base: clean up X557 link status check Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 06/30] net/ixgbe/base: add driver version to firmware Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 07/30] net/ixgbe/base: store link active LED Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 08/30] net/ixgbe/base: cleanup X540 checksum calculation Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 09/30] net/ixgbe/base: enable LASI only for X552 devices Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 10/30] net/ixgbe/base: limit iXFI setup to " Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 11/30] net/ixgbe/base: fix getting PHY type for some x550 devices Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 12/30] net/ixgbe/base: fix SGMII link setup for M88 PHYs Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 13/30] net/ixgbe/base: cleanup dead EEE code Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 14/30] net/ixgbe/base: fix setting unsupported autoneg speeds Wei Dai
2016-12-21  9:47 ` [dpdk-dev] [PATCH v2 15/30] net/ixgbe/base: support FW commands to control some PHYs Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 16/30] net/ixgbe/base: use " Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 17/30] net/ixgbe/base: support busy SGMII register reads Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 18/30] net/ixgbe/base: include new speeds in VFLINK interpretation Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 19/30] net/ixgbe/base: limit 5Gb support to X550 devices Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 20/30] net/ixgbe/base: add physical layer options for FW PHY type Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 21/30] net/ixgbe/base: remove unneeded MAC type check Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 22/30] net/ixgbe/base: remove unused PHY ID Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 23/30] net/ixgbe/base: update FW PHY flow control Wei Dai
2016-12-21  9:48 ` Wei Dai [this message]
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 25/30] net/ixgbe/base: remove unused enum type Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 26/30] net/ixgbe/base: fix IXGBE LSWFW register Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 27/30] net/ixgbe/base: remove unused EEE code Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 28/30] net/ixgbe/base: add write flush required by Inphi PHY Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 29/30] net/ixgbe/base: report physical layer for SGMII PHY type Wei Dai
2016-12-21  9:48 ` [dpdk-dev] [PATCH v2 30/30] net/ixgbe/base: update shared code version to 2016.11.21 Wei Dai
2016-12-21 17:20 ` [dpdk-dev] [PATCH v2 00/30] update ixgbe shared code to version 16.11.21 Ferruh Yigit
2016-12-22  2:35   ` Dai, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482313694-31602-25-git-send-email-wei.dai@intel.com \
    --to=wei.dai@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).