From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1AFBA0350; Tue, 23 Jun 2020 09:16:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CB4F1D56C; Tue, 23 Jun 2020 09:16:09 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 91CB31D555 for ; Tue, 23 Jun 2020 09:16:08 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 1F26B5801C7; Tue, 23 Jun 2020 03:16:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 23 Jun 2020 03:16:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= z+06TjZsa1SpkNLVMokzk6lR0DqJadGgaN2RA445xGw=; b=DeYf9wsasdjs9KxL pbJSAPyNOSMyBdLAiEh7+M/DFAvXpPetGrWvZgVxCMzrzx1Cu4tf334dUYkyvTmB cihnNleGY/XJUXKy9AqxDUdmgSpRiZQ4vfMduf0uqaxVGCKkthW6AOh/vHHtFPqI unfoVwLgtSV807RYgftv+Oinc5gxw89z0L4FGBE5lZBzdOK4iadI+mAUGAQTfxUr OWLmEwHe4HObFEbIOCpuY0Uzqqd8x6f8vgeAvBepf/BO+xNO2uwBdt04hR1sxewp TxmX6F+FW97xoW3fYpWWsPEyyFP+uII7y/LKAq9NunBaty5tqaqpvJ1DFEY0ZDtf 3x8vyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=z+06TjZsa1SpkNLVMokzk6lR0DqJadGgaN2RA445x Gw=; b=bXyNUduhn8KtiwqMtK+WtaEe+2AUO7/7vqSUa8aUlHxm7gkOmyIuD7lJK AFFuFCRQOwPCptUHpnUAaEqrOVOQX8quhrpa/kUOWB+wyr7E6FaS3X1OJzL+FXJK CUDqLzk6Y7QkIIm7HV0XsN2db3Bnggp4aAPvq5zNFImHoJN+1ou4EW4CMP6iAfx5 872Pa+4f7w+/Q+Co3MuOBrIWcjEimwsjND0VHkLAl2u1Bko9DtKUhtBEsn5kvFR+ /2fsTXGYltkRcFRmQDzIP08rDGDsAJnNBMmTi6uzgzcUoTBky5Px9qSgLKWoa/sE 3hK5NIDcIN+YPHFQxGa+uwNiWXTPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekfedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 344D43280068; Tue, 23 Jun 2020 03:16:04 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: "dev@dpdk.org" , "pallavi.kadam@intel.com" , "dmitry.kozliuk@gmail.com" , "david.marchand@redhat.com" , "grive@u256.net" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anatoly.burakov@intel.com" , Fady Bader , "bruce.richardson@intel.com" Date: Tue, 23 Jun 2020 09:16:02 +0200 Message-ID: <14824842.b0o1j6Pnvo@thomas> In-Reply-To: References: <20200621102612.22740-2-talshn@mellanox.com> <1982686.VIimsLeXWE@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/06/2020 08:45, Tal Shnaiderman: > > 22/06/2020 09:55, talshn@mellanox.com: > > > +struct internal_config * > > > +rte_eal_get_internal_configuration(void) > > > +{ > > > + return &internal_config; > > > +} > > > > This function should be private to EAL, no rte_ prefix. > > When creating the new functions I based the pattern on the already existing function > rte_eal_get_configuration() which encapsulates the formally global rte_config. > > Do we want to remove the rte_ prefix from this function as well? No, don't change the existing function. It could be a separate cleanup.