From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 0567F2C5E for ; Fri, 23 Dec 2016 16:58:33 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id l2so16729226wml.2 for ; Fri, 23 Dec 2016 07:58:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=QQZQwTjZlFg8JFlOfp0mio4xQKZjtgXBOkaFc0H7axY=; b=MzpVhyPC3PwDMJHE6wcHRLmSZ7Npg3LASJS764BLvz1Geykg8D+zWJVgwbBER++yJw TqhJNHeCbeKbl0iR2tG43oECLNW043CrhhvFbBpJ9ExLKDpHOr9wMi757BTDTLKug+cE fZLgAEJtb0MBRj7Sdb4ryTzEJV7QjHrc69ng+oH83du/n19G1ibU9rXSXdyTMo+PDDHS 1jmroxB+WyGEI/GkGD2NcYjrfn4CiURLjWNIVQOz+Qd6EdLyuh9oAm7e2ey7XpQxE8j1 Fz1yCRhyfRNVwazPJufh5SJZPH7V66DaD7D74EaMWDoSAKhxjIEhBV8l79A0o5N9UGi3 ZJlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=QQZQwTjZlFg8JFlOfp0mio4xQKZjtgXBOkaFc0H7axY=; b=qsPpzdDYGOxvsMQu0yNmdMUMs1NVcDIbEXb2bVLuEaaRPgjtaxIcZ3jyolegiZNa9L 7rCpVxlcFghbCE3i4o65GRQhUkzUbuI+8hR0Ib1E4R10EfJ/XPQwqlJbaH0P313Y/trQ mxIRfx2pURskQln1uko0dr3guB191kNlXbtRKWIYCZQ3sD1Qraj2cPIlHdNuffvb9g/W wS++oD26hJUIm6LcFbRutxB8IfIIYbL+EthGQCKHjSU1z+rW7c3IRNhbi+u50eijzLwH I3BNuoFbL3nCiq65XIxbBclqqycRFYM3QyYauX7ZGuMrTyE7AbPYLAmxiPszP/ydKeWM SCAQ== X-Gm-Message-State: AIkVDXLvrz49MO5iXEBD/D+DS9Xrw2S9TIPV0QXU90saPVYBjqMnueiZj9B+bSnP7rIAnQ== X-Received: by 10.28.5.193 with SMTP id 184mr17117535wmf.89.1482508712732; Fri, 23 Dec 2016 07:58:32 -0800 (PST) Received: from weierstrass.local.net ([91.200.109.169]) by smtp.gmail.com with ESMTPSA id jm6sm41027072wjb.27.2016.12.23.07.58.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Dec 2016 07:58:31 -0800 (PST) Sender: Jan Blunck From: Jan Blunck To: dev@dpdk.org Cc: Stephen Hemminger , shreyansh.jain@nxp.com, david.marchand@6wind.com, Stephen Hemminger Date: Fri, 23 Dec 2016 16:57:55 +0100 Message-Id: <1482508691-11408-5-git-send-email-jblunck@infradead.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482508691-11408-1-git-send-email-jblunck@infradead.org> References: <1482508691-11408-1-git-send-email-jblunck@infradead.org> In-Reply-To: <1482332986-7599-1-git-send-email-jblunck@infradead.org> References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> Subject: [dpdk-dev] [PATCH v5 04/20] pmd: remove useless reset of dev_info->dev_pci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 15:58:33 -0000 From: Stephen Hemminger Since rte_eth_dev_info_get does memset() on dev_info before calling device specific code, the explicit assignment of NULL in all these virtual drivers has no effect. Signed-off-by: Stephen Hemminger Acked-by: Jan Blunck --- app/test/virtual_pmd.c | 1 - drivers/net/af_packet/rte_eth_af_packet.c | 1 - drivers/net/bonding/rte_eth_bond_pmd.c | 1 - drivers/net/null/rte_eth_null.c | 1 - drivers/net/pcap/rte_eth_pcap.c | 1 - drivers/net/ring/rte_eth_ring.c | 1 - drivers/net/xenvirt/rte_eth_xenvirt.c | 1 - 7 files changed, 7 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index bd969f9..2517208 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -117,7 +117,6 @@ virtual_ethdev_info_get(struct rte_eth_dev *dev __rte_unused, dev_info->max_tx_queues = (uint16_t)512; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static int diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index ff45068..2951f86 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -287,7 +287,6 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_rx_queues = (uint16_t)internals->nb_queues; dev_info->max_tx_queues = (uint16_t)internals->nb_queues; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index b604642..c1796f2 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1672,7 +1672,6 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_tx_queues = (uint16_t)512; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; dev_info->rx_offload_capa = internals->rx_offload_capa; dev_info->tx_offload_capa = internals->tx_offload_capa; diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index f09caf1..0b6715e 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -301,7 +301,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues); dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues); dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; dev_info->reta_size = internals->reta_size; dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads; } diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 0162f44..7253b9a 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -559,7 +559,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = dev->data->nb_rx_queues; dev_info->max_tx_queues = dev->data->nb_tx_queues; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index c7726f4..975956a 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -179,7 +179,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues; dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c index c08a056..609824b 100644 --- a/drivers/net/xenvirt/rte_eth_xenvirt.c +++ b/drivers/net/xenvirt/rte_eth_xenvirt.c @@ -337,7 +337,6 @@ eth_dev_info(struct rte_eth_dev *dev, dev_info->max_rx_queues = (uint16_t)1; dev_info->max_tx_queues = (uint16_t)1; dev_info->min_rx_bufsize = 0; - dev_info->pci_dev = NULL; } static void -- 2.7.4