From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A458236E for ; Tue, 27 Dec 2016 14:11:38 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 27 Dec 2016 05:11:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,416,1477983600"; d="scan'208";a="207156924" Received: from unknown (HELO dpdk7.bj.intel.com) ([172.16.182.76]) by fmsmga004.fm.intel.com with ESMTP; 27 Dec 2016 05:11:35 -0800 From: Qiming Yang To: dev@dpdk.org, thomas.monjalon@6wind.com Cc: remy.horton@intel.com, ferruh.yigit@intel.com, Qiming Yang Date: Tue, 27 Dec 2016 21:06:08 +0800 Message-Id: <1482843968-6483-1-git-send-email-qiming.yang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1481008582-69416-6-git-send-email-qiming.yang@intel.com> References: <1481008582-69416-6-git-send-email-qiming.yang@intel.com> Subject: [dpdk-dev] [PATCH v3] ethtool: dispaly bus info and firmware version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2016 13:11:39 -0000 This patch enhances the ethtool example to support to show bus information and firmware version, in the same way that the Linux kernel ethtool does. Signed-off-by: Qiming Yang --- v3 changes: * split this patch from the patch set of rte_eth_dev_fw_info_get use the new version function. --- --- examples/ethtool/ethtool-app/ethapp.c | 2 ++ examples/ethtool/lib/rte_ethtool.c | 11 +++++++++++ 2 files changed, 13 insertions(+) diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c index 6aeaa06..192d941 100644 --- a/examples/ethtool/ethtool-app/ethapp.c +++ b/examples/ethtool/ethtool-app/ethapp.c @@ -185,6 +185,8 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params, printf("Port %i driver: %s (ver: %s)\n", id_port, info.driver, info.version ); + printf("bus-info: %s\n", info.bus_info); + printf("firmware-version: %s\n", info.fw_version); } } diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c index 6f0ce84..f62f1d3 100644 --- a/examples/ethtool/lib/rte_ethtool.c +++ b/examples/ethtool/lib/rte_ethtool.c @@ -54,6 +54,11 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); + uint32_t fw_major = 0; + uint32_t fw_minor = 0; + uint32_t etrack = 0; + + rte_eth_dev_fw_info_get(port_id, &fw_major, &fw_minor, NULL, &etrack); memset(&dev_info, 0, sizeof(dev_info)); rte_eth_dev_info_get(port_id, &dev_info); @@ -61,6 +66,12 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo) dev_info.driver_name); snprintf(drvinfo->version, sizeof(drvinfo->version), "%s", rte_version()); + if (strcmp(drvinfo->driver, "net_ixgbe") == 0) + snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), + "0x%08x", etrack); + else + snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), + "%d.%02d 0x%08x", fw_major, fw_minor, etrack); if (dev_info.pci_dev) snprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info), "%04x:%02x:%02x.%x", -- 2.7.4