From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D04541BDF; Sun, 5 Feb 2023 23:55:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7780F40A7D; Sun, 5 Feb 2023 23:55:10 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 116F840041 for ; Sun, 5 Feb 2023 23:55:08 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 4A08A5C01A1; Sun, 5 Feb 2023 17:55:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 05 Feb 2023 17:55:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675637707; x= 1675724107; bh=Kou7qrwqQZvvC7Me+x5ERI/q4EDjuVTo2lgRcVhlcVA=; b=b NgfJSNXqAblerwTwhVqpK1scbRr1ONFGqs1y6kJ1n/ikxpPbq7PVwsOP4UxeCgTx +Msk+ZCkTXU274B793s5eZ7fp3J/+BlnYb/EIj6mao9b1vNEYHTXtBssuYNitSaj VBH+mYBkryGjsMROWWVLBlnRHS/2Rti5c62kb5kU7gX7PXQlgNZhpm0Tb7K16XXT 4vnXSYW2S2/36fU+W4uWWzj8H8vxB/OGNy7pahUzxZNEC1GjjDFWyKx9tzI/vuc/ 7rhyBEb2C7LT4IGZg0S0vV3slqck3awEu02eqkmxd8mJMcBbISh1NjBOTNhoIKZo VQECPXFrmOrrHI0byy1xw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675637707; x= 1675724107; bh=Kou7qrwqQZvvC7Me+x5ERI/q4EDjuVTo2lgRcVhlcVA=; b=h z7Welc+khhNMs3Y+l5daZOPaxRRzLo+X7WrnY/b6MSxVJgqnTCDFJCyx8ISZ2+AC 1iEMhrs7PkYfhK7zQJMjnSfMW3TFIVEtNDXi32zuMqNVGtzSKOnquSA/ey6pekhb 0neLbsoGC91oEKAduL1eMLq/Tb7+aAHjBdIQRDobJqT0MQHS0oazyEiHuSrI22sQ 3W3S1dVu0rq7aoEztgsYDAAxAOFdiuuiJdN7vJgOHx0eFwuVIFm577m0mmXzJ2Yf 0fWuJmGPSuh1spUHTUGBzRKCjOqU11sgLG1poKl5ika4zjGL4Br2ZsbIsOcKXsRc hUQ5y3US+r0W73bUyWSUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeghedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Feb 2023 17:55:06 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , Ciara Power , david.marchand@redhat.com Subject: Re: [PATCH v3 9/9] telemetry: change public API to use 64-bit signed values Date: Sun, 05 Feb 2023 23:55:04 +0100 Message-ID: <14830576.tv2OnDr8pf@thomas> In-Reply-To: <20230112174116.2105237-10-bruce.richardson@intel.com> References: <20221213182730.97065-1-bruce.richardson@intel.com> <20230112174116.2105237-1-bruce.richardson@intel.com> <20230112174116.2105237-10-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/01/2023 18:41, Bruce Richardson: > While the unsigned values added to telemetry dicts/arrays were up to > 64-bits in size, the sized values were only up to 32-bits. We can sized -> signed > standardize the API by having both int and uint functions take 64-bit > values. For ABI compatibility, we use function versioning to ensure > older binaries can still use the older functions taking a 32-bit > parameter. >=20 > Suggested-by: Morten Br=F8rup > Signed-off-by: Bruce Richardson > Acked-by: Morten Br=F8rup > Acked-by: Tyler Retzlaff [...] > --- a/lib/telemetry/version.map > +++ b/lib/telemetry/version.map > +DPDK_24 { > + global: > + > + rte_tel_data_add_array_int; > + rte_tel_data_add_dict_int; > +} DPDK_23; =46or the record, these are the versioned symbols.