From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id 85A59559A
for <dev@dpdk.org>; Fri, 30 Dec 2016 16:26:27 +0100 (CET)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 063657F359
for <dev@dpdk.org>; Fri, 30 Dec 2016 15:26:27 +0000 (UTC)
Received: from dhcp-25-97.bos.redhat.com (unused [10.10.52.171] (may be
forged))
by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
uBUFQLte031288 for <dev@dpdk.org>; Fri, 30 Dec 2016 10:26:26 -0500
From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Date: Fri, 30 Dec 2016 10:26:07 -0500
Message-Id: <1483111580-5397-11-git-send-email-aconole@redhat.com>
In-Reply-To: <1483111580-5397-1-git-send-email-aconole@redhat.com>
References: <1483111580-5397-1-git-send-email-aconole@redhat.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.26]); Fri, 30 Dec 2016 15:26:27 +0000 (UTC)
Subject: [dpdk-dev] [RFC 10/23] eal: Do not panic on log failures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Dec 2016 15:26:27 -0000
When log initialization fails, it's generally because the fopencookie
failed. While this is rare in practice, it could happen. Return
'Operation Not Supported' in errno, and let the caller know this error
occured.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
lib/librte_eal/linuxapp/eal/eal.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index f996047..a23ba17 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -813,8 +813,11 @@ rte_eal_init(int argc, char **argv)
rte_config_init();
- if (rte_eal_log_init(logid, internal_config.syslog_facility) < 0)
- rte_panic("Cannot init logs\n");
+ if (rte_eal_log_init(logid, internal_config.syslog_facility) < 0) {
+ RTE_LOG (ERR, EAL, "Cannot init logs\n");
+ errno = ENOTSUP;
+ return -1;
+ }
if (rte_eal_pci_init() < 0)
rte_panic("Cannot init PCI\n");
--
2.7.4