From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 348352C6D for ; Fri, 30 Dec 2016 16:26:25 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A69BCC05681A for ; Fri, 30 Dec 2016 15:26:24 +0000 (UTC) Received: from dhcp-25-97.bos.redhat.com (unused [10.10.52.171] (may be forged)) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBUFQLtZ031288 for ; Fri, 30 Dec 2016 10:26:24 -0500 From: Aaron Conole To: dev@dpdk.org Date: Fri, 30 Dec 2016 10:26:02 -0500 Message-Id: <1483111580-5397-6-git-send-email-aconole@redhat.com> In-Reply-To: <1483111580-5397-1-git-send-email-aconole@redhat.com> References: <1483111580-5397-1-git-send-email-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 30 Dec 2016 15:26:24 +0000 (UTC) Subject: [dpdk-dev] [RFC 05/23] eal: failure to parse args returns error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2016 15:26:25 -0000 It's possible that the application could take a corrective action here, and either prompt the user for different arguments, or at least perform a better logging. Exiting this early prevents any useful information gathering from the application layer. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index ff70107..1c371f6 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -773,8 +773,11 @@ rte_eal_init(int argc, char **argv) } fctret = eal_parse_args(argc, argv); - if (fctret < 0) - exit(1); + if (fctret < 0) { + RTE_LOG (ERR, EAL, "Invalid 'command line' arguments\n"); + errno = EINVAL; + return -1; + } if (internal_config.no_hugetlbfs == 0 && internal_config.process_type != RTE_PROC_SECONDARY && -- 2.7.4