From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Yonig@radcom.com>
Received: from Exchange2010.radcom.co.il (mail.radcom.com [80.74.109.3])
 by dpdk.org (Postfix) with ESMTP id 53255152A;
 Mon,  9 Jan 2017 17:37:41 +0100 (CET)
Received: from localhost.localdomain (172.16.5.176) by
 Exchange2010.radcom.co.il (172.16.1.125) with Microsoft SMTP Server (TLS) id
 14.3.248.2; Mon, 9 Jan 2017 18:37:40 +0200
From: Yoni Gilad <yonig@radcom.com>
To: <pablo.de.lara.guarch@intel.com>, <deepak.k.jain@intel.com>
CC: <dev@dpdk.org>, Yoni Gilad <yonig@radcom.com>, <stable@dpdk.org>
Date: Mon, 9 Jan 2017 16:37:33 +0000
Message-ID: <1483979853-16386-1-git-send-email-yonig@radcom.com>
X-Mailer: git-send-email 1.7.1
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [172.16.5.176]
Subject: [dpdk-dev] [PATCH] tools: fix active interface detection in
	dpdk-devbind.py
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2017 16:37:41 -0000

When adding crypto devices, the "Active" and "Ssh_if" attributes of
existing network devices were reset. This causes the follwing issues:

- Network interfaces aren't marked as "*Active*" in the --status output.
- Active network interfaces can be unbound without the --force option,
  causing loss of network connection.

The reset was caused by the call to devices[d].update in
get_crypto_details.

This patch prevents the update on non-crypto devices.

Fixes: cb4a1d1 ("tools: bind crypto devices")

CC: stable@dpdk.org

Signed-off-by: Yoni Gilad <yonig@radcom.com>
---
 usertools/dpdk-devbind.py |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index e057b87..1b9c651 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -328,6 +328,9 @@ def get_crypto_details():
 
     # based on the basic info, get extended text details
     for d in devices.keys():
+        if devices[d]["Class"][0:2] != CRYPTO_BASE_CLASS:
+            continue
+
         # get additional info and add it to existing data
         devices[d] = devices[d].copy()
         devices[d].update(get_pci_device_details(d).items())
-- 
1.7.1