From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA586A04DB; Fri, 16 Oct 2020 18:41:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C5EE34EE; Fri, 16 Oct 2020 18:41:05 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 8F27F4C6C for ; Fri, 16 Oct 2020 18:41:03 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 46C8BFC2; Fri, 16 Oct 2020 12:05:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 16 Oct 2020 12:05:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= PJdkhDQFgVmaON5f4iVRQ9rkz+1WArG890s0Hzq7FhQ=; b=MXkMDvWFSSF+Cnxs H85NS49YgctTGvejV37uYygr+0d7sF41KDs5u1V18jjNNBtpnKb7wRhsvP5tUsVh q1QWH1XBgh4r6oucrkSyjj13PW7obDHRcaMg+V09Eli2dXTltNBVSPkkfs94nmeY vyyRFTACNbEeatZRBtFZJAb4kfMfIGoWFEdHabeypWFCuq4Qe8UINTyqi0MMdGqi mHQ46nRbKKMcANJM1Ii4gzPBwEo9hFcagRmFbn9jcLDkb667jJCSx7XsW2UzdcW3 OST7baayzt5auYq9TSrxY9WV3sBqVZ1XsXwoRx4WKrVImXo6HBX3y8nnP3LBGeVG wl8teA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PJdkhDQFgVmaON5f4iVRQ9rkz+1WArG890s0Hzq7F hQ=; b=XWTEIH8bR7zLklvx82vr+Py002MkiwvvGHUJsBN7tYkuHB4sufRuvJiL3 F5J9HAFW3a6ZeFGJ1HIB8aYlfBYvfdl6bfv3t2fsVmFO3N0B0X+BQ4jBtSFbCP3g VJNGH+8MeYvu8DKCGwUKww47pru4cIoBYHUqlnajm7bUQfHiTIASa+1CgocRHYc1 6KX4isNTFi3SOnkt3fjh3RNL+Rjxz+uKY5wHBhilKO82aDrG8oYc5RIz/9EtSGFm ITxtCcFUKKQP7F6W/TevI9BqLvXZGwJkJzt7kg90aSjCahl4Ob0+18EDllnjRmaQ ZgVEKLZcPDao5MbpE3nhGZEGRdLYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrieehgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B23F2328006B; Fri, 16 Oct 2020 12:05:04 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Viacheslav Ovsiienko , dev@dpdk.org, stephen@networkplumber.org, olivier.matz@6wind.com, jerinjacobk@gmail.com, maxime.coquelin@redhat.com, david.marchand@redhat.com, arybchenko@solarflare.com Date: Fri, 16 Oct 2020 18:05:01 +0200 Message-ID: <14842522.L6QGMzUDIC@thomas> In-Reply-To: <512ad0ea-827a-3767-6d43-1d5100b25202@intel.com> References: <1602855582-15847-2-git-send-email-viacheslavo@nvidia.com> <512ad0ea-827a-3767-6d43-1d5100b25202@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 1/6] ethdev: introduce Rx buffer split X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/10/2020 17:47, Ferruh Yigit: > On 10/16/2020 2:39 PM, Viacheslav Ovsiienko wrote: > > +__rte_experimental > > +struct rte_eth_rxseg_split { > > + struct rte_mempool *mp; /**< Memory pool to allocate segment from. */ > > + uint16_t length; /**< Segment data length, configures split point. */ > > + uint16_t offset; /**< Data offset from beginning of mbuf data buffer. */ > > + uint32_t reserved; /**< Reserved field. */ > > +}; > > + > > +/** > > + * A common structure used to describe Rx packet segment properties. > > + */ > > +__rte_experimental > > +union rte_eth_rxseg { > > + /* The settings for buffer split offload. */ > > + struct rte_eth_rxseg_split split; > > + /* The other features settings should be added here. */ > > +}; > > Is the '__rte_experimental' on the data structs do anything other than > documentation? > > icc is complaining about them [1], if they are only for documenation, would it > be OK to move it to the comment and remove the '__rte_experimental' tag? > > [1] > ../lib/librte_ethdev/rte_ethdev.h(1005): error #2651: attribute does not apply > to any entity > __rte_experimental > ^ Yes should be a comment.