From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A2CEA0032; Fri, 1 Oct 2021 15:32:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFEED4067A; Fri, 1 Oct 2021 15:32:52 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id D7F8A40040 for ; Fri, 1 Oct 2021 15:32:50 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 61FB45C00E5; Fri, 1 Oct 2021 09:32:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 01 Oct 2021 09:32:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= LGJVjcmDRHcLwh/OK+Dl0I6cPe3ACMXQ5UwIeVmrecg=; b=CjL7ZC3OlibMl7Vp QiKQ+6o37j6xTJBZD24WgXrqZgPJmCa+6tI4zNDZWGDae6BPu5BFDt4POlmYoCKK XGY4gZ/qHhg8ObU+Zwn0E7kfu6uZwCDCYlJLiT3bhwtLBqhKkYR/3PG1QfUH+wOi fHv44tZ7c0B9SjN5CcG0ovRn94umicCfE8UtIsD5KOSybGTBsfzqc1IF28M2fzt6 n3YlG+YdFXg5SN8xI3bWCxMFZgZWa9v5P35MabNg8lg4sW4G5bkb2rZ/Ti1+VxPN OVR3qevrrsS4QP6+VPe0bbvcS7KynkOkDObb0zdDkXTm19sHYf/eNGhRh041yF3X b/sVfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=LGJVjcmDRHcLwh/OK+Dl0I6cPe3ACMXQ5UwIeVmre cg=; b=Z5ngWXEDnEx0UE9nc32sLAwmHWKc/Q532/R2f2aylrX8C1peZhVnOK9YZ A3JtV1Wc7s37/uHwi/UrIKM1aOj80EA+FyLM7/SGJbdYiwDUIvieMimPCPKsdRG/ 6+5gyMVWgNgylaguomNupdfc1Y8XoPTv45JFDyqmrTrDgeCKS52qOQN+hqzpsWYy 0ursd4EbHpT1DYixTYK1CRY34otxoApg/eCXbtr6OdEi6Sb3HBN9aO+IxF9YoWyy Bm26mG4q0imH+rEe+bQKUPjteezsF4HzEpxa0Q8Pn1xUc9+U5r8FMvu0u8PW36GS V8Ot3LJj3RxNusvypfU/hCVVj15Rw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekiedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Oct 2021 09:32:47 -0400 (EDT) From: Thomas Monjalon To: Kevin Traynor Cc: dev@dpdk.org, mdr@ashroe.eu Date: Fri, 01 Oct 2021 15:32:46 +0200 Message-ID: <148465414.l5tiXSRtO0@thomas> In-Reply-To: References: <20210709151938.701895-1-ktraynor@redhat.com> <2185865.z788A1Ek0O@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/07/2021 22:24, Kevin Traynor: > On 22/07/2021 20:46, Thomas Monjalon wrote: > > 09/07/2021 17:19, Kevin Traynor: > >> rte_stats_bitrate_reg() API states it returns 'Zero on success'. > >> > >> However, the implementation directly returns the return of > >> rte_metrics_reg_names() which may be zero or positive on success, > >> with a positive value also indicating the index. > >> > >> The user of rte_stats_bitrate_reg() should not care about the > >> index as it is stored in the opaque rte_stats_bitrates struct. > >> > >> Change the implementation of rte_stats_bitrate_reg() to match > >> the API description by always returning zero on success. > >> > >> Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > >> > >> Signed-off-by: Kevin Traynor > > > > Does it require a deprecation notice? > > I'm not certain, but I don't think it does. It is fixing the > implementation so it behaves as the API is documented to. > > > At least I suggest a release note in API section. > > > > What is the target for this series? 21.11? > > > > No urgency, 21.11 is fine for this set. Applied, thanks.