DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/armv8: fix HMAC supported digest sizes
@ 2018-05-29 10:45 Anoob Joseph
  2018-05-29 11:28 ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2018-05-29 10:45 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: Anoob Joseph, Akhil Goyal, Narayana Prasad, Nitin Saxena,
	Sachin Saxena, dev, stable

For HMAC algorithms (SHAx-HMAC), the supported digest sizes are not a
fixed value, but a range between 1 and the maximum digest size for those
algorithms.

Fixes: 0f89def76127 ("crypto/armv8: fix HMAC supported key sizes")
Cc: stable@dpdk.org

Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
Signed-off-by: Sachin Saxena <sachin.saxena@nxp.com>
---
 drivers/crypto/armv8/rte_armv8_pmd_ops.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/armv8/rte_armv8_pmd_ops.c b/drivers/crypto/armv8/rte_armv8_pmd_ops.c
index 3817ad7..c64aef0 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd_ops.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd_ops.c
@@ -27,9 +27,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 1
 					},
 					.digest_size = {
-						.min = 20,
+						.min = 1,
 						.max = 20,
-						.increment = 0
+						.increment = 1
 					},
 					.iv_size = { 0 }
 				}, }
@@ -48,9 +48,9 @@ static const struct rte_cryptodev_capabilities
 						.increment = 1
 					},
 					.digest_size = {
-						.min = 32,
+						.min = 1,
 						.max = 32,
-						.increment = 0
+						.increment = 1
 					},
 					.iv_size = { 0 }
 				}, }
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/armv8: fix HMAC supported digest sizes
  2018-05-29 10:45 [dpdk-dev] [PATCH] crypto/armv8: fix HMAC supported digest sizes Anoob Joseph
@ 2018-05-29 11:28 ` Akhil Goyal
  2018-05-30 19:21   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2018-05-29 11:28 UTC (permalink / raw)
  To: Anoob Joseph, Jerin Jacob
  Cc: Akhil Goyal, Narayana Prasad, Nitin Saxena, Sachin Saxena, dev, stable

On 5/29/2018 4:15 PM, Anoob Joseph wrote:
> For HMAC algorithms (SHAx-HMAC), the supported digest sizes are not a
> fixed value, but a range between 1 and the maximum digest size for those
> algorithms.
>
> Fixes: 0f89def76127 ("crypto/armv8: fix HMAC supported key sizes")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> Signed-off-by: Sachin Saxena <sachin.saxena@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/armv8: fix HMAC supported digest sizes
  2018-05-29 11:28 ` Akhil Goyal
@ 2018-05-30 19:21   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-05-30 19:21 UTC (permalink / raw)
  To: Anoob Joseph, Sachin Saxena
  Cc: stable, Akhil Goyal, Jerin Jacob, Narayana Prasad, Nitin Saxena, dev

29/05/2018 13:28, Akhil Goyal:
> On 5/29/2018 4:15 PM, Anoob Joseph wrote:
> > For HMAC algorithms (SHAx-HMAC), the supported digest sizes are not a
> > fixed value, but a range between 1 and the maximum digest size for those
> > algorithms.
> >
> > Fixes: 0f89def76127 ("crypto/armv8: fix HMAC supported key sizes")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> > Signed-off-by: Sachin Saxena <sachin.saxena@nxp.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-30 19:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-29 10:45 [dpdk-dev] [PATCH] crypto/armv8: fix HMAC supported digest sizes Anoob Joseph
2018-05-29 11:28 ` Akhil Goyal
2018-05-30 19:21   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).