* [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length
@ 2017-01-27 13:16 Pablo de Lara
2017-01-27 13:15 ` De Lara Guarch, Pablo
2017-01-31 16:44 ` Declan Doherty
0 siblings, 2 replies; 4+ messages in thread
From: Pablo de Lara @ 2017-01-27 13:16 UTC (permalink / raw)
To: adrien.mazarguil, jingjing.wu; +Cc: dev, Pablo de Lara
AESNI MB now supports authentication only operations,
but the array containing all the possible digest lengths
was not updated to reflect the new algorithm NULL_HASH,
causing an "Out-of-bounds access".
Coverity issue: 140977
Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation functionality")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
index 5f125b2..eb4b2ad 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
@@ -88,6 +88,7 @@ static const unsigned auth_truncated_digest_byte_lengths[] = {
[SHA_384] = 24,
[SHA_512] = 32,
[AES_XCBC] = 12,
+ [NULL_HASH] = 0
};
/**
@@ -111,6 +112,7 @@ static const unsigned auth_digest_byte_lengths[] = {
[SHA_384] = 48,
[SHA_512] = 64,
[AES_XCBC] = 16,
+ [NULL_HASH] = 0
};
/**
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length
2017-01-27 13:16 [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length Pablo de Lara
@ 2017-01-27 13:15 ` De Lara Guarch, Pablo
2017-01-31 16:44 ` Declan Doherty
1 sibling, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2017-01-27 13:15 UTC (permalink / raw)
To: Doherty, Declan; +Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, January 27, 2017 1:16 PM
> To: adrien.mazarguil@6wind.com; Wu, Jingjing
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH] crypto/aesni_mb: add missing digest length
>
> AESNI MB now supports authentication only operations,
> but the array containing all the possible digest lengths
> was not updated to reflect the new algorithm NULL_HASH,
> causing an "Out-of-bounds access".
>
> Coverity issue: 140977
> Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation
> functionality")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> index 5f125b2..eb4b2ad 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> @@ -88,6 +88,7 @@ static const unsigned
> auth_truncated_digest_byte_lengths[] = {
> [SHA_384] = 24,
> [SHA_512] = 32,
> [AES_XCBC] = 12,
> + [NULL_HASH] = 0
> };
>
> /**
> @@ -111,6 +112,7 @@ static const unsigned auth_digest_byte_lengths[] =
> {
> [SHA_384] = 48,
> [SHA_512] = 64,
> [AES_XCBC] = 16,
> + [NULL_HASH] = 0
> };
>
> /**
> --
> 2.7.4
Wrong maintainer, Sending to right one now. Sorry about that.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length
2017-01-27 13:16 [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length Pablo de Lara
2017-01-27 13:15 ` De Lara Guarch, Pablo
@ 2017-01-31 16:44 ` Declan Doherty
2017-02-09 22:19 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 4+ messages in thread
From: Declan Doherty @ 2017-01-31 16:44 UTC (permalink / raw)
To: dev; +Cc: Pablo de Lara
On 27/01/17 13:16, Pablo de Lara wrote:
> AESNI MB now supports authentication only operations,
> but the array containing all the possible digest lengths
> was not updated to reflect the new algorithm NULL_HASH,
> causing an "Out-of-bounds access".
>
> Coverity issue: 140977
> Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation functionality")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
....
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length
2017-01-31 16:44 ` Declan Doherty
@ 2017-02-09 22:19 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2017-02-09 22:19 UTC (permalink / raw)
To: Doherty, Declan, dev
> -----Original Message-----
> From: Doherty, Declan
> Sent: Tuesday, January 31, 2017 4:44 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest
> length
>
> On 27/01/17 13:16, Pablo de Lara wrote:
> > AESNI MB now supports authentication only operations,
> > but the array containing all the possible digest lengths
> > was not updated to reflect the new algorithm NULL_HASH,
> > causing an "Out-of-bounds access".
> >
> > Coverity issue: 140977
> > Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation
> functionality")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> ....
> >
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied to dpdk-next-crypto.
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-09 22:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-27 13:16 [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length Pablo de Lara
2017-01-27 13:15 ` De Lara Guarch, Pablo
2017-01-31 16:44 ` Declan Doherty
2017-02-09 22:19 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).