From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A3DEA04E7; Mon, 2 Nov 2020 17:10:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2E175AB9; Mon, 2 Nov 2020 17:10:50 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 03E69592B for ; Mon, 2 Nov 2020 17:10:47 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 9DC105807E4; Mon, 2 Nov 2020 11:10:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 02 Nov 2020 11:10:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= FXoQgoyvSyKa2S2s3ER9mZYh7izEjSpdP4xQu/Slsx0=; b=vNOhOQhGNnSIMMM8 /iyFVJO0PLkaFUPmzjLr4Kq78B7BlIweYaSzCYiuv2Ls49sivJ+KseJ24WWR4lLl rtuBt/MAuA688jyUnC4ncG8BflH0kBg8cslyPgeODsvM7nnP+qWLx5vIIcV83tMp u/3dUBkb85SJsg4MLhgG6KNlltbqpjecPMUlYxRguq9XZmt3IUiOs5qttFJ/BopZ 9jl+c7iIqsM1L6nzrka3KDxWLDLwAAwsHktHgZ3NgHvd7yocHoDrKBvY1vVQBLBM 20fHyA747G9az7Ixh1MtPoMujATa2PMESgR8DI1NwtHzQgyJapTMZ2eQ5gdTT+pz zWEF+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FXoQgoyvSyKa2S2s3ER9mZYh7izEjSpdP4xQu/Sls x0=; b=HFobL8h8Hc5Af3s+I1UKY3eUkeUUWZ/SkTeGJXbBIm7d6IymR+nE0LElf u/y+IoZcH1QexlPS9Qk3NZvBT458IafWizbowNO+XqmOATSAA5nz6jvhL/w6ArS+ O+TF7J0zGT5exVh3l3AsKdnXs9ZKez5NvvqORBsc9G8S9OLS58VxxYdMfsqgzVrv al2ebQqEt4suo5xNCZnh+U8k97j158Y/F3VFzgHLrizBBmLvAv+ek7qXl2JAyOJf z/1w7ZP0fMzRgY04ofVLNW2Mo5ynwvQPgLvWJmCXrTazBnFYn8GIOs/+y+Q7Nwfa cMmdi0KFOQm/LNx4/Xc4X5vQJcALA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtuddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 371BA328005D; Mon, 2 Nov 2020 11:10:44 -0500 (EST) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com, Shepard Siegel , Ed Czeck , John Miller Date: Mon, 02 Nov 2020 17:10:42 +0100 Message-ID: <14856073.svBvLiUHb5@thomas> In-Reply-To: <20201102153231.GY1898@platinum> References: <20201029092751.3837177-1-thomas@monjalon.net> <20201101180626.2198868-6-thomas@monjalon.net> <20201102153231.GY1898@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 05/14] net/ark: switch timestamp to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2020 16:32, Olivier Matz: > On Sun, Nov 01, 2020 at 07:06:17PM +0100, Thomas Monjalon wrote: > > --- a/drivers/net/ark/ark_ethdev_rx.c > > +++ b/drivers/net/ark/ark_ethdev_rx.c > > @@ -15,6 +15,9 @@ > > #define ARK_RX_META_OFFSET (RTE_PKTMBUF_HEADROOM - ARK_RX_META_SIZE) > > #define ARK_RX_MAX_NOCHAIN (RTE_MBUF_DEFAULT_DATAROOM) > > > > +extern uint64_t ark_timestamp_rx_dynflag; > > +extern int ark_timestamp_dynfield_offset; > > + > > Wouldn't it be better in a .h ? > Maybe ark_ethdev_rx.h Yes it would allow type checking on compilation.