From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] mk: move libs that don't dependent PMD libs out of whole archive
Date: Tue, 31 Jan 2017 14:59:18 +0100 [thread overview]
Message-ID: <1485894798.W7CazHdbJ2@xps13> (raw)
In-Reply-To: <20170131115950.25660-1-ferruh.yigit@intel.com>
2017-01-31 11:59, Ferruh Yigit:
> During app build with static library, some libraries wrapped with
> --whole-archive compiler flag.
>
> Wrapped libraries are mainly PMD libraries, this is required because PMD
> APIs not directly called but run through callbacks registered via
> constructor functions.
>
> Also some set of libraries, depends to the PMD libraries needs this,
> because of same reason.
All the libraries used by a plugin (any driver) must be in --whole-archive
to ensure that every symbols will be available for the plugin.
This should be explained in this patch (verbatim copy allowed).
> But other libraries can be out of this flag, and this saves some size in
> final binary.
[...]
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_EFD) += -lrte_efd
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE) += -lrte_cfgfile
> +
> _LDLIBS-y += --whole-archive
Yes we can move these libraries out of --whole-archive as they are not
used by any driver.
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
next prev parent reply other threads:[~2017-01-31 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 11:59 Ferruh Yigit
2017-01-31 11:59 ` [dpdk-dev] [PATCH 2/2] mk: move crypto scheduler library Ferruh Yigit
2017-01-31 14:10 ` Thomas Monjalon
2017-01-31 14:20 ` Ferruh Yigit
2017-01-31 13:59 ` Thomas Monjalon [this message]
2017-01-31 15:01 ` [dpdk-dev] [PATCH v2] mk: move libs that don't dependent PMD libs out of whole archive Ferruh Yigit
2017-02-09 21:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485894798.W7CazHdbJ2@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).