From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id B1CB611D9 for ; Tue, 31 Jan 2017 14:59:20 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id r141so80622515wmg.1 for ; Tue, 31 Jan 2017 05:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=w/3ynGtw7vHSARYTT2zPQCLMlbpfoCwqJ6ZXYDj+2ls=; b=qp5lyJnBWMKt0zPuaz0/kCxtiYXQZi0Wwjiy9WkNYo56A2eu92ziiFvkISZ2esX46V rSU8tUnk8PtyHxSXQSpcm+/GpNXCFuAZXxso2OMEueQnAGIHWSzE9hmuo44XE6RhqU4Y b0WiWZ+EXDgtuJCsFEtAScd3bIfmIrLJz8CBhp81tNxZUk6/KbI09EsNHEIsaqGM3lk+ y1cIU95QjlJuQQCCUvhFzBtpBbDS09W/W8XnEMn9lDYSp/fVu1xfoaxncpPG2xqZ9r7d 2ObKWjP2LMrGQPiN6mvTvEpfdODswdkDB8W6b3elX2qFtGvAnhQQpfnF+Ws5RxqJGgVE dWTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=w/3ynGtw7vHSARYTT2zPQCLMlbpfoCwqJ6ZXYDj+2ls=; b=taped4ZzuiQfP8LfBrDOMYM/NKWA4Tb+ohsOlwwUOg01aFWi5cw+3VJeeXNxOwcp9l uHiPXEgqFJoq6+odvf4lx/182eynH0s7VqIVvhtgWsjrU0c1IOdvc1y1sdTyeNnyII5i PkfCmGbP31gLt+xesQOVmWApDTJstGrqZnaiirtCwvj4b3fzN0byQZsDf2sE2QI28vqr icumik3Ndx7PYfzYQL33Fo/czlrlT9jxMmAshy83QN6aRIqOjhJOIWzJaObaaQpr3AlA zjwFn5D92RcR8GHwymFXKzhndQ1WZfmGrimRQbZcYs9OOrbnL8OzP/ES+r6l54BOyhfa Ao8g== X-Gm-Message-State: AIkVDXL+RN01tbYn6ihOtDOzmiOPEeU7G/Cy47z4lNCVR6h5ECKldxEPhUAuoYCGfgWxVROu X-Received: by 10.28.26.7 with SMTP id a7mr18004036wma.21.1485871160427; Tue, 31 Jan 2017 05:59:20 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i29sm3172264wrc.25.2017.01.31.05.59.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jan 2017 05:59:19 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Cc: Pablo de Lara , dev@dpdk.org Date: Tue, 31 Jan 2017 14:59:18 +0100 Message-ID: <1485894798.W7CazHdbJ2@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170131115950.25660-1-ferruh.yigit@intel.com> References: <20170131115950.25660-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] mk: move libs that don't dependent PMD libs out of whole archive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2017 13:59:20 -0000 2017-01-31 11:59, Ferruh Yigit: > During app build with static library, some libraries wrapped with > --whole-archive compiler flag. > > Wrapped libraries are mainly PMD libraries, this is required because PMD > APIs not directly called but run through callbacks registered via > constructor functions. > > Also some set of libraries, depends to the PMD libraries needs this, > because of same reason. All the libraries used by a plugin (any driver) must be in --whole-archive to ensure that every symbols will be available for the plugin. This should be explained in this patch (verbatim copy allowed). > But other libraries can be out of this flag, and this saves some size in > final binary. [...] > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > +_LDLIBS-$(CONFIG_RTE_LIBRTE_EFD) += -lrte_efd > +_LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE) += -lrte_cfgfile > + > _LDLIBS-y += --whole-archive Yes we can move these libraries out of --whole-archive as they are not used by any driver. Acked-by: Thomas Monjalon