From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 2400B14EC for <dev@dpdk.org>; Mon, 6 Feb 2017 14:29:43 +0100 (CET) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 5615624A17; Mon, 6 Feb 2017 14:29:38 +0100 (CET) From: Olivier Matz <olivier.matz@6wind.com> To: dev@dpdk.org, david.marchand@6wind.com Date: Mon, 6 Feb 2017 14:29:08 +0100 Message-Id: <1486387756-16865-1-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.8.1 Subject: [dpdk-dev] [RFC 0/8] eal: dynamic logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 06 Feb 2017 13:29:43 -0000 The objective of this RFC patchset is to introduce a framework to support dynamic log types in EAL. It also provides one example of use (in i40e). Features: - log types are identified by a string - at registration, a uniq identifier is associated to a log type - each log type can have its level changed dynamically - extend command line parameters to set the log level of a specific type, or logs matching a regular expression - keep compat with other legacy types (eal, malloc, ring, user*, etc... keep their hardcoded log type value) At the end, when, we can expect that all non-dataplane logs are moved to be dynamic, so we can enable/disable them at runtime, without recompiling. Many debug options can probably be removed from configuration: $ git grep DEBUG config/common_base | wc -l 89 Comments are welcome! Olivier Matz (8): eal: support dynamic log types eal: dump registered log types eal: change several log levels matching a regexp eal: change specific log levels at startup eal: deprecate log functions app/test: new command to dump log types app/testpmd: new command to dump log types net/i40e: use dynamic log type for control logs app/test-pmd/cmdline.c | 5 +- app/test/commands.c | 4 +- app/test/test_logs.c | 12 +- doc/guides/contributing/coding_style.rst | 30 ++-- drivers/net/i40e/i40e_ethdev.c | 18 +- drivers/net/i40e/i40e_fdir.c | 4 - drivers/net/i40e/i40e_logs.h | 17 +- examples/quota_watermark/qw/main.c | 2 +- examples/quota_watermark/qwctl/qwctl.c | 2 +- lib/librte_eal/bsdapp/eal/eal.c | 4 +- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 6 + lib/librte_eal/common/eal_common_log.c | 219 +++++++++++++++++++++++- lib/librte_eal/common/eal_common_options.c | 48 ++++-- lib/librte_eal/common/include/rte_log.h | 76 +++++++- lib/librte_eal/linuxapp/eal/eal.c | 4 +- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 6 + 16 files changed, 394 insertions(+), 63 deletions(-) -- 2.8.1