From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 1F5F111C5 for ; Mon, 23 Mar 2015 12:28:15 +0100 (CET) Received: by wegp1 with SMTP id p1so135056227weg.1 for ; Mon, 23 Mar 2015 04:28:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=O3gPp6W6Pm4G/PtG1MTELJhQaDfE9vsqrsNhc2hlU+s=; b=AaA09MlpUtCWm2pJyDPZP6A42sUGmzCZsTodup7+6TdxZpJVEiqgXAjgWX6QjacVV8 WyPZRDExpyMEw3IUSi8xoGW+9XiJq3js5lADzpqJRCqokMkjc+M1ak+7mfF5CT5dShjt shVa+RvDeURWoLRRUhdl9STanR/1yt/tUT4RC/r9K0GWC6t5xkGcoaH96grgkTlCaOU3 IrlCkZj4ZXvMjFQQROv0ne9ebaTaDNc5LtzuFK4g9tRJELdKfizbKw1V0uRBpSv1ktLg E7rMMQe2jSsyTdNnQdcNPg2sWuemy88F8srDZ0HIcw+SdFj/3ALbXoO6TOWIk4szRGHV tOlQ== X-Gm-Message-State: ALoCoQkvY7o4em9EbzGI0z5+EiUl8qpeyRYUNr0rwuLuK6TcG3aWjn+Bnd/kyaOc6qc5/QhD654w X-Received: by 10.180.9.47 with SMTP id w15mr15252248wia.13.1427110095035; Mon, 23 Mar 2015 04:28:15 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dz6sm10809067wib.0.2015.03.23.04.28.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 04:28:14 -0700 (PDT) From: Thomas Monjalon To: helin.zhang@intel.com Date: Mon, 23 Mar 2015 12:27:31 +0100 Message-ID: <14866342.VnQ1r1AyAo@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1426274503-372191-1-git-send-email-agartrell@fb.com> References: <1426274503-372191-1-git-send-email-agartrell@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, kernel-team@fb.com Subject: Re: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 11:28:15 -0000 Helin, any comment about this trivial patch? 2015-03-13 12:21, Alex Gartrell: > I couldn't figure out why this #ifdef existed so I looked around upstream > and it's not there. It seems to build just fine without it. > > Signed-off-by: Alex Gartrell > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > index a582f52..d58e1f3 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > @@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct igb_ring *ring) > return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1; > } > > -#ifdef CONFIG_BQL > static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_ring) > { > return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index); > } > -#endif /* CONFIG_BQL */ > > // #ifdef EXT_THERMAL_SENSOR_SUPPORT > // #ifdef IGB_PROCFS >