From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 012F0FE5 for ; Wed, 22 Feb 2017 14:24:54 +0100 (CET) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1cgWuc-00016j-NR; Wed, 22 Feb 2017 13:24:54 +0000 From: Christian Ehrhardt To: dev Cc: Christian Ehrhardt , "cjcollier @ linuxfoundation . org" , ricardo.salveti@linaro.org, Luca Boccassi Date: Wed, 22 Feb 2017 14:24:52 +0100 Message-Id: <1487769892-17042-1-git-send-email-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH] mk: Provide option to set Major ABI version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 13:24:55 -0000 Downstreams might want to provide different DPDK releases at the same time to support multiple consumers of DPDK linked against older and newer sonames. Also due to the interdependencies that DPDK libraries can have applications might end up with an executable space in which multiple versions of a library are mapped by ld.so. Think of LibA that got an ABI bump and LibB that did not get an ABI bump but is depending on LibA. Application \-> LibA.old \-> LibB.new -> LibA.new That is a conflict which can be avoided by setting CONFIG_RTE_MAJOR_ABI. If set CONFIG_RTE_MAJOR_ABI overwrites any LIBABIVER value. An example might be ``CONFIG_RTE_MAJOR_ABI=16.11`` which will make all libraries librte.so.16.11 instead of librte.so.. We need to cut arbitrary long stings after the .so now and this would work for any ABI version in LIBABIVER: $(Q)ln -s -f $< $(patsubst %.$(LIBABIVER),%,$@) But using the following instead additionally allows to simplify the Make File for the CONFIG_RTE_NEXT_ABI case. $(Q)ln -s -f $< $(shell echo $@ | sed 's/\.so.*/.so/') Signed-off-by: Christian Ehrhardt --- config/common_base | 5 +++++ doc/guides/contributing/versioning.rst | 25 +++++++++++++++++++++++++ mk/rte.lib.mk | 12 +++++++----- 3 files changed, 37 insertions(+), 5 deletions(-) diff --git a/config/common_base b/config/common_base index aeee13e..37aa1e1 100644 --- a/config/common_base +++ b/config/common_base @@ -75,6 +75,11 @@ CONFIG_RTE_BUILD_SHARED_LIB=n CONFIG_RTE_NEXT_ABI=y # +# Major ABI to overwrite library specific LIBABIVER +# +CONFIG_RTE_MAJOR_ABI= + +# # Machine's cache line size # CONFIG_RTE_CACHE_LINE_SIZE=64 diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributing/versioning.rst index fbc44a7..8aaf370 100644 --- a/doc/guides/contributing/versioning.rst +++ b/doc/guides/contributing/versioning.rst @@ -133,6 +133,31 @@ The macros exported are: fully qualified function ``p``, so that if a symbol becomes versioned, it can still be mapped back to the public symbol name. +Setting a Major ABI version +--------------------------- + +Downstreams might want to provide different DPDK releases at the same time to +support multiple consumers of DPDK linked against older and newer sonames. + +Also due to the interdependencies that DPDK libraries can have applications +might end up with an executable space in which multiple versions of a library +are mapped by ld.so. + +Think of LibA that got an ABI bump and LibB that did not get an ABI bump but is +depending on LibA. + +.. note:: + + Application + \-> LibA.old + \-> LibB.new -> LibA.new + +That is a conflict which can be avoided by setting ``CONFIG_RTE_MAJOR_ABI``. +If set, the value of ``CONFIG_RTE_MAJOR_ABI`` overwrites all - otherwise per +library - versions defined in the libraries ``LIBABIVER``. +An example might be ``CONFIG_RTE_MAJOR_ABI=16.11`` which will make all libraries +``librte.so.16.11`` instead of ``librte.so.``. + Examples of ABI Macro use ------------------------- diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 33a5f5a..06046c2 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -40,6 +40,12 @@ EXTLIB_BUILD ?= n # VPATH contains at least SRCDIR VPATH += $(SRCDIR) +ifneq ($(CONFIG_RTE_MAJOR_ABI),) +ifneq ($(LIBABIVER),) +LIBABIVER := $(CONFIG_RTE_MAJOR_ABI) +endif +endif + ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) LIB := $(patsubst %.a,%.so.$(LIBABIVER),$(LIB)) ifeq ($(EXTLIB_BUILD),n) @@ -156,11 +162,7 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB) @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) -ifeq ($(CONFIG_RTE_NEXT_ABI)$(EXTLIB_BUILD),yn) - $(Q)ln -s -f $< $(basename $(basename $@)) -else - $(Q)ln -s -f $< $(basename $@) -endif + $(Q)ln -s -f $< $(shell echo $@ | sed 's/\.so.*/.so/') endif # -- 2.7.4