From: Shahaf Shuler <shahafs@mellanox.com>
To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
thomas.monjalon@6wind.com, jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 3/4] app/testpmd: add TSO disable to test options
Date: Wed, 22 Feb 2017 18:09:59 +0200 [thread overview]
Message-ID: <1487779800-46491-4-git-send-email-shahafs@mellanox.com> (raw)
In-Reply-To: <1487779800-46491-1-git-send-email-shahafs@mellanox.com>
Add the option to globaly disable hardware TSO offload
from the command line.
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
app/test-pmd/parameters.c | 9 ++++++++-
doc/guides/testpmd_app_ug/run_app.rst | 4 ++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 28db8cd..7cd88bc 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -196,6 +196,7 @@
" or total packet length.\n");
printf(" --disable-link-check: disable check on link status when "
"starting/stopping ports.\n");
+ printf(" --disable-tso: disable hardware TCP segmentation offload.\n");
}
#ifdef RTE_LIBRTE_CMDLINE
@@ -561,6 +562,7 @@
{ "no-flush-rx", 0, 0, 0 },
{ "txpkts", 1, 0, 0 },
{ "disable-link-check", 0, 0, 0 },
+ { "disable-tso", 0, 0, 0 },
{ 0, 0, 0, 0 },
};
@@ -978,7 +980,12 @@
no_flush_rx = 1;
if (!strcmp(lgopts[opt_idx].name, "disable-link-check"))
no_link_check = 1;
-
+ if (!strcmp(lgopts[opt_idx].name, "disable-tso")) {
+ if (txq_flags < 0)
+ txq_flags = ETH_TXQ_FLAGS_NOTSOOFFL;
+ else
+ txq_flags |= ETH_TXQ_FLAGS_NOTSOOFFL;
+ }
break;
case 'h':
usage(argv[0]);
diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index 38a4025..58417ea 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -460,3 +460,7 @@ The commandline options are:
* ``--disable-link-check``
Disable check on link status when starting/stopping ports.
+
+* ``--disable-tso``
+
+ Disable hardware TCP segmentation offload.
--
1.8.3.1
next prev parent reply other threads:[~2017-02-22 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 16:09 [dpdk-dev] [PATCH 0/4] net/mlx5 add TSO support Shahaf Shuler
2017-02-22 16:09 ` [dpdk-dev] [PATCH 1/4] ethdev: add Tx offload limitations Shahaf Shuler
2017-02-22 16:09 ` [dpdk-dev] [PATCH 2/4] ethdev: add TSO disable flag Shahaf Shuler
2017-02-22 16:09 ` Shahaf Shuler [this message]
2017-02-22 16:10 ` [dpdk-dev] [PATCH 4/4] net/mlx5: add hardware TSO support Shahaf Shuler
2017-03-01 11:11 ` [dpdk-dev] [PATCH v2 0/1] net/mlx5: add " Shahaf Shuler
2017-03-01 11:11 ` [dpdk-dev] [PATCH v2 1/1] net/mlx5: add hardware " Shahaf Shuler
2017-03-01 14:33 ` Nélio Laranjeiro
2017-03-02 9:01 ` [dpdk-dev] [PATCH v3 " Shahaf Shuler
2017-03-02 9:15 ` Nélio Laranjeiro
2017-03-06 9:32 ` Ferruh Yigit
2017-03-06 8:50 ` Ferruh Yigit
2017-03-06 9:31 ` Ferruh Yigit
2017-03-06 11:03 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487779800-46491-4-git-send-email-shahafs@mellanox.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).