From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) by dpdk.org (Postfix) with ESMTP id 6A13D37AA for ; Fri, 3 Mar 2017 15:37:42 +0100 (CET) Received: by mail-qk0-f194.google.com with SMTP id n127so27459299qkf.2 for ; Fri, 03 Mar 2017 06:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=XUhTl2dGpRIfxjnbnlvNpmDev6a1q+pNQzbLG+i/1Yk=; b=mpWOHXd9hlRFnrzCB3K1ET3VqZmcpHLieoo9mJ3DUGMLZBWT1Jo+MVMXWZgr446KLf vPPfabw2BAKwHNxgU25lh3Vg5i0yzrC7+S1XUHRc1mTF8yxLt/yc3y3Eej9cCPybstjf BjpjVlVbv9eVV2hs5W3Le0fU8LuVWIBYD2Ru07VhoYTxLvXzVngUDtmXJU1/tWl2V+N4 9qTwpUpBtREGuqfXd0rT5EF2rGlYHynFisNT8b+FxvvlyglRTlhg09kuCJ3/UuiNsxSc +q/HDLLCVpwnpsJf+UHfWF1u/BAlyWjHVp7PbzeolfSoSbX0eDICYvnLXErcWjBW+R63 qQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=XUhTl2dGpRIfxjnbnlvNpmDev6a1q+pNQzbLG+i/1Yk=; b=OgGzVFejktGvU+1SvFNayyJr6GEwdRnEP07CuoqkiBvp7TGRVaCJOupeqqLUInSYXn +yMYM6ErKI9OgldjGwLbMNkvWi4no5SZIjR+5FjRyBTtpyELOWwetbdRs1wrlsNRzYyX RWKPC3M45a+pG8Gy6mZqi50eMyPNlyE+gXvMgpryxE2paWjOllLDNncGviCS6X6IBani TqAjQH2S7MMDAyqLMqcQDBJl6ddFrZaZNrUieun35WN2y7zuk72Mzab5PeEhR36HSZDt k9VFxPtPXNB7nfvOjvuCI3eXLzjKnPOhvywzO/q2RSzlxw3czGj5FdA3U0K5ul0xB1p0 Gknw== X-Gm-Message-State: AMke39nDPa2HYqRrAVz+ZkbsVELbbg1Te3141rxwl6WTN1CS8imHpaCObGtCD7pOT+TKRw== X-Received: by 10.200.35.195 with SMTP id r3mr3089343qtr.282.1488551861707; Fri, 03 Mar 2017 06:37:41 -0800 (PST) Received: from monolith.home (pool-96-255-82-208.washdc.fios.verizon.net. [96.255.82.208]) by smtp.googlemail.com with ESMTPSA id n77sm7723793qkn.18.2017.03.03.06.37.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Mar 2017 06:37:41 -0800 (PST) Message-ID: <1488551860.1670.4.camel@gmail.com> From: Chas Williams <3chas3@gmail.com> To: Allain Legacy , ferruh.yigit@intel.com Cc: ian.jolliffe@windriver.com, jerin.jacob@caviumnetworks.com, stephen@networkplumber.org, thomas.monjalon@6wind.com, dev@dpdk.org Date: Fri, 03 Mar 2017 09:37:40 -0500 In-Reply-To: <1488414008-162839-3-git-send-email-allain.legacy@windriver.com> References: <1488136143-116389-1-git-send-email-allain.legacy@windriver.com> <1488414008-162839-1-git-send-email-allain.legacy@windriver.com> <1488414008-162839-3-git-send-email-allain.legacy@windriver.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 02/16] net/avp: public header files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 14:37:42 -0000 On Wed, 2017-03-01 at 19:19 -0500, Allain Legacy wrote: > + > +/** > + * Memory aligment (cache aligned) Spelling -- alignment. > + */ > +#ifndef RTE_AVP_ALIGNMENT > +#define RTE_AVP_ALIGNMENT 64 > +#endif This is already provided by DPDK as CONFIG_RTE_CACHE_LINE_SIZE > + * Defines the number of mbuf pools supported per device (1 per socket) > + * @note This value should be equal to RTE_MAX_NUMA_NODES > + */ > +#define RTE_AVP_MAX_MEMPOOLS (8) Perhaps it should be RTE_MAX_NUMA_NODES then? > +#define RTE_AVP_MAX_QUEUES (8) /**< Maximum number of queues per device */ > + > +/** Maximum number of chained mbufs in a packet */ > +#define RTE_AVP_MAX_MBUF_SEGMENTS (5) The ()'s around constants aren't really necessary. You aren't going to get side effects.