From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id 2BA773DC for ; Fri, 3 Mar 2017 16:05:00 +0100 (CET) Received: by mail-qk0-f193.google.com with SMTP id j127so9563757qke.0 for ; Fri, 03 Mar 2017 07:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=7EzTWjnI4vIpF+xadQHw5TbMmJSTmFhqQcOY9lTdMN8=; b=WZDnLhT2A3Vc0S8DYVL9MRH38ADeI/kAycaKmSl/Dg342BmSZMihklT2+8L/NaHgl4 BNesYA0Bi1YNF91N4NR7Ky9q6CZusjHoqBuqmGWuDUaklxqe3yegWhUHcfzA5zN0LzF5 1ofESq8/OoNyVCLd+TWTLLwR66e6e52vjCFxviOegRbZUBeiHNWFsN7vU6H9u7EBc3MA 9mf6CjqvDPKPiOheD5ZD4cve4IWaK0zeC2nocbdx/9eQtpnNoDW4/deTnurCME3ZhY6+ C4fpe9paMaYRjdO0S4wy8vzRDt/vnVAwS3u8u+dI4CKJ01I6qwO6IGiL3rc4y6c8DZ0h isxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=7EzTWjnI4vIpF+xadQHw5TbMmJSTmFhqQcOY9lTdMN8=; b=XK1GXvQuWOikl4KTEAdhhlnt3H0zL1MkZJnCNnu7NSJuuueI1eWu4q3FCyolkPx8ke 8R8/DVaqipQHQCh27NP9D62Ey+aNKb8BnFJ5FUkUnD6TDdT03AnDLre8WRS/SGbauKis 2xEAm7lSZUncbL2+j35IjszmOYT3/pxQbv7hxb8cn9cCgM9B8I95kHMiHDDb+1rdEG91 khWzyB2AX8FIYMZsjxzLRovmVMTj4EfegCnLBUvv4lcLQm8YmvDY2ng4C4QCCjRP24Y/ vyDYY/dEHOZIJ3tQvq/ELWhRLZB0iIQMXjHmGrRHjXpj70Vnrc06Ir7T+hJ1HfyW/iRt z3WQ== X-Gm-Message-State: AMke39kVIzk+2N0XC7k45CUVNLYKthVrp3iTdzzBbNzSyUeE6mSrSucfN1rrtV73WWYSww== X-Received: by 10.55.149.6 with SMTP id x6mr2988877qkd.55.1488553500304; Fri, 03 Mar 2017 07:05:00 -0800 (PST) Received: from monolith.home (pool-96-255-82-208.washdc.fios.verizon.net. [96.255.82.208]) by smtp.googlemail.com with ESMTPSA id r186sm7756739qke.26.2017.03.03.07.04.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Mar 2017 07:04:59 -0800 (PST) Message-ID: <1488553499.1670.10.camel@gmail.com> From: Chas Williams <3chas3@gmail.com> To: Allain Legacy , ferruh.yigit@intel.com Cc: ian.jolliffe@windriver.com, jerin.jacob@caviumnetworks.com, stephen@networkplumber.org, thomas.monjalon@6wind.com, dev@dpdk.org Date: Fri, 03 Mar 2017 10:04:59 -0500 In-Reply-To: <1488414008-162839-9-git-send-email-allain.legacy@windriver.com> References: <1488136143-116389-1-git-send-email-allain.legacy@windriver.com> <1488414008-162839-1-git-send-email-allain.legacy@windriver.com> <1488414008-162839-9-git-send-email-allain.legacy@windriver.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 15:05:01 -0000 On Wed, 2017-03-01 at 19:20 -0500, Allain Legacy wrote: > + /* Check current migration status */ > + if (avp_dev_migration_pending(eth_dev)) { > + PMD_DRV_LOG(ERR, "VM live migration operation in progress\n"); > + return -EBUSY; > + } > + > + /* Check BAR resources */ > + ret = avp_dev_check_regions(eth_dev); > + if (ret < 0) { > + PMD_DRV_LOG(ERR, "Failed to validate BAR resources, ret=%d\n", > + ret); > + return ret; > + } > + > + /* Enable interrupts */ > + ret = avp_dev_setup_interrupts(eth_dev); > + if (ret < 0) { > + PMD_DRV_LOG(ERR, "Failed to enable interrupts, ret=%d\n", ret); > + return ret; > + } I don't see the other side of this to unregister the callback. It's also a bit confusing with this here and the other parts in part 15. It looks like you enable the interrupts on .dev_create but disable on .dev_stop? If that's the case, you likely want to just do the setup here and the enable in .dev_start.