* [dpdk-dev] [PATCH 1/2] net/thunderx: fix build issues with 32bit target
@ 2017-03-10 15:39 Jerin Jacob
2017-03-10 15:39 ` [dpdk-dev] [PATCH 2/2] config: enable the thunderx nicvf driver Jerin Jacob
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Jerin Jacob @ 2017-03-10 15:39 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/thunderx/nicvf_struct.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_struct.h b/drivers/net/thunderx/nicvf_struct.h
index c900e12..0e4e1dd 100644
--- a/drivers/net/thunderx/nicvf_struct.h
+++ b/drivers/net/thunderx/nicvf_struct.h
@@ -58,8 +58,8 @@ struct nicvf_txq {
union sq_entry_t *desc;
nicvf_phys_addr_t phys;
struct rte_mbuf **txbuffs;
- uint64_t sq_head;
- uint64_t sq_door;
+ uintptr_t sq_head;
+ uintptr_t sq_door;
struct rte_mempool *pool;
struct nicvf *nic;
void (*pool_free)(struct nicvf_txq *sq);
@@ -74,8 +74,8 @@ struct nicvf_txq {
struct nicvf_rxq {
uint64_t mbuf_phys_off;
- uint64_t cq_status;
- uint64_t cq_door;
+ uintptr_t cq_status;
+ uintptr_t cq_door;
nicvf_phys_addr_t phys;
union cq_entry_t *desc;
struct nicvf_rbdr *shared_rbdr;
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 2/2] config: enable the thunderx nicvf driver
2017-03-10 15:39 [dpdk-dev] [PATCH 1/2] net/thunderx: fix build issues with 32bit target Jerin Jacob
@ 2017-03-10 15:39 ` Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-15 16:32 ` [dpdk-dev] [PATCH 1/2] " Ferruh Yigit
2 siblings, 0 replies; 11+ messages in thread
From: Jerin Jacob @ 2017-03-10 15:39 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
Enable Thunderx nicvf PMD driver in the common
config as it does not have any build dependency
with any external library and/or architecture.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
config/common_base | 2 +-
config/defconfig_arm64-thunderx-linuxapp-gcc | 10 ----------
doc/guides/nics/thunderx.rst | 3 +--
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/config/common_base b/config/common_base
index aeee13e..e48417d 100644
--- a/config/common_base
+++ b/config/common_base
@@ -279,7 +279,7 @@ CONFIG_RTE_LIBRTE_PMD_SZEDATA2_AS=0
#
# Compile burst-oriented Cavium Thunderx NICVF PMD driver
#
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n
+CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=y
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT=n
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX=n
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX=n
diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
index a5b1e24..9818a2e 100644
--- a/config/defconfig_arm64-thunderx-linuxapp-gcc
+++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
@@ -36,13 +36,3 @@ CONFIG_RTE_MACHINE="thunderx"
CONFIG_RTE_CACHE_LINE_SIZE=128
CONFIG_RTE_MAX_NUMA_NODES=2
CONFIG_RTE_MAX_LCORE=96
-
-#
-# Compile Cavium Thunderx NICVF PMD driver
-#
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=y
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_DRIVER=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_MBOX=n
diff --git a/doc/guides/nics/thunderx.rst b/doc/guides/nics/thunderx.rst
index 1314ee9..a95b701 100644
--- a/doc/guides/nics/thunderx.rst
+++ b/doc/guides/nics/thunderx.rst
@@ -77,9 +77,8 @@ Config File Options
The following options can be modified in the ``config`` file.
Please note that enabling debugging options may affect system performance.
-- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD`` (default ``n``)
+- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD`` (default ``y``)
- By default it is enabled only for defconfig_arm64-thunderx-* config.
Toggle compilation of the ``librte_pmd_thunderx_nicvf`` driver.
- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT`` (default ``n``)
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v2 1/3] net/thunderx: fix build issues with 32bit target
2017-03-10 15:39 [dpdk-dev] [PATCH 1/2] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-10 15:39 ` [dpdk-dev] [PATCH 2/2] config: enable the thunderx nicvf driver Jerin Jacob
@ 2017-03-12 14:02 ` Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
` (2 more replies)
2017-03-15 16:32 ` [dpdk-dev] [PATCH 1/2] " Ferruh Yigit
2 siblings, 3 replies; 11+ messages in thread
From: Jerin Jacob @ 2017-03-12 14:02 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/thunderx/nicvf_struct.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_struct.h b/drivers/net/thunderx/nicvf_struct.h
index c900e12..0e4e1dd 100644
--- a/drivers/net/thunderx/nicvf_struct.h
+++ b/drivers/net/thunderx/nicvf_struct.h
@@ -58,8 +58,8 @@ struct nicvf_txq {
union sq_entry_t *desc;
nicvf_phys_addr_t phys;
struct rte_mbuf **txbuffs;
- uint64_t sq_head;
- uint64_t sq_door;
+ uintptr_t sq_head;
+ uintptr_t sq_door;
struct rte_mempool *pool;
struct nicvf *nic;
void (*pool_free)(struct nicvf_txq *sq);
@@ -74,8 +74,8 @@ struct nicvf_txq {
struct nicvf_rxq {
uint64_t mbuf_phys_off;
- uint64_t cq_status;
- uint64_t cq_door;
+ uintptr_t cq_status;
+ uintptr_t cq_door;
nicvf_phys_addr_t phys;
union cq_entry_t *desc;
struct nicvf_rbdr *shared_rbdr;
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v2 2/3] net/thunderx: fix build issues with FreeBSD target
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
@ 2017-03-12 14:02 ` Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 3/3] config: enable the thunderx nicvf driver Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2 siblings, 0 replies; 11+ messages in thread
From: Jerin Jacob @ 2017-03-12 14:02 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
SIMPLEQ_* operations are not available in FreeBSD. Replacing
with equivalent STAILQ_* operations.
Fixes: f2546f8e51b8 ("net/thunderx/base: add functions to store qsets")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
v2:
Fix FreeBSD build issues reported by
http://dpdk.org/ml/archives/test-report/2017-March/013454.html
---
drivers/net/thunderx/base/nicvf_bsvf.c | 12 ++++++------
drivers/net/thunderx/base/nicvf_bsvf.h | 2 +-
drivers/net/thunderx/nicvf_ethdev.c | 1 -
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/thunderx/base/nicvf_bsvf.c b/drivers/net/thunderx/base/nicvf_bsvf.c
index 9e028a3..49a2646 100644
--- a/drivers/net/thunderx/base/nicvf_bsvf.c
+++ b/drivers/net/thunderx/base/nicvf_bsvf.c
@@ -37,7 +37,7 @@
#include "nicvf_bsvf.h"
#include "nicvf_plat.h"
-static SIMPLEQ_HEAD(, svf_entry) head = SIMPLEQ_HEAD_INITIALIZER(head);
+static STAILQ_HEAD(, svf_entry) head = STAILQ_HEAD_INITIALIZER(head);
void
nicvf_bsvf_push(struct svf_entry *entry)
@@ -45,7 +45,7 @@ nicvf_bsvf_push(struct svf_entry *entry)
assert(entry != NULL);
assert(entry->vf != NULL);
- SIMPLEQ_INSERT_TAIL(&head, entry, next);
+ STAILQ_INSERT_TAIL(&head, entry, next);
}
struct svf_entry *
@@ -53,14 +53,14 @@ nicvf_bsvf_pop(void)
{
struct svf_entry *entry;
- assert(!SIMPLEQ_EMPTY(&head));
+ assert(!STAILQ_EMPTY(&head));
- entry = SIMPLEQ_FIRST(&head);
+ entry = STAILQ_FIRST(&head);
assert(entry != NULL);
assert(entry->vf != NULL);
- SIMPLEQ_REMOVE_HEAD(&head, next);
+ STAILQ_REMOVE_HEAD(&head, next);
return entry;
}
@@ -68,5 +68,5 @@ nicvf_bsvf_pop(void)
int
nicvf_bsvf_empty(void)
{
- return SIMPLEQ_EMPTY(&head);
+ return STAILQ_EMPTY(&head);
}
diff --git a/drivers/net/thunderx/base/nicvf_bsvf.h b/drivers/net/thunderx/base/nicvf_bsvf.h
index 5d5a25e..fb9b248 100644
--- a/drivers/net/thunderx/base/nicvf_bsvf.h
+++ b/drivers/net/thunderx/base/nicvf_bsvf.h
@@ -41,7 +41,7 @@ struct nicvf;
* The base queue structure to hold secondary qsets.
*/
struct svf_entry {
- SIMPLEQ_ENTRY(svf_entry) next; /**< Next element's pointer */
+ STAILQ_ENTRY(svf_entry) next; /**< Next element's pointer */
struct nicvf *vf; /**< Holder of a secondary qset */
};
diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index 1060319..fa1cb32 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -41,7 +41,6 @@
#include <inttypes.h>
#include <netinet/in.h>
#include <sys/queue.h>
-#include <sys/timerfd.h>
#include <rte_alarm.h>
#include <rte_atomic.h>
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v2 3/3] config: enable the thunderx nicvf driver
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
@ 2017-03-12 14:02 ` Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2 siblings, 0 replies; 11+ messages in thread
From: Jerin Jacob @ 2017-03-12 14:02 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
Enable Thunderx nicvf PMD driver in the common
config as it does not have build dependency
with any external library and/or architecture.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
config/common_base | 2 +-
config/defconfig_arm64-thunderx-linuxapp-gcc | 10 ----------
doc/guides/nics/thunderx.rst | 3 +--
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/config/common_base b/config/common_base
index aeee13e..e48417d 100644
--- a/config/common_base
+++ b/config/common_base
@@ -279,7 +279,7 @@ CONFIG_RTE_LIBRTE_PMD_SZEDATA2_AS=0
#
# Compile burst-oriented Cavium Thunderx NICVF PMD driver
#
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n
+CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=y
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT=n
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX=n
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX=n
diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
index a5b1e24..9818a2e 100644
--- a/config/defconfig_arm64-thunderx-linuxapp-gcc
+++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
@@ -36,13 +36,3 @@ CONFIG_RTE_MACHINE="thunderx"
CONFIG_RTE_CACHE_LINE_SIZE=128
CONFIG_RTE_MAX_NUMA_NODES=2
CONFIG_RTE_MAX_LCORE=96
-
-#
-# Compile Cavium Thunderx NICVF PMD driver
-#
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=y
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_DRIVER=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_MBOX=n
diff --git a/doc/guides/nics/thunderx.rst b/doc/guides/nics/thunderx.rst
index 1314ee9..a95b701 100644
--- a/doc/guides/nics/thunderx.rst
+++ b/doc/guides/nics/thunderx.rst
@@ -77,9 +77,8 @@ Config File Options
The following options can be modified in the ``config`` file.
Please note that enabling debugging options may affect system performance.
-- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD`` (default ``n``)
+- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD`` (default ``y``)
- By default it is enabled only for defconfig_arm64-thunderx-* config.
Toggle compilation of the ``librte_pmd_thunderx_nicvf`` driver.
- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT`` (default ``n``)
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/thunderx: fix build issues with 32bit target
2017-03-10 15:39 [dpdk-dev] [PATCH 1/2] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-10 15:39 ` [dpdk-dev] [PATCH 2/2] config: enable the thunderx nicvf driver Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
@ 2017-03-15 16:32 ` Ferruh Yigit
2 siblings, 0 replies; 11+ messages in thread
From: Ferruh Yigit @ 2017-03-15 16:32 UTC (permalink / raw)
To: Jerin Jacob, dev
On 3/10/2017 3:39 PM, Jerin Jacob wrote:
> Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Still getting build error with 32bit when debug enabled:
In file included from .../drivers/net/thunderx/base/../nicvf_logs.h:36:0,
from .../drivers/net/thunderx/base/nicvf_plat.h:40,
from .../drivers/net/thunderx/nicvf_rxtx.c:50:
.../drivers/net/thunderx/nicvf_rxtx.c: In function ‘nicvf_fill_rbdr’:
.../drivers/net/thunderx/base/nicvf_plat.h:74:50:
error: cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
#define nicvf_addr_read(addr) rte_read64_relaxed((void *)(addr))
^
.../drivers/net/thunderx/nicvf_rxtx.c:376:2:
note: in expansion of macro ‘NICVF_RX_ASSERT’
NICVF_RX_ASSERT((unsigned int)to_fill <= (qlen_mask -
^~~~~~~~~~~~~~~
.../drivers/net/thunderx/nicvf_rxtx.c:377:4:
note: in expansion of macro ‘nicvf_addr_read’
(nicvf_addr_read(rbdr->rbdr_status) & NICVF_RBDR_COUNT_MASK)));
^~~~~~~~~~~~~~~
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 3/3] config: enable the thunderx nicvf driver Jerin Jacob
@ 2017-03-19 14:48 ` Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
` (2 more replies)
2 siblings, 3 replies; 11+ messages in thread
From: Jerin Jacob @ 2017-03-19 14:48 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
v3:
- Fixed the build error when debug enabled(Ferruh)
---
drivers/net/thunderx/nicvf_struct.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_struct.h b/drivers/net/thunderx/nicvf_struct.h
index c900e12..5bc6d57 100644
--- a/drivers/net/thunderx/nicvf_struct.h
+++ b/drivers/net/thunderx/nicvf_struct.h
@@ -43,8 +43,8 @@
#include <rte_memory.h>
struct nicvf_rbdr {
- uint64_t rbdr_status;
- uint64_t rbdr_door;
+ uintptr_t rbdr_status;
+ uintptr_t rbdr_door;
struct rbdr_entry_t *desc;
nicvf_phys_addr_t phys;
uint32_t buffsz;
@@ -58,8 +58,8 @@ struct nicvf_txq {
union sq_entry_t *desc;
nicvf_phys_addr_t phys;
struct rte_mbuf **txbuffs;
- uint64_t sq_head;
- uint64_t sq_door;
+ uintptr_t sq_head;
+ uintptr_t sq_door;
struct rte_mempool *pool;
struct nicvf *nic;
void (*pool_free)(struct nicvf_txq *sq);
@@ -74,8 +74,8 @@ struct nicvf_txq {
struct nicvf_rxq {
uint64_t mbuf_phys_off;
- uint64_t cq_status;
- uint64_t cq_door;
+ uintptr_t cq_status;
+ uintptr_t cq_door;
nicvf_phys_addr_t phys;
union cq_entry_t *desc;
struct nicvf_rbdr *shared_rbdr;
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v3 2/3] net/thunderx: fix build issues with FreeBSD target
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
@ 2017-03-19 14:48 ` Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 3/3] config: enable the thunderx nicvf driver Jerin Jacob
2017-03-20 12:21 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Ferruh Yigit
2 siblings, 0 replies; 11+ messages in thread
From: Jerin Jacob @ 2017-03-19 14:48 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
SIMPLEQ_* operations are not available in FreeBSD. Replacing
with equivalent STAILQ_* operations.
Fixes: f2546f8e51b8 ("net/thunderx/base: add functions to store qsets")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/thunderx/base/nicvf_bsvf.c | 12 ++++++------
drivers/net/thunderx/base/nicvf_bsvf.h | 2 +-
drivers/net/thunderx/nicvf_ethdev.c | 1 -
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/thunderx/base/nicvf_bsvf.c b/drivers/net/thunderx/base/nicvf_bsvf.c
index 9e028a3..49a2646 100644
--- a/drivers/net/thunderx/base/nicvf_bsvf.c
+++ b/drivers/net/thunderx/base/nicvf_bsvf.c
@@ -37,7 +37,7 @@
#include "nicvf_bsvf.h"
#include "nicvf_plat.h"
-static SIMPLEQ_HEAD(, svf_entry) head = SIMPLEQ_HEAD_INITIALIZER(head);
+static STAILQ_HEAD(, svf_entry) head = STAILQ_HEAD_INITIALIZER(head);
void
nicvf_bsvf_push(struct svf_entry *entry)
@@ -45,7 +45,7 @@ nicvf_bsvf_push(struct svf_entry *entry)
assert(entry != NULL);
assert(entry->vf != NULL);
- SIMPLEQ_INSERT_TAIL(&head, entry, next);
+ STAILQ_INSERT_TAIL(&head, entry, next);
}
struct svf_entry *
@@ -53,14 +53,14 @@ nicvf_bsvf_pop(void)
{
struct svf_entry *entry;
- assert(!SIMPLEQ_EMPTY(&head));
+ assert(!STAILQ_EMPTY(&head));
- entry = SIMPLEQ_FIRST(&head);
+ entry = STAILQ_FIRST(&head);
assert(entry != NULL);
assert(entry->vf != NULL);
- SIMPLEQ_REMOVE_HEAD(&head, next);
+ STAILQ_REMOVE_HEAD(&head, next);
return entry;
}
@@ -68,5 +68,5 @@ nicvf_bsvf_pop(void)
int
nicvf_bsvf_empty(void)
{
- return SIMPLEQ_EMPTY(&head);
+ return STAILQ_EMPTY(&head);
}
diff --git a/drivers/net/thunderx/base/nicvf_bsvf.h b/drivers/net/thunderx/base/nicvf_bsvf.h
index 5d5a25e..fb9b248 100644
--- a/drivers/net/thunderx/base/nicvf_bsvf.h
+++ b/drivers/net/thunderx/base/nicvf_bsvf.h
@@ -41,7 +41,7 @@ struct nicvf;
* The base queue structure to hold secondary qsets.
*/
struct svf_entry {
- SIMPLEQ_ENTRY(svf_entry) next; /**< Next element's pointer */
+ STAILQ_ENTRY(svf_entry) next; /**< Next element's pointer */
struct nicvf *vf; /**< Holder of a secondary qset */
};
diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index 871b4f0..5f34237 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -41,7 +41,6 @@
#include <inttypes.h>
#include <netinet/in.h>
#include <sys/queue.h>
-#include <sys/timerfd.h>
#include <rte_alarm.h>
#include <rte_atomic.h>
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v3 3/3] config: enable the thunderx nicvf driver
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
@ 2017-03-19 14:48 ` Jerin Jacob
2017-03-20 12:21 ` Ferruh Yigit
2017-03-20 12:21 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Ferruh Yigit
2 siblings, 1 reply; 11+ messages in thread
From: Jerin Jacob @ 2017-03-19 14:48 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Jerin Jacob
Enable Thunderx nicvf PMD driver in the common
config as it does not have build dependency
with any external library and/or architecture.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
config/common_base | 2 +-
config/defconfig_arm64-thunderx-linuxapp-gcc | 10 ----------
doc/guides/nics/thunderx.rst | 3 +--
3 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/config/common_base b/config/common_base
index e3ce210..92856be 100644
--- a/config/common_base
+++ b/config/common_base
@@ -279,7 +279,7 @@ CONFIG_RTE_LIBRTE_PMD_SZEDATA2_AS=0
#
# Compile burst-oriented Cavium Thunderx NICVF PMD driver
#
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n
+CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=y
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT=n
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX=n
CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX=n
diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
index a5b1e24..9818a2e 100644
--- a/config/defconfig_arm64-thunderx-linuxapp-gcc
+++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
@@ -36,13 +36,3 @@ CONFIG_RTE_MACHINE="thunderx"
CONFIG_RTE_CACHE_LINE_SIZE=128
CONFIG_RTE_MAX_NUMA_NODES=2
CONFIG_RTE_MAX_LCORE=96
-
-#
-# Compile Cavium Thunderx NICVF PMD driver
-#
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=y
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_DRIVER=n
-CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_MBOX=n
diff --git a/doc/guides/nics/thunderx.rst b/doc/guides/nics/thunderx.rst
index 1314ee9..a95b701 100644
--- a/doc/guides/nics/thunderx.rst
+++ b/doc/guides/nics/thunderx.rst
@@ -77,9 +77,8 @@ Config File Options
The following options can be modified in the ``config`` file.
Please note that enabling debugging options may affect system performance.
-- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD`` (default ``n``)
+- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD`` (default ``y``)
- By default it is enabled only for defconfig_arm64-thunderx-* config.
Toggle compilation of the ``librte_pmd_thunderx_nicvf`` driver.
- ``CONFIG_RTE_LIBRTE_THUNDERX_NICVF_DEBUG_INIT`` (default ``n``)
--
2.5.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 3/3] config: enable the thunderx nicvf driver Jerin Jacob
@ 2017-03-20 12:21 ` Ferruh Yigit
2 siblings, 0 replies; 11+ messages in thread
From: Ferruh Yigit @ 2017-03-20 12:21 UTC (permalink / raw)
To: Jerin Jacob, dev
On 3/19/2017 2:48 PM, Jerin Jacob wrote:
> Fixes: e438796617dc ("net/thunderx: add PMD skeleton")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v3 3/3] config: enable the thunderx nicvf driver
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 3/3] config: enable the thunderx nicvf driver Jerin Jacob
@ 2017-03-20 12:21 ` Ferruh Yigit
0 siblings, 0 replies; 11+ messages in thread
From: Ferruh Yigit @ 2017-03-20 12:21 UTC (permalink / raw)
To: Jerin Jacob, dev; +Cc: Thomas Monjalon
On 3/19/2017 2:48 PM, Jerin Jacob wrote:
> Enable Thunderx nicvf PMD driver in the common
> config as it does not have build dependency
> with any external library and/or architecture.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Congratulations, Thunderx PMD enabled by default now.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-03-20 12:21 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 15:39 [dpdk-dev] [PATCH 1/2] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-10 15:39 ` [dpdk-dev] [PATCH 2/2] config: enable the thunderx nicvf driver Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
2017-03-12 14:02 ` [dpdk-dev] [PATCH v2 3/3] config: enable the thunderx nicvf driver Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 2/3] net/thunderx: fix build issues with FreeBSD target Jerin Jacob
2017-03-19 14:48 ` [dpdk-dev] [PATCH v3 3/3] config: enable the thunderx nicvf driver Jerin Jacob
2017-03-20 12:21 ` Ferruh Yigit
2017-03-20 12:21 ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target Ferruh Yigit
2017-03-15 16:32 ` [dpdk-dev] [PATCH 1/2] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).