From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from netronome.com (host-79-78-33-110.static.as9105.net [79.78.33.110]) by dpdk.org (Postfix) with ESMTP id C7E4711C5 for ; Tue, 21 Mar 2017 11:43:22 +0100 (CET) Received: from netronome.com (localhost [127.0.0.1]) by netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v2LAhLTZ015753 for ; Tue, 21 Mar 2017 10:43:21 GMT Received: (from alucero@localhost) by netronome.com (8.14.4/8.14.4/Submit) id v2LAhLl2015752 for dev@dpdk.org; Tue, 21 Mar 2017 10:43:21 GMT From: Alejandro Lucero To: dev@dpdk.org Date: Tue, 21 Mar 2017 10:43:20 +0000 Message-Id: <1490093001-15710-2-git-send-email-alejandro.lucero@netronome.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1490093001-15710-1-git-send-email-alejandro.lucero@netronome.com> References: <1490093001-15710-1-git-send-email-alejandro.lucero@netronome.com> Subject: [dpdk-dev] [PATCH 2/3] nfp: fix problem with pkt_len to data_len conversion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 10:43:23 -0000 Chained mbufs hold data_len as the length of that particular mbuf and pkt_len as the full packet length including all the chained mbufs. It is not clear from the mbuf definition if pkt_len should be set for all the mbufs in a chain, but code there for handling mbufs suggests just the first mbuf requires to have pkt_len set. NFP PMD was assuming pkt_len is set in all the chained mbufs and unit tests for gather dma were building mbufs with pkt_len always set. This patch gets rid of that assumption. Fixes: b812daadad0d (\"nfp: add Rx and Tx\") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 9d9420d..6155d7c 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2097,6 +2097,7 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq) * Checksum and VLAN flags just in the first descriptor for a * multisegment packet, but TSO info needs to be in all of them. */ + txd.data_len = pkt->pkt_len; nfp_net_tx_tso(txq, &txd, pkt); nfp_net_tx_cksum(txq, &txd, pkt); @@ -2132,7 +2133,7 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq) /* Filling descriptors fields */ txds->dma_len = dma_size; - txds->data_len = pkt->pkt_len; + txds->data_len = txd.data_len; txds->dma_addr_hi = (dma_addr >> 32) & 0xff; txds->dma_addr_lo = (dma_addr & 0xffffffff); ASSERT(free_descs > 0); -- 1.9.1