From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 8348ED19A for ; Tue, 28 Mar 2017 14:01:41 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id l43so101192381wre.1 for ; Tue, 28 Mar 2017 05:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3R9hK/FPsiZG5Mt1ki2F1xoXkYiYd32jf9AMTDcPVmE=; b=eS2FPcdM+/egNDnNqPaG5tQL6pzbiIhXaH01bSSW7L9sY5ifDHl9OHv0ruPcYqCukR aGIOW5xAC+Orlq8QTsZcIQeFwKsYdkKhJ4s1kVF46+I6qD1MRoLLLFS8aKzejwIeabMl MsSTodJ8BY88aMgBezG0AAkv6qSUPaNaRHypbdM2Swz5qKuuZt59FzCPmCU/UUlur8xb jUVFACV4WUQ5RossFQjHggxEarPP834M+oD4yuzVPVDcsq/s1Ga3wNmV5DT7EiOLbmVN X3lmXWpIV2Z+w8L+VFuHrgwOxt9xipoJU0HIds9rP40z+9vwYgob06oNPyke+3fQQmAR RUZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3R9hK/FPsiZG5Mt1ki2F1xoXkYiYd32jf9AMTDcPVmE=; b=caoBEt6yJpEoy7JGm7pAc8Ty2oXib8naY2wjldx6B60nDZO6+uNx4p9O+l7MAQFPpX vk6QnNnmoNr8dyQOZ38gHdCj98hq9UT91q8vTpohqoDf/ekTxk2WB1ZrKrFY4ldP8mVA oW+R1vepbVVVHRYF2l2Op6kgVr7JQnDtbf4F7AG8hsV4ILy6N9yvMAIP/H9SLgrL3qFw +abnxtWYS4koIUd/koUDmWBNcbuUl7iCyx6o3EjS6yz2caFAKqyn2En7TGEDlRtVS7WC KD6Jbx1z3r8cnWBxyHFo/p8IIjYUa1BQTVuc93okKdDTgED7s6IjgQ2S/nfUBkrOn+Cy YUGQ== X-Gm-Message-State: AFeK/H1CcoQyjk7Vylj6xy7JVyTj2/TbY8Ro8M1oQZnPha87eyLvYtn5iISgQ0HBNyzBgXB4 X-Received: by 10.223.175.84 with SMTP id z78mr27757252wrc.84.1490702501091; Tue, 28 Mar 2017 05:01:41 -0700 (PDT) Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q4sm3377621wme.17.2017.03.28.05.01.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Mar 2017 05:01:40 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Thomas Monjalon Date: Tue, 28 Mar 2017 14:01:29 +0200 Message-Id: <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1490701917-17089-1-git-send-email-gaetan.rivet@6wind.com> References: <1490701917-17089-1-git-send-email-gaetan.rivet@6wind.com> Subject: [dpdk-dev] [PATCH v2 1/1] pci: default to whitelist mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 12:01:41 -0000 Expects all devices to be explicitly defined before being probed. The blacklist mode can be prone to errors, coaxing users in capturing devices that could be used for management or otherwise. The whitelist mode offers users more control and highlight mistakes by making them visible on the command line. This is more useful to have a clear idea of the state of the system used, which is better in the context of standalone / headless applications. Using the -b option will revert to the original behavior. Signed-off-by: Gaetan Rivet --- v2: justify this default behavior evolution. --- lib/librte_eal/common/eal_common_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 15a0c48..ad0a8be 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -418,7 +418,7 @@ rte_eal_pci_probe(void) int probe_all = 0; int ret = 0; - if (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) == 0) + if (rte_eal_devargs_type_count(RTE_DEVTYPE_BLACKLISTED_PCI) > 0) probe_all = 1; TAILQ_FOREACH(dev, &pci_device_list, next) { -- 2.1.4