DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wei Dai <wei.dai@intel.com>
To: dev@dpdk.org
Cc: Wei Dai <wei.dai@intel.com>
Subject: [dpdk-dev] [PATCH 0/2] mac addr fail to be added shouldn't be storeid
Date: Sat,  1 Apr 2017 01:04:45 +0800	[thread overview]
Message-ID: <1490979887-27827-1-git-send-email-wei.dai@intel.com> (raw)

current ethdev always store mac addr even it fail to be added.
Other function may regard the failed mac addr valid and lead to
some errors. So it is need to check if the addr is added successfully 
or not. And discard it if it fails.

In 2nd patch, add a command "add_more_mac_addr port_id base_mac_addr count"
to add more than one mac address one time. It is also
for testing this fix.

Wei Dai (2):
  ethdev: fix adding invalid mac addr
  app/testpmd: add a command to add many mac addrs

 app/test-pmd/cmdline.c             | 52 ++++++++++++++++++++++++++++++++++++++
 drivers/net/bnx2x/bnx2x_ethdev.c   |  7 +++--
 drivers/net/bnxt/bnxt_ethdev.c     | 12 ++++-----
 drivers/net/e1000/base/e1000_api.c |  2 +-
 drivers/net/e1000/em_ethdev.c      |  6 ++---
 drivers/net/e1000/igb_ethdev.c     |  5 ++--
 drivers/net/enic/enic.h            |  2 +-
 drivers/net/enic/enic_ethdev.c     |  4 +--
 drivers/net/enic/enic_main.c       |  6 ++---
 drivers/net/fm10k/fm10k_ethdev.c   |  3 ++-
 drivers/net/i40e/i40e_ethdev.c     | 11 ++++----
 drivers/net/i40e/i40e_ethdev_vf.c  |  8 +++---
 drivers/net/ixgbe/ixgbe_ethdev.c   | 26 ++++++++++++-------
 drivers/net/mlx4/mlx4.c            | 14 ++++++----
 drivers/net/mlx5/mlx5.h            |  2 +-
 drivers/net/mlx5/mlx5_mac.c        | 12 ++++++---
 drivers/net/qede/qede_ethdev.c     |  3 ++-
 drivers/net/ring/rte_eth_ring.c    |  3 ++-
 drivers/net/virtio/virtio_ethdev.c | 13 +++++-----
 lib/librte_ether/rte_ethdev.c      | 15 ++++++-----
 lib/librte_ether/rte_ethdev.h      |  2 +-
 21 files changed, 144 insertions(+), 64 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-03-31 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 17:04 Wei Dai [this message]
2017-03-31 17:04 ` [dpdk-dev] [PATCH 1/2] ethdev: fix adding invalid mac addr Wei Dai
2017-03-31 17:04 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add a command to add many mac addrs Wei Dai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490979887-27827-1-git-send-email-wei.dai@intel.com \
    --to=wei.dai@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).