From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7D6A43B5 for ; Fri, 31 Mar 2017 19:12:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490980327; x=1522516327; h=from:to:cc:subject:date:message-id; bh=6U2TEc7lKWdLIS03r2KFkjb2sK7+74NgvDmV6vXLbG8=; b=t2ZzdrQTQgfb/nNL1wS4dn/mnUCbevz0eak0I2FfT0MEVakdVDyUUWd/ r9JRJtU1mLJQSU0DKk2OV/mWLyAc2Q==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 10:12:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,252,1486454400"; d="scan'208";a="1149363373" Received: from dpdk6.bj.intel.com ([172.16.182.81]) by fmsmga002.fm.intel.com with ESMTP; 31 Mar 2017 10:12:04 -0700 From: Wei Dai To: dev@dpdk.org Cc: Wei Dai Date: Sat, 1 Apr 2017 01:04:45 +0800 Message-Id: <1490979887-27827-1-git-send-email-wei.dai@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH 0/2] mac addr fail to be added shouldn't be storeid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 17:12:08 -0000 current ethdev always store mac addr even it fail to be added. Other function may regard the failed mac addr valid and lead to some errors. So it is need to check if the addr is added successfully or not. And discard it if it fails. In 2nd patch, add a command "add_more_mac_addr port_id base_mac_addr count" to add more than one mac address one time. It is also for testing this fix. Wei Dai (2): ethdev: fix adding invalid mac addr app/testpmd: add a command to add many mac addrs app/test-pmd/cmdline.c | 52 ++++++++++++++++++++++++++++++++++++++ drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++-- drivers/net/bnxt/bnxt_ethdev.c | 12 ++++----- drivers/net/e1000/base/e1000_api.c | 2 +- drivers/net/e1000/em_ethdev.c | 6 ++--- drivers/net/e1000/igb_ethdev.c | 5 ++-- drivers/net/enic/enic.h | 2 +- drivers/net/enic/enic_ethdev.c | 4 +-- drivers/net/enic/enic_main.c | 6 ++--- drivers/net/fm10k/fm10k_ethdev.c | 3 ++- drivers/net/i40e/i40e_ethdev.c | 11 ++++---- drivers/net/i40e/i40e_ethdev_vf.c | 8 +++--- drivers/net/ixgbe/ixgbe_ethdev.c | 26 ++++++++++++------- drivers/net/mlx4/mlx4.c | 14 ++++++---- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_mac.c | 12 ++++++--- drivers/net/qede/qede_ethdev.c | 3 ++- drivers/net/ring/rte_eth_ring.c | 3 ++- drivers/net/virtio/virtio_ethdev.c | 13 +++++----- lib/librte_ether/rte_ethdev.c | 15 ++++++----- lib/librte_ether/rte_ethdev.h | 2 +- 21 files changed, 144 insertions(+), 64 deletions(-) -- 2.7.4