From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7A83B2B91 for ; Sat, 1 Apr 2017 10:10:44 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 01 Apr 2017 01:10:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,256,1486454400"; d="scan'208";a="950485914" Received: from dpdk6.bj.intel.com ([172.16.182.81]) by orsmga003.jf.intel.com with ESMTP; 01 Apr 2017 01:10:40 -0700 From: Wei Dai To: dev@dpdk.org, thomas.monjalon@6wind.com, harish.patil@cavium.com, rasesh.mody@cavium.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com Cc: Wei Dai Date: Sat, 1 Apr 2017 16:03:15 +0800 Message-Id: <1491033797-14186-1-git-send-email-wei.dai@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH 0/2] MAC address fail to be added shouldn't be stored X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Apr 2017 08:10:46 -0000 Current ethdev always stores MAC address even it fails to be added. Other function may regard the failed MAC address valid and lead to some errors. So There is a need to check if the addr is added successfully or not and discard it if it fails. In 2nd patch, add a command "add_more_mac_addr port_id base_mac_addr count" to add more than one MAC address one time. It is also for testing this fix. --- Changes v2: fix warnings and erros from check-git-log.sh and checkpatch.pl Wei Dai (2): ethdev: fix adding invalid MAC addr app/testpmd: add a command to add many MAC addrs app/test-pmd/cmdline.c | 55 ++++++++++++++++++++++++++++++++++++++ drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++-- drivers/net/bnxt/bnxt_ethdev.c | 12 ++++----- drivers/net/e1000/base/e1000_api.c | 2 +- drivers/net/e1000/em_ethdev.c | 6 ++--- drivers/net/e1000/igb_ethdev.c | 5 ++-- drivers/net/enic/enic.h | 2 +- drivers/net/enic/enic_ethdev.c | 4 +-- drivers/net/enic/enic_main.c | 6 ++--- drivers/net/fm10k/fm10k_ethdev.c | 3 ++- drivers/net/i40e/i40e_ethdev.c | 11 ++++---- drivers/net/i40e/i40e_ethdev_vf.c | 8 +++--- drivers/net/ixgbe/ixgbe_ethdev.c | 27 ++++++++++++------- drivers/net/mlx4/mlx4.c | 14 ++++++---- drivers/net/mlx5/mlx5.h | 4 +-- drivers/net/mlx5/mlx5_mac.c | 12 ++++++--- drivers/net/qede/qede_ethdev.c | 3 ++- drivers/net/ring/rte_eth_ring.c | 3 ++- drivers/net/virtio/virtio_ethdev.c | 13 ++++----- lib/librte_ether/rte_ethdev.c | 15 ++++++----- lib/librte_ether/rte_ethdev.h | 2 +- 21 files changed, 149 insertions(+), 65 deletions(-) -- 2.7.4