From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0041.outbound.protection.outlook.com [104.47.37.41]) by dpdk.org (Postfix) with ESMTP id C1B722B87 for ; Mon, 10 Apr 2017 08:28:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=t6cwycCRmGVTpPbxrbUa+hsEYyAaKcFzLTdf83uhwEU=; b=a+ZsjYPXhbR0mpKQnI5QO7Abdb0368OrxoCiWWSeRJwKFL1Gsaq9MWfHFwm4NEk1e0/8CcUzL2IkpD/1IG4IdHbHOHY4/yxpyaY8zI5EO3ABWZgDCy502GAsplIubPvGNNmBlM1PXucfN2zB94aaDVPOh2+Xk550AEa/lvRrH/M= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from lio357.in.caveonetworks.com (14.140.2.178) by DM3PR07MB2281.namprd07.prod.outlook.com (10.164.33.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Mon, 10 Apr 2017 06:28:05 +0000 From: Shijith Thotton To: Ferruh Yigit Cc: dev@dpdk.org Date: Mon, 10 Apr 2017 11:56:07 +0530 Message-Id: <1491805567-10743-2-git-send-email-shijith.thotton@caviumnetworks.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1491805567-10743-1-git-send-email-shijith.thotton@caviumnetworks.com> References: <1491805567-10743-1-git-send-email-shijith.thotton@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: MAXPR01CA0066.INDPRD01.PROD.OUTLOOK.COM (10.164.146.166) To DM3PR07MB2281.namprd07.prod.outlook.com (10.164.33.155) X-MS-Office365-Filtering-Correlation-Id: f0b44d50-198d-4371-cafc-08d47fdabfb6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DM3PR07MB2281; X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2281; 3:raU9E1VOjGJNKY1exEvOtZ7yLNiRVgeHGpaoe9ZQOOyooqgv25ty/F0NcTi2tNg8pMVAEeDKKtQxCOI2UAb6d4IbkXCSCrTxQG6BP2X9E/l4Ii0rJhUTS65cmMhZw4BGODgvg+84g3VS5StE0DTNYttXqwTAlZtYTddbAAtzkdKED/nzEMGHmUeIL+A4/acXUTIJVjYjl+pRVFtPAWkP7ZIAiBBh2qy5moJen8cS4S9XYzU8AdgljL1TuEl9hnFPcjt5B/+aHeIVPcuKZ6a9Mcv0iD3yNAChxSjjPnsxiIJu+Rv/qTL1LprmSHZdfO9ipWqwl5YS/374k84sACbLug==; 25:Md8SgTo14AkK6+wvQLsnsWsO5Et/nwatREB/WnT35OfYeJnHRLds6+bYAK+U758rnH1tqdXaEaaD2j5Ms+FRp0CVBIPu7akHq9v40BNwjeWx1nhwNavDly+TCvqXzGMIe3aDFq8KNx5vrV+RZ18aO2RgTDP2ncVsYx0viuhQGVA0mUL8OADArh4eWoQBKrwwfTOFF4BymxqAxpYMcPSHpEma7zTlARa66dwwgkECEskL3skLKXMMomO1Y3kRybki0cPuhY+0zfgxJy4HbKI/LI2u92etPS09g21IasD8ZSQIWTicIPoqXqv4FdpUtskvZEIdBnqSfrOIH755/4BIsk/heTmDN9HeT/KUYpISdwTKtIrIfw+IsOkCFGxspmjV5Jg+4uZUrRjkkwuz2ne0azCDUHBmLAufGWB8KqVxXbQM4a39+evyuwTmrDtYwd9cp0yN2cQBhOOcz4cSbzl7NQ== X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2281; 31:29wVAmGcYy2yL2mQLZ90I7EdwA9sGY3KKxGiwHNebjXNOvJgcGG9+2mLWDlrWVx6W0AdaeZ2Ydg4YmGenNg0O2P4ZQmOEkxEWtu2BeKfQ3GM6RlmuvrBcz+a+lqNpQUcSiDC17U+LNSxzVG367+6zW1p0LrRxcjRoisTD6ew2fF9ySH7Zdn0UMVWAIN5GQJOqT0roQMAbh13cc7J4qRg4Fumm4nD7TsASlDGo6/VMXJ6dIECSGEt3/frpAgFMb8BXVbMANXhQVTmFPNz+QIQug==; 20:+K2Gnm0S+9FQJHg5lRv1PQABRMp1MbPHR8HCzLjFrbu5Jl+MQm8PZ3fJaihIDUbuNivkanlxiZZ6/QXqsDTIs1GH85aViKvMBO0MgjEfbKdtIijd5SgbVlAX5qjyhxVNZTgP0ITVoXIMsf9KJP9dBH14kpENln+z8pJCKb8bpLodmiugimagFRZnXzhUGRmOR9X/q5pxd40vRzJ9AJORrBo/vmVoFnMueZ2baOXECQnbsJef4KLa2nKIKLQ1LNlkETqbHFSNP9/WLc6VLSDvZeydJ/nRaRaJW2+EI8aK3cXFMMmBCB3zloO3rAEbrMPXkdsC/GnjLctgZ7M07sie0R7b31Xu8MBo50l8P2yV48MkT83/Bj8KC23vn1Dm8mL3XA9ur3HlnFLg7M1M4WvZOK+6UZVXGCeRAsnJJK4o+b2YtFA/6MaziQjHAyhHKDwnB7I8ezHdNk7Y9udW9XMRfFF6sPTqROjHljVNAmjRvoiZUeomyfjBJsxpz/kczS7z7snlAxZJRsky4FMjGbhEguALOAuebW6wgDmt8T1c/Q8s2jq5TbAYd8r+WnkA6aluQVHbr0Uf0NFhCeBmmDpGvuViujfvnjFikYOcEADtNbM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:DM3PR07MB2281; BCL:0; PCL:0; RULEID:; SRVR:DM3PR07MB2281; X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2281; 4:m225ZuXgMRGwy/IssWkqfRg5qNnfMc8H6KcFUSKhFhAPNzvBMueG/LYvODz6fvU/vRAOoUXBhUWApS7y322YOCefzf4vIbdYgx8t5zScCzlVY3MjVAukWJM65gq8rRIQArWiEQQsmWrrNahe2t6mFGhz8YiM/+H1hoRnal2/4KdDaO0EhLgCkUefV6NIphbxHJK4ieDof5HXMdslkAcJMnUJpuRf2WWB62w5LKZx6pWO9Y7KJeNsLQ2uu/sE+2o8QQ8CkFumzDg3atS7ODzlRkeaAy/XmV8QUiLQttjEkneS2Q+tnHdnzGv2xKq5bKL/wWzGAz/6WEfjBBOVk+reGWgRPM3oaNR9g69MHNt+DJsd1RFfaFiA5hnoHchfFia4utvoYAy4DjZa7JM8RjBWAwXmQVRaA2x+zP6yG7QIdc/kHV5koXMGlEM8N2O81h+XGbZF4M/ZJn+emUOuRZxaDPa9gP73qbUIBsuxJNyMMI85aKzjV/BWFOjatvWxhNLiiWgCyfRlg0UtZZJh3tScJog05KxlYgMCp9SWoGqXKqRQ6MOpmWpT0qEOFt3AxSMgTeyQce/UxDEaEz1sb61N3k9frW2PQGsE6CKEWTZzlFdBAqEpbmzTaVuWyRMQ4hCD70VrI5KPawcHEfICorAuZxqa5Ngx6oOhB+exXEx00GIRQgKldBBJ37b6Jd411h/5 X-Forefront-PRVS: 027367F73D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39850400002)(39400400002)(39410400002)(39450400003)(39840400002)(42186005)(189998001)(25786009)(4326008)(8676002)(48376002)(6506006)(6486002)(33646002)(50226002)(50466002)(7736002)(5660300001)(36756003)(47776003)(305945005)(2906002)(76176999)(50986999)(38730400002)(110136004)(5003940100001)(81166006)(66066001)(3846002)(2950100002)(6916009)(42882006)(6512007)(4720700003)(5009440100003)(53936002)(6116002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:DM3PR07MB2281; H:lio357.in.caveonetworks.com; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM3PR07MB2281; 23:/Dc4Xg/jNGOeEy9wehqUtVtygJFnZkhl0LFTDgRlq?= =?us-ascii?Q?mhwkOzN5LrLvL6M2Xmb5R8dL65Ac8rRanSicZlalxzVMHbowP4pLQS5mgOOk?= =?us-ascii?Q?xj+PZSw64PSTlqki+S5poXWdc3UyhIfc/VyY/zK1Pb4YkACMNqglT2emS56R?= =?us-ascii?Q?bbAIv+Artz9BxzAerDGuoBBRU7UGt0leV5dt+adwsIsvF94LARZpTYxWHFIe?= =?us-ascii?Q?GGLlR00wgV4k6nvOOfvk7eMZvssI58S6jILiTUdX0eantOy23lXAmn94ZToR?= =?us-ascii?Q?FGzAdE2rm1s0ksBn6VHF+lrjaJQtJBAlNLrGjKhtLVrNDHDwErTzjKOfT3vC?= =?us-ascii?Q?AFYuM2aXl+Y7csBvssoauaEnL7Voav1NqhA58Iy1nMhJRB0K4OW0v4NB5xDz?= =?us-ascii?Q?bAoVrGixg4ytnviAm7ot/hFwE2zULxZbpaVK0epcb7TN3FjFanSN6MCv2Ul2?= =?us-ascii?Q?gWpBP2xRlk/v0iA35XvW+W22bULOEJBmyS99vOyNYPwJy6lkHLo1t8Ph0DO9?= =?us-ascii?Q?tA/FWIWf0M0+Jh8aRHxAgarp+9nsK8vGhsdeRnakhYu96a7jMgitYwecChVr?= =?us-ascii?Q?ylsR4kY2sVoYyqC0j0y7oNvZKeIUZLpD4rHrQIISc0CPWQLD10fQHxEsL272?= =?us-ascii?Q?1bsOkJ28h5xpLbfXpf7VswCFzpE4N5NyKrUYBstdyiDl/TN7Eqo9XPduzZBs?= =?us-ascii?Q?Q092lugNrgnGu/G7rbBcOD9HWGJPw5aD8F5j/iUQCHkIkVzv1T4JAQg5nOVe?= =?us-ascii?Q?p5o8GL9rZzCH5Dn6fA6sYRpjztsd8fBtM9FVPgdKGSsqex1xO1BAXHJPiqhB?= =?us-ascii?Q?e1FkS5TgzL7+ju/un3HjVWxeTltF4Pa3N5iJDCs/K5RRmCv3W8CnSbneMLk/?= =?us-ascii?Q?KJgqut+g25XvHmQBmlarcLP2Mgogf1N1w/jog4BDQmTDYvtPqNE3N6nt+h5v?= =?us-ascii?Q?5DU4yE0aK3iGkQpmH9Cb0jzEPnVYrwEbw73TTd8Xu1WxQCGzalaxY+4ENJx3?= =?us-ascii?Q?A69ZLrcXDThaiUllg6cPJUN7yFqyX0vNHFdtMqHKiF1LByTXdXRHXqd2cd9K?= =?us-ascii?Q?lEROwSzRMZqauTceWjaLoWhbCtC?= X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2281; 6:HuzbJk54A3rO8ixjOKFyv/STEg4LajjH0AgnPyX6bX6woUpt0hwbKvS7qttaFtZsAexS07MKI4FFyZrZxxXPbCOm68XbBzfw8TVB0KmSMruyhcUtOZdvXldC7+gbENF2DuCuF2VBWzfk3m8L7BW/F8/WNPpmPsiTBzFPm1/xU8uI1rUYV4hfg0OMBEQM3vNhi/E1iOo/fjD6DtGOiYQHaUUhb9ezgFwQNuZezG8lfQezK6u6YGANziQTIHJ4fPl75gn3c0oJSCyq5SXszvvdFOdFMfM8yLoLhdkh75azNp89UdXh3zUXv4TtFQcY2CaHyEzpeFNSJfZlDTjHkiaTvojHHyHISLTjMaLRRXOUWmfsjfFDLHNTuoM5SxDcbKcSFDnOjiphyqcLmDHtQVtLunO/UTFSHs3BAYF09yADNjD9VtjljNdSIOGjE49T+UiSm8//SgiNLLYASgMt8u3Vyw==; 5:CuWZzz1YzSIj+uxODoKGWWIetiqerVNu05jxHgmG3OfPpsEimp6NVP2BbwsqXGBDhSBuRcST23P+sd63sVbIova+FM1kZ04QF82+lNlzKPaRxbYzWTMPbFSoq4jbX5mj8+IIJ/xhaMfyfiPj5htTjg==; 24:0draaRl4+CtZ3z1F5jMMy73E+P8/nxTVqEXujul37efI5hfB1XpCKO4cu0r4zRLktv6+j+MaiNwtl/wOGE8H87ntjrQDJT67KaqXC/JnR+U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2281; 7:6EuAz76dn/BXEDdQ30aZaYX17kWBMnm0GLKjuDJQgiE6MpRGBdo0Z2DreYTJWQ3H4CzpygaqJR8JwiW9i24KTT61C5WfDT6D6QZG6KAtz58b3kYqBR/R8ZZWm8bjgtvH9GKcnrmuWLR6Znal6HRdLvbMAz0UcU1cZnkaq+G2Lthytz2BUEbEUw4SIXRPKi+XCki2t8jc/RLkTNlRAouJU8YgjpdZRdglXAa1AMt5sMLnyuhOyQ4GqoOKEtIu9UqrWeVmQfNOQ2Ev2VAIOt+Rpo21BSLE2x9cn2YVuR3K0DXlC8P07oE4Z/2EPIHMrhJ+BedC2Z4zMY4hxQQcTu9RTA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2017 06:28:05.1797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2281 Subject: [dpdk-dev] [PATCH 2/2] net/liquidio: fix null pointer check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 06:28:08 -0000 Fix null pointer check in release Rx/Tx queue APIs. Reported by Coverity scan: 1423923 Dereference before null check 1423924 Dereference before null check Fixes: 9a30013b9884 ("net/liquidio: add API to release Rx queue") Fixes: cf6bfcbea178 ("net/liquidio: add API to release Tx queue") Signed-off-by: Shijith Thotton --- drivers/net/liquidio/lio_ethdev.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index df91659..a65c749 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -1155,14 +1155,13 @@ struct rte_lio_xstats_name_off { lio_dev_rx_queue_release(void *rxq) { struct lio_droq *droq = rxq; - struct lio_device *lio_dev = droq->lio_dev; int oq_no; - /* Run time queue deletion not supported */ - if (lio_dev->port_configured) - return; + if (droq) { + /* Run time queue deletion not supported */ + if (droq->lio_dev->port_configured) + return; - if (droq != NULL) { oq_no = droq->q_no; lio_delete_droq_queue(droq->lio_dev, oq_no); } @@ -1250,14 +1249,14 @@ struct rte_lio_xstats_name_off { lio_dev_tx_queue_release(void *txq) { struct lio_instr_queue *tq = txq; - struct lio_device *lio_dev = tq->lio_dev; uint32_t fw_mapped_iq_no; - /* Run time queue deletion not supported */ - if (lio_dev->port_configured) - return; - if (tq != NULL) { + if (tq) { + /* Run time queue deletion not supported */ + if (tq->lio_dev->port_configured) + return; + /* Free sg_list */ lio_delete_sglist(tq); -- 1.8.3.1