* [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check
@ 2017-04-20 3:27 Wei Zhao
2017-04-20 3:27 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Wei Zhao @ 2017-04-20 3:27 UTC (permalink / raw)
To: dev; +Cc: Wei Zhao
Remove a useless item type check for fdir flow rule.
Fixes: 11777435c72 ("net/ixgbe: parse flow director filter")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 7ce740e..11d8cc9 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2346,16 +2346,9 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,
RTE_FLOW_ERROR_TYPE_ITEM,
item, "Not supported by fdir filter");
return -rte_errno;
- } else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
- memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
- rte_flow_error_set(error, EINVAL,
- RTE_FLOW_ERROR_TYPE_ITEM,
- item, "Not supported by fdir filter");
- return -rte_errno;
}
+
/* check if the next not void item is END */
- index++;
- NEXT_ITEM_OF_PATTERN(item, pattern, index);
if (item->type != RTE_FLOW_ITEM_TYPE_END) {
memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
rte_flow_error_set(error, EINVAL,
--
2.9.3
^ permalink raw reply [flat|nested] 11+ messages in thread* [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type
2017-04-20 3:27 [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Wei Zhao
@ 2017-04-20 3:27 ` Wei Zhao
2017-04-21 2:48 ` Lu, Wenzhuo
2017-04-21 2:35 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 " Wei Zhao
2 siblings, 1 reply; 11+ messages in thread
From: Wei Zhao @ 2017-04-20 3:27 UTC (permalink / raw)
To: dev; +Cc: Wei Zhao
The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4
in special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER.
Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_fdir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index 3b9d60c..6f19b91 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1241,7 +1241,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
hw->mac.type == ixgbe_mac_X550EM_x ||
hw->mac.type == ixgbe_mac_X550EM_a) &&
(rule->ixgbe_fdir.formatted.flow_type ==
- RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) &&
+ IXGBE_ATR_FLOW_TYPE_IPV4) &&
(info->mask.src_port_mask != 0 ||
info->mask.dst_port_mask != 0)) {
PMD_DRV_LOG(ERR, "By this device,"
--
2.9.3
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type
2017-04-20 3:27 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
@ 2017-04-21 2:48 ` Lu, Wenzhuo
2017-04-27 6:01 ` Zhao1, Wei
0 siblings, 1 reply; 11+ messages in thread
From: Lu, Wenzhuo @ 2017-04-21 2:48 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Zhao1, Wei
Hi Wei,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Thursday, April 20, 2017 11:28 AM
> To: dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow
> type
>
> The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4 in
> special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER.
>
> Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_fdir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
> index 3b9d60c..6f19b91 100644
> --- a/drivers/net/ixgbe/ixgbe_fdir.c
> +++ b/drivers/net/ixgbe/ixgbe_fdir.c
> @@ -1241,7 +1241,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
> hw->mac.type == ixgbe_mac_X550EM_x ||
> hw->mac.type == ixgbe_mac_X550EM_a) &&
> (rule->ixgbe_fdir.formatted.flow_type ==
> - RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) &&
> + IXGBE_ATR_FLOW_TYPE_IPV4) &&
> (info->mask.src_port_mask != 0 ||
> info->mask.dst_port_mask != 0)) {
> PMD_DRV_LOG(ERR, "By this device,"
> --
> 2.9.3
It's a good fix. But please change the comments and error log accordingly.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type
2017-04-21 2:48 ` Lu, Wenzhuo
@ 2017-04-27 6:01 ` Zhao1, Wei
0 siblings, 0 replies; 11+ messages in thread
From: Zhao1, Wei @ 2017-04-27 6:01 UTC (permalink / raw)
To: Lu, Wenzhuo, dev
Hi， Wenzhuo
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, April 21, 2017 10:49 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow
> type
>
> Hi Wei,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Thursday, April 20, 2017 11:28 AM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei
> > Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for
> > flow type
> >
> > The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4 in
> > special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER.
> >
> > Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_fdir.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c
> > b/drivers/net/ixgbe/ixgbe_fdir.c index 3b9d60c..6f19b91 100644
> > --- a/drivers/net/ixgbe/ixgbe_fdir.c
> > +++ b/drivers/net/ixgbe/ixgbe_fdir.c
> > @@ -1241,7 +1241,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev
> *dev,
> > hw->mac.type == ixgbe_mac_X550EM_x ||
> > hw->mac.type == ixgbe_mac_X550EM_a) &&
> > (rule->ixgbe_fdir.formatted.flow_type ==
> > - RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) &&
> > + IXGBE_ATR_FLOW_TYPE_IPV4) &&
> > (info->mask.src_port_mask != 0 ||
> > info->mask.dst_port_mask != 0)) {
> > PMD_DRV_LOG(ERR, "By this device,"
> > --
> > 2.9.3
> It’s a good fix. But please change the comments and error log accordingly.
I will commit a new v2 for this patch as your suggestion.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check
2017-04-20 3:27 [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Wei Zhao
2017-04-20 3:27 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
@ 2017-04-21 2:35 ` Lu, Wenzhuo
2017-04-27 6:07 ` Zhao1, Wei
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 " Wei Zhao
2 siblings, 1 reply; 11+ messages in thread
From: Lu, Wenzhuo @ 2017-04-21 2:35 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Zhao1, Wei
Hi Wei,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Thursday, April 20, 2017 11:28 AM
> To: dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check
>
> Remove a useless item type check for fdir flow rule.
>
> Fixes: 11777435c72 ("net/ixgbe: parse flow director filter")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index 7ce740e..11d8cc9 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2346,16 +2346,9 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> rte_flow_attr *attr,
> RTE_FLOW_ERROR_TYPE_ITEM,
> item, "Not supported by fdir filter");
> return -rte_errno;
> - } else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> - memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> - rte_flow_error_set(error, EINVAL,
> - RTE_FLOW_ERROR_TYPE_ITEM,
> - item, "Not supported by fdir filter");
> - return -rte_errno;
> }
Seems the item type only can be END. Why not remove the VLAN check either?
> +
> /* check if the next not void item is END */
> - index++;
> - NEXT_ITEM_OF_PATTERN(item, pattern, index);
> if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> rte_flow_error_set(error, EINVAL,
> --
> 2.9.3
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check
2017-04-21 2:35 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
@ 2017-04-27 6:07 ` Zhao1, Wei
0 siblings, 0 replies; 11+ messages in thread
From: Zhao1, Wei @ 2017-04-27 6:07 UTC (permalink / raw)
To: Lu, Wenzhuo, dev
Hi, wenzhuo
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, April 21, 2017 10:35 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type
> check
>
> Hi Wei,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Thursday, April 20, 2017 11:28 AM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei
> > Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type
> > check
> >
> > Remove a useless item type check for fdir flow rule.
> >
> > Fixes: 11777435c72 ("net/ixgbe: parse flow director filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_flow.c | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 7ce740e..11d8cc9 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -2346,16 +2346,9 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> > rte_flow_attr *attr,
> > RTE_FLOW_ERROR_TYPE_ITEM,
> > item, "Not supported by fdir filter");
> > return -rte_errno;
> > - } else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> > - memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> > - rte_flow_error_set(error, EINVAL,
> > - RTE_FLOW_ERROR_TYPE_ITEM,
> > - item, "Not supported by fdir filter");
> > - return -rte_errno;
> > }
> Seems the item type only can be END. Why not remove the VLAN check
> either?
Ok， I will commit a new v2 for this.
>
> > +
> > /* check if the next not void item is END */
> > - index++;
> > - NEXT_ITEM_OF_PATTERN(item, pattern, index);
> > if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> > memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> > rte_flow_error_set(error, EINVAL,
> > --
> > 2.9.3
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check
2017-04-20 3:27 [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Wei Zhao
2017-04-20 3:27 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-21 2:35 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
@ 2017-04-27 6:34 ` Wei Zhao
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-27 7:15 ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2 siblings, 2 replies; 11+ messages in thread
From: Wei Zhao @ 2017-04-27 6:34 UTC (permalink / raw)
To: dev; +Cc: Wei Zhao
Remove a useless item type check for fdir flow rule.
v2:
-delete item type check of vlan
aFixes: 11777435c72 ("net/ixgbe: parse flow director filter")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 98e414a..59ddba6 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2305,27 +2305,10 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,
rule->mask.vlan_tci_mask &= rte_cpu_to_be_16(0xEFFF);
/* More than one tags are not supported. */
- /**
- * Check if the next not void item is not vlan.
- */
- index++;
- NEXT_ITEM_OF_PATTERN(item, pattern, index);
- if (item->type == RTE_FLOW_ITEM_TYPE_VLAN) {
- memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
- rte_flow_error_set(error, EINVAL,
- RTE_FLOW_ERROR_TYPE_ITEM,
- item, "Not supported by fdir filter");
- return -rte_errno;
- } else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
- memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
- rte_flow_error_set(error, EINVAL,
- RTE_FLOW_ERROR_TYPE_ITEM,
- item, "Not supported by fdir filter");
- return -rte_errno;
- }
/* check if the next not void item is END */
index++;
NEXT_ITEM_OF_PATTERN(item, pattern, index);
+
if (item->type != RTE_FLOW_ITEM_TYPE_END) {
memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
rte_flow_error_set(error, EINVAL,
--
2.9.3
^ permalink raw reply [flat|nested] 11+ messages in thread* [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 " Wei Zhao
@ 2017-04-27 6:34 ` Wei Zhao
2017-04-27 7:14 ` Lu, Wenzhuo
2017-04-27 7:15 ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
1 sibling, 1 reply; 11+ messages in thread
From: Wei Zhao @ 2017-04-27 6:34 UTC (permalink / raw)
To: dev; +Cc: Wei Zhao
The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4
in special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER.
v2:
-change the comments and error log accordingly.
Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_fdir.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
index 3b9d60c..d6e48e9 100644
--- a/drivers/net/ixgbe/ixgbe_fdir.c
+++ b/drivers/net/ixgbe/ixgbe_fdir.c
@@ -1232,7 +1232,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
/*
* Sanity check for x550.
- * When adding a new filter with flow type set to IPv4-other,
+ * When adding a new filter with flow type set to IPv4,
* the flow director mask should be configed before,
* and the L4 protocol and ports are masked.
*/
@@ -1241,11 +1241,11 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,
hw->mac.type == ixgbe_mac_X550EM_x ||
hw->mac.type == ixgbe_mac_X550EM_a) &&
(rule->ixgbe_fdir.formatted.flow_type ==
- RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) &&
+ IXGBE_ATR_FLOW_TYPE_IPV4) &&
(info->mask.src_port_mask != 0 ||
info->mask.dst_port_mask != 0)) {
PMD_DRV_LOG(ERR, "By this device,"
- " IPv4-other is not supported without"
+ " IPv4 is not supported without"
" L4 protocol and ports masked!");
return -ENOTSUP;
}
--
2.9.3
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
@ 2017-04-27 7:14 ` Lu, Wenzhuo
0 siblings, 0 replies; 11+ messages in thread
From: Lu, Wenzhuo @ 2017-04-27 7:14 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Zhao1, Wei
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Thursday, April 27, 2017 2:34 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow
> type
>
> The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4 in
> special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER.
>
> v2:
> -change the comments and error log accordingly.
>
> Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 " Wei Zhao
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
@ 2017-04-27 7:15 ` Lu, Wenzhuo
2017-04-27 9:17 ` Ferruh Yigit
1 sibling, 1 reply; 11+ messages in thread
From: Lu, Wenzhuo @ 2017-04-27 7:15 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Zhao1, Wei
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Thursday, April 27, 2017 2:34 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type
> check
>
> Remove a useless item type check for fdir flow rule.
>
> v2:
> -delete item type check of vlan
>
> aFixes: 11777435c72 ("net/ixgbe: parse flow director filter")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check
2017-04-27 7:15 ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
@ 2017-04-27 9:17 ` Ferruh Yigit
0 siblings, 0 replies; 11+ messages in thread
From: Ferruh Yigit @ 2017-04-27 9:17 UTC (permalink / raw)
To: Lu, Wenzhuo, Zhao1, Wei, dev
On 4/27/2017 8:15 AM, Lu, Wenzhuo wrote:
> Hi,
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
>> Sent: Thursday, April 27, 2017 2:34 PM
>> To: dev@dpdk.org
>> Cc: Zhao1, Wei
>> Subject: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type
>> check
>>
>> Remove a useless item type check for fdir flow rule.
>>
>> v2:
>> -delete item type check of vlan
>>
>> aFixes: 11777435c72 ("net/ixgbe: parse flow director filter")
>>
>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-04-27 9:17 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 3:27 [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Wei Zhao
2017-04-20 3:27 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-21 2:48 ` Lu, Wenzhuo
2017-04-27 6:01 ` Zhao1, Wei
2017-04-21 2:35 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27 6:07 ` Zhao1, Wei
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 " Wei Zhao
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-27 7:14 ` Lu, Wenzhuo
2017-04-27 7:15 ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27 9:17 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).